Re: [OE-core] [PATCH 3/9] mtd-utils: disable LZO by default

[richard.purdie@linuxfoundation.org]

On Tue, 2022-05-24 at 16:23 +0100, Ross Burton wrote:
> LZO is a fairly obsolete compression format these days, so disable it by
> default.
> 
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>  meta/recipes-devtools/mtd/mtd-utils_git.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/mtd/mtd-utils_git.bb b/meta/recipes-devtools/mtd/mtd-utils_git.bb
> index 3318277477f..8931e870324 100644
> --- a/meta/recipes-devtools/mtd/mtd-utils_git.bb
> +++ b/meta/recipes-devtools/mtd/mtd-utils_git.bb
> @@ -23,7 +23,7 @@ S = "${WORKDIR}/git"
>  # xattr support creates an additional compile-time dependency on acl because
>  # the sys/acl.h header is needed. libacl is not needed and thus enabling xattr
>  # regardless whether acl is enabled or disabled in the distro should be okay.
> -PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'xattr', d)} lzo jffs ubifs"
> +PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'xattr', d)} jffs ubifs"
>  PACKAGECONFIG[lzo] = "--with-lzo,--without-lzo,lzo"
>  PACKAGECONFIG[xattr] = "--with-xattr,--without-xattr,acl"
>  PACKAGECONFIG[crypto] = "--with-crypto,--without-crypto,openssl"

This and kernel compression are the two pieces that worry me a little.
LZO is still probably one of the best speed/size compromises and was
the reason it was added to jffs2. I'm not sure there are many devices
that still use flash directly via jffs2 but this probably still does
have a use there. Obviously it would still be in meta-oe but I'm
worried the "off by default" will catch out a few old BSPs and be a
pain to enable. At lot of this history was paged out in long term
storage!

Cheers,

Richard