From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D3B4C433EF for ; Thu, 27 Jan 2022 09:17:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231544AbiA0JRU (ORCPT ); Thu, 27 Jan 2022 04:17:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230114AbiA0JRU (ORCPT ); Thu, 27 Jan 2022 04:17:20 -0500 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D53D4C061714 for ; Thu, 27 Jan 2022 01:17:19 -0800 (PST) Received: by mail-lj1-x22c.google.com with SMTP id t14so3310254ljh.8 for ; Thu, 27 Jan 2022 01:17:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=o4tzvhRV4q0XUKGJ8dgFWjAQjVrEQUydtT8zgZxL6O8=; b=hq//Oqh0t+LSYYD1W8tLiNbrtErl4z04ToDVMhWDciUtnz4MvYE3C/XQerx/hVMak7 pwOW0rfdWEQhwYFf8M1aNZY0lyBUyWMXLUTOcJEYYcSA0wFi3qlvUlkRR0vN6j5pcOpd vXAtC6MaXS9aLuRAp2U7fUJvRGZiN5pfFD7LCHzcrZQmhU3vuqp+7x+jw3Aoyx+UcdYO zXamjSlU6Y/12mh3aXhyVhRvqVIXiN3qsqyDfakUk/305hnkXwCW9KtRAbCICc2boKAI mEolgGsO8uEF4PQoEZS3Zh6PJzSYvyoSfgahPlrTSbwyPq3UKjdeI8y2XBkcEXic8GSD gcaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=o4tzvhRV4q0XUKGJ8dgFWjAQjVrEQUydtT8zgZxL6O8=; b=VdMEDQj1Un+esLQs+Pcqfq90QLb5g1tFA/kVQbm6bFmoFBar9kgu5e/nuXq/SvZ7nk bQrwJpD1RJnDq5UIiyqk+e78+tImo8/iiY4mTYIQvcVt3B6dMS9Zi5GwwZTj48CzbyYJ GuUyp+5Zm8TzlGrUdruGnfMiuE4rQfWLMqQyzBdBbGp7b4/yxNzP4GJ7fDoLWZOkXdop a9S8vctSp+2JG8/fnhqe8F2KcUp8nrWFdSBr8L5XmvpBNNTpUjL5K5fTCdKoMW1gy/L7 7MwVeOt+62sS+N9Da2enMpNLBlqgOmAJwPy6EQ4KdsOAr57fB4Xz33K3sPueN7E4C9a0 lM8w== X-Gm-Message-State: AOAM533LxaOm3+G7aZrkeT6KCojTgFMoAAYuNmyhTKPPmQommYYiMtTM jZAkr7xlpwt4jeYnSWIOdQo= X-Google-Smtp-Source: ABdhPJyrAxTqYqNo/buunWM+RzljgXBFTNIVZZSw0F9X8RJg2othqm6DAnqjvIzcGTTV7CqWTXsneA== X-Received: by 2002:a05:651c:d2:: with SMTP id 18mr2131144ljr.399.1643275037959; Thu, 27 Jan 2022 01:17:17 -0800 (PST) Received: from smtpclient.apple (31-178-191-245.dynamic.chello.pl. [31.178.191.245]) by smtp.gmail.com with ESMTPSA id h28sm1597872lfe.196.2022.01.27.01.17.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jan 2022 01:17:17 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: [PATCH 27/27] drm: rockchip: Add VOP2 driver From: Piotr Oniszczuk In-Reply-To: <20220126145549.617165-28-s.hauer@pengutronix.de> Date: Thu, 27 Jan 2022 10:17:13 +0100 Cc: dri-devel@lists.freedesktop.org, "linux-arm-kernel@lists.infradead.org" , linux-rockchip@lists.infradead.org, "devicetree@vger.kernel.org" , kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , =?utf-8?Q?Heiko_St=C3=BCbner?= , Peter Geis Content-Transfer-Encoding: quoted-printable Message-Id: <6588D77C-D3CB-4FB0-8B00-5EDD6ABD6923@gmail.com> References: <20220126145549.617165-1-s.hauer@pengutronix.de> <20220126145549.617165-28-s.hauer@pengutronix.de> To: Sascha Hauer X-Mailer: Apple Mail (2.3654.120.0.1.13) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Sascha, FYI=20 small report regarding 4k modes support in v4: -on rk3399 it gives me 4k screen where right vertical 1/3 part of screen = is garbage -on rk3566 my samsung 4k monitor has black screen and cycle of OSD msgs: = HDMI2 connected; HDMI2 disconnected; .... I would suggest split v4 into 2 separated series: -VOP2 support -HDMI 4k modes support BTW: getting well working 4k HDMI modes on rk3399 was real story for me. There is many different series of patches to address this - but all have = some subtle issues for me (i.e. 4k HDMI modes works but i.e. Qt is = failing with DRM atomic commits in EGLFS) I developed well working [1] giving me reliable 4k on rk3399 (including = working Qt DRM drawing in EGLFS mode)=20 Maybe it will be somehow helpful to get 4k modes solution for rk3566 = _and_ rk3399 (on single kernel binary)? [1] = https://github.com/warpme/minimyth2/blob/master/script/kernel/linux-5.16/f= iles/0730-drm-rockchip-add-4k-videomodes-support.patch br > Wiadomo=C5=9B=C4=87 napisana przez Sascha Hauer = w dniu 26.01.2022, o godz. 15:55: >=20 > From: Andy Yan >=20 > The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. > It replaces the VOP unit found in the older Rockchip SoCs. >=20 > This driver has been derived from the downstream Rockchip Kernel and > heavily modified: >=20 > - All nonstandard DRM properties have been removed > - dropped struct vop2_plane_state and pass around less data between > functions > - Dropped all DRM_FORMAT_* not known on upstream > - rework register access to get rid of excessively used macros > - Drop all waiting for framesyncs >=20 > The driver is tested with HDMI and MIPI-DSI display on a RK3568-EVB > board. Overlay support is tested with the modetest utility. AFBC = support > on the cluster windows is tested with weston-simple-dmabuf-egl on > weston using the (yet to be upstreamed) panfrost driver support. >=20 > Changes since v3: > - Sort includes > - fix typos > - Drop spinlock > - Use regmap_set_bits()/regmap_clear_bits() > - simplify vop2_scale_factor() > - simplify vop2_afbc_transform_offset() >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0329C433F5 for ; Thu, 27 Jan 2022 09:17:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:References:Message-Id:Cc:Date: In-Reply-To:From:Subject:Mime-Version:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JugDb70fc9d6fBHrGT12PutnAzWc5l/+V+GAneSt3AI=; b=Qc2izffzWK2QYE NAWwjoMSae1spuYszA5TZuMoX2SYQzajZvi7VUWNbSJlGSdJ/tQ6qKcoxMvTYmJ1rK1fzkUJIgAqk jAy9ANz+W3GckDD9AAtSEXfEaUrzLgy+CZqZjo4v4+PTkWx/U3rx5RVT8btVenBpWcEm1+o6W3Tla C+wp4O48BNLAa60XRaZoewhVBrKyxMWml77/nKnJ5HINLt+pePkTrQLhlivg2FgOpQYkwYBKGtoL2 j3bud/L3Ck4I1k7Rsisc75Y4nNCsHi8s/U6bomGUm+OnuFnw1Yy7sYeH4JEkZKED12QydggKrwoMC lIoq53HQZ+WmP2kLycSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nD0uT-00EqZb-GS; Thu, 27 Jan 2022 09:17:41 +0000 Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nD0u8-00EqSv-Kk; Thu, 27 Jan 2022 09:17:22 +0000 Received: by mail-lj1-x22d.google.com with SMTP id b14so3421336ljb.0; Thu, 27 Jan 2022 01:17:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=o4tzvhRV4q0XUKGJ8dgFWjAQjVrEQUydtT8zgZxL6O8=; b=hq//Oqh0t+LSYYD1W8tLiNbrtErl4z04ToDVMhWDciUtnz4MvYE3C/XQerx/hVMak7 pwOW0rfdWEQhwYFf8M1aNZY0lyBUyWMXLUTOcJEYYcSA0wFi3qlvUlkRR0vN6j5pcOpd vXAtC6MaXS9aLuRAp2U7fUJvRGZiN5pfFD7LCHzcrZQmhU3vuqp+7x+jw3Aoyx+UcdYO zXamjSlU6Y/12mh3aXhyVhRvqVIXiN3qsqyDfakUk/305hnkXwCW9KtRAbCICc2boKAI mEolgGsO8uEF4PQoEZS3Zh6PJzSYvyoSfgahPlrTSbwyPq3UKjdeI8y2XBkcEXic8GSD gcaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=o4tzvhRV4q0XUKGJ8dgFWjAQjVrEQUydtT8zgZxL6O8=; b=bTY+yfh6wA5ot0Ir6/sJw7aWzfCT+oM+YvdVrtr5f5sUNMUzZ2JIeiSxMdM5tC7d4+ YnJwtemiXqcqoizCqHBC8dKpcdm0j23Y+/dgc4Yv52Yj1PP82tM6Z4Vrp2M0ixFyhUQh QeDMoZlCHy4fHM1GcnpH+F0BBrvYiMR+Lf96HEmLpf2FAyfw97X0xHG+ImZAFgQjHyK/ GVY22iq3MQK1ifJe8MmEB+DV9dQaZppxGbn9Ti75ulH93KYfBWVyQNMT+k7xpNfVMkrZ XxSoXbsim0Ga1Kkdb2F78+nBxbklS2ozOlP8UKjYLp4nO7dpjiGVquDM1fQ0TV4WAUor WxlA== X-Gm-Message-State: AOAM530P/Dt01siXZvgPX5BorO/Oe4dhlED0xieM24UNwDiRcCYHk0Lc o2zZuZJfFdl0/fIDQbU54og= X-Google-Smtp-Source: ABdhPJyrAxTqYqNo/buunWM+RzljgXBFTNIVZZSw0F9X8RJg2othqm6DAnqjvIzcGTTV7CqWTXsneA== X-Received: by 2002:a05:651c:d2:: with SMTP id 18mr2131144ljr.399.1643275037959; Thu, 27 Jan 2022 01:17:17 -0800 (PST) Received: from smtpclient.apple (31-178-191-245.dynamic.chello.pl. [31.178.191.245]) by smtp.gmail.com with ESMTPSA id h28sm1597872lfe.196.2022.01.27.01.17.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jan 2022 01:17:17 -0800 (PST) Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: [PATCH 27/27] drm: rockchip: Add VOP2 driver From: Piotr Oniszczuk In-Reply-To: <20220126145549.617165-28-s.hauer@pengutronix.de> Date: Thu, 27 Jan 2022 10:17:13 +0100 Cc: dri-devel@lists.freedesktop.org, "linux-arm-kernel@lists.infradead.org" , linux-rockchip@lists.infradead.org, "devicetree@vger.kernel.org" , kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , =?utf-8?Q?Heiko_St=C3=BCbner?= , Peter Geis Message-Id: <6588D77C-D3CB-4FB0-8B00-5EDD6ABD6923@gmail.com> References: <20220126145549.617165-1-s.hauer@pengutronix.de> <20220126145549.617165-28-s.hauer@pengutronix.de> To: Sascha Hauer X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220127_011720_747562_B2B24795 X-CRM114-Status: GOOD ( 16.43 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org U2FzY2hhLAoKRllJIApzbWFsbCByZXBvcnQgcmVnYXJkaW5nIDRrIG1vZGVzIHN1cHBvcnQgaW4g djQ6Cgotb24gcmszMzk5IGl0IGdpdmVzIG1lIDRrIHNjcmVlbiB3aGVyZSByaWdodCB2ZXJ0aWNh bCAxLzMgcGFydCBvZiBzY3JlZW4gaXMgZ2FyYmFnZQotb24gcmszNTY2IG15IHNhbXN1bmcgNGsg bW9uaXRvciBoYXMgYmxhY2sgc2NyZWVuIGFuZCBjeWNsZSBvZiBPU0QgbXNnczogSERNSTIgY29u bmVjdGVkOyBIRE1JMiBkaXNjb25uZWN0ZWQ7IC4uLi4KCkkgd291bGQgc3VnZ2VzdCBzcGxpdCB2 NCBpbnRvIDIgc2VwYXJhdGVkIHNlcmllczoKCi1WT1AyIHN1cHBvcnQKLUhETUkgNGsgbW9kZXMg c3VwcG9ydAoKQlRXOiBnZXR0aW5nIHdlbGwgd29ya2luZyA0ayBIRE1JIG1vZGVzIG9uIHJrMzM5 OSB3YXMgcmVhbCBzdG9yeSBmb3IgbWUuClRoZXJlIGlzIG1hbnkgZGlmZmVyZW50IHNlcmllcyBv ZiBwYXRjaGVzIHRvIGFkZHJlc3MgdGhpcyAtIGJ1dCBhbGwgaGF2ZSBzb21lIHN1YnRsZSBpc3N1 ZXMgZm9yIG1lIChpLmUuIDRrIEhETUkgbW9kZXMgd29ya3MgYnV0IGkuZS4gUXQgaXMgZmFpbGlu ZyB3aXRoIERSTSBhdG9taWMgY29tbWl0cyBpbiBFR0xGUykKSSBkZXZlbG9wZWQgd2VsbCB3b3Jr aW5nIFsxXSBnaXZpbmcgbWUgcmVsaWFibGUgNGsgb24gcmszMzk5IChpbmNsdWRpbmcgd29ya2lu ZyBRdCBEUk0gZHJhd2luZyBpbiBFR0xGUyBtb2RlKSAKTWF5YmUgaXQgd2lsbCBiZSBzb21laG93 IGhlbHBmdWwgdG8gZ2V0IDRrIG1vZGVzIHNvbHV0aW9uIGZvciByazM1NjYgX2FuZF8gcmszMzk5 IChvbiBzaW5nbGUga2VybmVsIGJpbmFyeSk/CgpbMV0gaHR0cHM6Ly9naXRodWIuY29tL3dhcnBt ZS9taW5pbXl0aDIvYmxvYi9tYXN0ZXIvc2NyaXB0L2tlcm5lbC9saW51eC01LjE2L2ZpbGVzLzA3 MzAtZHJtLXJvY2tjaGlwLWFkZC00ay12aWRlb21vZGVzLXN1cHBvcnQucGF0Y2gKCmJyCgoKPiBX aWFkb21vxZvEhyBuYXBpc2FuYSBwcnpleiBTYXNjaGEgSGF1ZXIgPHMuaGF1ZXJAcGVuZ3V0cm9u aXguZGU+IHcgZG5pdSAyNi4wMS4yMDIyLCBvIGdvZHouIDE1OjU1Ogo+IAo+IEZyb206IEFuZHkg WWFuIDxhbmR5LnlhbkByb2NrLWNoaXBzLmNvbT4KPiAKPiBUaGUgVk9QMiB1bml0IGlzIGZvdW5k IG9uIFJvY2tjaGlwIFNvQ3MgYmVnaW5uaW5nIHdpdGggcmszNTY2L3JrMzU2OC4KPiBJdCByZXBs YWNlcyB0aGUgVk9QIHVuaXQgZm91bmQgaW4gdGhlIG9sZGVyIFJvY2tjaGlwIFNvQ3MuCj4gCj4g VGhpcyBkcml2ZXIgaGFzIGJlZW4gZGVyaXZlZCBmcm9tIHRoZSBkb3duc3RyZWFtIFJvY2tjaGlw IEtlcm5lbCBhbmQKPiBoZWF2aWx5IG1vZGlmaWVkOgo+IAo+IC0gQWxsIG5vbnN0YW5kYXJkIERS TSBwcm9wZXJ0aWVzIGhhdmUgYmVlbiByZW1vdmVkCj4gLSBkcm9wcGVkIHN0cnVjdCB2b3AyX3Bs YW5lX3N0YXRlIGFuZCBwYXNzIGFyb3VuZCBsZXNzIGRhdGEgYmV0d2Vlbgo+ICBmdW5jdGlvbnMK PiAtIERyb3BwZWQgYWxsIERSTV9GT1JNQVRfKiBub3Qga25vd24gb24gdXBzdHJlYW0KPiAtIHJl d29yayByZWdpc3RlciBhY2Nlc3MgdG8gZ2V0IHJpZCBvZiBleGNlc3NpdmVseSB1c2VkIG1hY3Jv cwo+IC0gRHJvcCBhbGwgd2FpdGluZyBmb3IgZnJhbWVzeW5jcwo+IAo+IFRoZSBkcml2ZXIgaXMg dGVzdGVkIHdpdGggSERNSSBhbmQgTUlQSS1EU0kgZGlzcGxheSBvbiBhIFJLMzU2OC1FVkIKPiBi b2FyZC4gT3ZlcmxheSBzdXBwb3J0IGlzIHRlc3RlZCB3aXRoIHRoZSBtb2RldGVzdCB1dGlsaXR5 LiBBRkJDIHN1cHBvcnQKPiBvbiB0aGUgY2x1c3RlciB3aW5kb3dzIGlzIHRlc3RlZCB3aXRoIHdl c3Rvbi1zaW1wbGUtZG1hYnVmLWVnbCBvbgo+IHdlc3RvbiB1c2luZyB0aGUgKHlldCB0byBiZSB1 cHN0cmVhbWVkKSBwYW5mcm9zdCBkcml2ZXIgc3VwcG9ydC4KPiAKPiBDaGFuZ2VzIHNpbmNlIHYz Ogo+IC0gU29ydCBpbmNsdWRlcwo+IC0gZml4IHR5cG9zCj4gLSBEcm9wIHNwaW5sb2NrCj4gLSBV c2UgcmVnbWFwX3NldF9iaXRzKCkvcmVnbWFwX2NsZWFyX2JpdHMoKQo+IC0gc2ltcGxpZnkgdm9w Ml9zY2FsZV9mYWN0b3IoKQo+IC0gc2ltcGxpZnkgdm9wMl9hZmJjX3RyYW5zZm9ybV9vZmZzZXQo KQo+IAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxp bnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9j a2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 770E5C433EF for ; Thu, 27 Jan 2022 09:19:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:References:Message-Id:Cc:Date: In-Reply-To:From:Subject:Mime-Version:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ka25ZBSzGTnPgN5Bm0Qw0RzZv/pkVs79GrRz44TRT+8=; b=zPut4ZniwFUCgv eH3vnWfXKJAWvU4sagTgsXIBXNyLc2pzPchaRxyr7CQNitVmx2lkPCVQTfaHY6e8Gilf11nSCzBJD oe7grs8NT/Qr3xGd0Vi5Nq4tlK+84Z456yL1AWIoluH9YPebl+IbTkdWxonbUHsgkXcA9fnjBD3ju Lh4C4ADEoYKEDfAbBGngx6rU99ePb37eQBsP2cvKBGaHuFUkCK5zPYy0d6/m39wwlUPrjJc6Wu++V 03f1wEwuLnw7Z9LUuoqgxbJI4dBiCk2lSZESl3s+3qud0OC5JXsLUU3pAoRlRtktPgJtbncaT3bto rJhoZ4q9h64moZDM9SNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nD0uD-00EqUr-0P; Thu, 27 Jan 2022 09:17:25 +0000 Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nD0u8-00EqSv-Kk; Thu, 27 Jan 2022 09:17:22 +0000 Received: by mail-lj1-x22d.google.com with SMTP id b14so3421336ljb.0; Thu, 27 Jan 2022 01:17:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=o4tzvhRV4q0XUKGJ8dgFWjAQjVrEQUydtT8zgZxL6O8=; b=hq//Oqh0t+LSYYD1W8tLiNbrtErl4z04ToDVMhWDciUtnz4MvYE3C/XQerx/hVMak7 pwOW0rfdWEQhwYFf8M1aNZY0lyBUyWMXLUTOcJEYYcSA0wFi3qlvUlkRR0vN6j5pcOpd vXAtC6MaXS9aLuRAp2U7fUJvRGZiN5pfFD7LCHzcrZQmhU3vuqp+7x+jw3Aoyx+UcdYO zXamjSlU6Y/12mh3aXhyVhRvqVIXiN3qsqyDfakUk/305hnkXwCW9KtRAbCICc2boKAI mEolgGsO8uEF4PQoEZS3Zh6PJzSYvyoSfgahPlrTSbwyPq3UKjdeI8y2XBkcEXic8GSD gcaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=o4tzvhRV4q0XUKGJ8dgFWjAQjVrEQUydtT8zgZxL6O8=; b=bTY+yfh6wA5ot0Ir6/sJw7aWzfCT+oM+YvdVrtr5f5sUNMUzZ2JIeiSxMdM5tC7d4+ YnJwtemiXqcqoizCqHBC8dKpcdm0j23Y+/dgc4Yv52Yj1PP82tM6Z4Vrp2M0ixFyhUQh QeDMoZlCHy4fHM1GcnpH+F0BBrvYiMR+Lf96HEmLpf2FAyfw97X0xHG+ImZAFgQjHyK/ GVY22iq3MQK1ifJe8MmEB+DV9dQaZppxGbn9Ti75ulH93KYfBWVyQNMT+k7xpNfVMkrZ XxSoXbsim0Ga1Kkdb2F78+nBxbklS2ozOlP8UKjYLp4nO7dpjiGVquDM1fQ0TV4WAUor WxlA== X-Gm-Message-State: AOAM530P/Dt01siXZvgPX5BorO/Oe4dhlED0xieM24UNwDiRcCYHk0Lc o2zZuZJfFdl0/fIDQbU54og= X-Google-Smtp-Source: ABdhPJyrAxTqYqNo/buunWM+RzljgXBFTNIVZZSw0F9X8RJg2othqm6DAnqjvIzcGTTV7CqWTXsneA== X-Received: by 2002:a05:651c:d2:: with SMTP id 18mr2131144ljr.399.1643275037959; Thu, 27 Jan 2022 01:17:17 -0800 (PST) Received: from smtpclient.apple (31-178-191-245.dynamic.chello.pl. [31.178.191.245]) by smtp.gmail.com with ESMTPSA id h28sm1597872lfe.196.2022.01.27.01.17.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jan 2022 01:17:17 -0800 (PST) Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: [PATCH 27/27] drm: rockchip: Add VOP2 driver From: Piotr Oniszczuk In-Reply-To: <20220126145549.617165-28-s.hauer@pengutronix.de> Date: Thu, 27 Jan 2022 10:17:13 +0100 Cc: dri-devel@lists.freedesktop.org, "linux-arm-kernel@lists.infradead.org" , linux-rockchip@lists.infradead.org, "devicetree@vger.kernel.org" , kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , =?utf-8?Q?Heiko_St=C3=BCbner?= , Peter Geis Message-Id: <6588D77C-D3CB-4FB0-8B00-5EDD6ABD6923@gmail.com> References: <20220126145549.617165-1-s.hauer@pengutronix.de> <20220126145549.617165-28-s.hauer@pengutronix.de> To: Sascha Hauer X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220127_011720_747562_B2B24795 X-CRM114-Status: GOOD ( 16.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org U2FzY2hhLAoKRllJIApzbWFsbCByZXBvcnQgcmVnYXJkaW5nIDRrIG1vZGVzIHN1cHBvcnQgaW4g djQ6Cgotb24gcmszMzk5IGl0IGdpdmVzIG1lIDRrIHNjcmVlbiB3aGVyZSByaWdodCB2ZXJ0aWNh bCAxLzMgcGFydCBvZiBzY3JlZW4gaXMgZ2FyYmFnZQotb24gcmszNTY2IG15IHNhbXN1bmcgNGsg bW9uaXRvciBoYXMgYmxhY2sgc2NyZWVuIGFuZCBjeWNsZSBvZiBPU0QgbXNnczogSERNSTIgY29u bmVjdGVkOyBIRE1JMiBkaXNjb25uZWN0ZWQ7IC4uLi4KCkkgd291bGQgc3VnZ2VzdCBzcGxpdCB2 NCBpbnRvIDIgc2VwYXJhdGVkIHNlcmllczoKCi1WT1AyIHN1cHBvcnQKLUhETUkgNGsgbW9kZXMg c3VwcG9ydAoKQlRXOiBnZXR0aW5nIHdlbGwgd29ya2luZyA0ayBIRE1JIG1vZGVzIG9uIHJrMzM5 OSB3YXMgcmVhbCBzdG9yeSBmb3IgbWUuClRoZXJlIGlzIG1hbnkgZGlmZmVyZW50IHNlcmllcyBv ZiBwYXRjaGVzIHRvIGFkZHJlc3MgdGhpcyAtIGJ1dCBhbGwgaGF2ZSBzb21lIHN1YnRsZSBpc3N1 ZXMgZm9yIG1lIChpLmUuIDRrIEhETUkgbW9kZXMgd29ya3MgYnV0IGkuZS4gUXQgaXMgZmFpbGlu ZyB3aXRoIERSTSBhdG9taWMgY29tbWl0cyBpbiBFR0xGUykKSSBkZXZlbG9wZWQgd2VsbCB3b3Jr aW5nIFsxXSBnaXZpbmcgbWUgcmVsaWFibGUgNGsgb24gcmszMzk5IChpbmNsdWRpbmcgd29ya2lu ZyBRdCBEUk0gZHJhd2luZyBpbiBFR0xGUyBtb2RlKSAKTWF5YmUgaXQgd2lsbCBiZSBzb21laG93 IGhlbHBmdWwgdG8gZ2V0IDRrIG1vZGVzIHNvbHV0aW9uIGZvciByazM1NjYgX2FuZF8gcmszMzk5 IChvbiBzaW5nbGUga2VybmVsIGJpbmFyeSk/CgpbMV0gaHR0cHM6Ly9naXRodWIuY29tL3dhcnBt ZS9taW5pbXl0aDIvYmxvYi9tYXN0ZXIvc2NyaXB0L2tlcm5lbC9saW51eC01LjE2L2ZpbGVzLzA3 MzAtZHJtLXJvY2tjaGlwLWFkZC00ay12aWRlb21vZGVzLXN1cHBvcnQucGF0Y2gKCmJyCgoKPiBX aWFkb21vxZvEhyBuYXBpc2FuYSBwcnpleiBTYXNjaGEgSGF1ZXIgPHMuaGF1ZXJAcGVuZ3V0cm9u aXguZGU+IHcgZG5pdSAyNi4wMS4yMDIyLCBvIGdvZHouIDE1OjU1Ogo+IAo+IEZyb206IEFuZHkg WWFuIDxhbmR5LnlhbkByb2NrLWNoaXBzLmNvbT4KPiAKPiBUaGUgVk9QMiB1bml0IGlzIGZvdW5k IG9uIFJvY2tjaGlwIFNvQ3MgYmVnaW5uaW5nIHdpdGggcmszNTY2L3JrMzU2OC4KPiBJdCByZXBs YWNlcyB0aGUgVk9QIHVuaXQgZm91bmQgaW4gdGhlIG9sZGVyIFJvY2tjaGlwIFNvQ3MuCj4gCj4g VGhpcyBkcml2ZXIgaGFzIGJlZW4gZGVyaXZlZCBmcm9tIHRoZSBkb3duc3RyZWFtIFJvY2tjaGlw IEtlcm5lbCBhbmQKPiBoZWF2aWx5IG1vZGlmaWVkOgo+IAo+IC0gQWxsIG5vbnN0YW5kYXJkIERS TSBwcm9wZXJ0aWVzIGhhdmUgYmVlbiByZW1vdmVkCj4gLSBkcm9wcGVkIHN0cnVjdCB2b3AyX3Bs YW5lX3N0YXRlIGFuZCBwYXNzIGFyb3VuZCBsZXNzIGRhdGEgYmV0d2Vlbgo+ICBmdW5jdGlvbnMK PiAtIERyb3BwZWQgYWxsIERSTV9GT1JNQVRfKiBub3Qga25vd24gb24gdXBzdHJlYW0KPiAtIHJl d29yayByZWdpc3RlciBhY2Nlc3MgdG8gZ2V0IHJpZCBvZiBleGNlc3NpdmVseSB1c2VkIG1hY3Jv cwo+IC0gRHJvcCBhbGwgd2FpdGluZyBmb3IgZnJhbWVzeW5jcwo+IAo+IFRoZSBkcml2ZXIgaXMg dGVzdGVkIHdpdGggSERNSSBhbmQgTUlQSS1EU0kgZGlzcGxheSBvbiBhIFJLMzU2OC1FVkIKPiBi b2FyZC4gT3ZlcmxheSBzdXBwb3J0IGlzIHRlc3RlZCB3aXRoIHRoZSBtb2RldGVzdCB1dGlsaXR5 LiBBRkJDIHN1cHBvcnQKPiBvbiB0aGUgY2x1c3RlciB3aW5kb3dzIGlzIHRlc3RlZCB3aXRoIHdl c3Rvbi1zaW1wbGUtZG1hYnVmLWVnbCBvbgo+IHdlc3RvbiB1c2luZyB0aGUgKHlldCB0byBiZSB1 cHN0cmVhbWVkKSBwYW5mcm9zdCBkcml2ZXIgc3VwcG9ydC4KPiAKPiBDaGFuZ2VzIHNpbmNlIHYz Ogo+IC0gU29ydCBpbmNsdWRlcwo+IC0gZml4IHR5cG9zCj4gLSBEcm9wIHNwaW5sb2NrCj4gLSBV c2UgcmVnbWFwX3NldF9iaXRzKCkvcmVnbWFwX2NsZWFyX2JpdHMoKQo+IC0gc2ltcGxpZnkgdm9w Ml9zY2FsZV9mYWN0b3IoKQo+IC0gc2ltcGxpZnkgdm9wMl9hZmJjX3RyYW5zZm9ybV9vZmZzZXQo KQo+IAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F0A8C433F5 for ; Thu, 27 Jan 2022 14:57:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3156D10EECC; Thu, 27 Jan 2022 14:57:23 +0000 (UTC) Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by gabe.freedesktop.org (Postfix) with ESMTPS id CA94F10EEF3 for ; Thu, 27 Jan 2022 09:17:19 +0000 (UTC) Received: by mail-lj1-x22d.google.com with SMTP id q22so3333847ljh.7 for ; Thu, 27 Jan 2022 01:17:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=o4tzvhRV4q0XUKGJ8dgFWjAQjVrEQUydtT8zgZxL6O8=; b=hq//Oqh0t+LSYYD1W8tLiNbrtErl4z04ToDVMhWDciUtnz4MvYE3C/XQerx/hVMak7 pwOW0rfdWEQhwYFf8M1aNZY0lyBUyWMXLUTOcJEYYcSA0wFi3qlvUlkRR0vN6j5pcOpd vXAtC6MaXS9aLuRAp2U7fUJvRGZiN5pfFD7LCHzcrZQmhU3vuqp+7x+jw3Aoyx+UcdYO zXamjSlU6Y/12mh3aXhyVhRvqVIXiN3qsqyDfakUk/305hnkXwCW9KtRAbCICc2boKAI mEolgGsO8uEF4PQoEZS3Zh6PJzSYvyoSfgahPlrTSbwyPq3UKjdeI8y2XBkcEXic8GSD gcaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=o4tzvhRV4q0XUKGJ8dgFWjAQjVrEQUydtT8zgZxL6O8=; b=aJd8WBCBlgIjfBKXfDoSnZi7wMFfVrCAwEjCX2DiigzAQx9WJD2IoPa6+O/dsof4NL tfawPaIUa3HCEjNNHFUc4UKOiOGZ8GpATAeG1PJJYExEMWnorh4nQ+70HA3C9ZUJVd+0 +npF4S06SIxdAHPrZIayaJ/iSJxvTSnaErzzOUiizNgTzMLJhx+PI9SGE39NG7OZg1+k PZ4BkMx8T7lT+AtXOKu8xqOm1sVkW3C9EjxGbazDI/XwOfRh4ynG3NqOKBNGGb2XULmX rD0aT0kwWf6E0E8H1GSFC4IAe8m6HwYX17qq4xQwCrh1Z6VlOYjpDUeeRtr04s7Oc+0G lE9A== X-Gm-Message-State: AOAM533JUK+BLce5I2MPdKnLSSubb1dEdQtp8zHG/HvvyruOAaBOpVZM FzsFxja+yxKpeKBnTIQvl1MJnYCw4Cg= X-Google-Smtp-Source: ABdhPJyrAxTqYqNo/buunWM+RzljgXBFTNIVZZSw0F9X8RJg2othqm6DAnqjvIzcGTTV7CqWTXsneA== X-Received: by 2002:a05:651c:d2:: with SMTP id 18mr2131144ljr.399.1643275037959; Thu, 27 Jan 2022 01:17:17 -0800 (PST) Received: from smtpclient.apple (31-178-191-245.dynamic.chello.pl. [31.178.191.245]) by smtp.gmail.com with ESMTPSA id h28sm1597872lfe.196.2022.01.27.01.17.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jan 2022 01:17:17 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: [PATCH 27/27] drm: rockchip: Add VOP2 driver From: Piotr Oniszczuk In-Reply-To: <20220126145549.617165-28-s.hauer@pengutronix.de> Date: Thu, 27 Jan 2022 10:17:13 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <6588D77C-D3CB-4FB0-8B00-5EDD6ABD6923@gmail.com> References: <20220126145549.617165-1-s.hauer@pengutronix.de> <20220126145549.617165-28-s.hauer@pengutronix.de> To: Sascha Hauer X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Mailman-Approved-At: Thu, 27 Jan 2022 14:57:22 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Benjamin Gaignard , Peter Geis , Sandy Huang , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Andy Yan , "linux-arm-kernel@lists.infradead.org" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Sascha, FYI=20 small report regarding 4k modes support in v4: -on rk3399 it gives me 4k screen where right vertical 1/3 part of screen = is garbage -on rk3566 my samsung 4k monitor has black screen and cycle of OSD msgs: = HDMI2 connected; HDMI2 disconnected; .... I would suggest split v4 into 2 separated series: -VOP2 support -HDMI 4k modes support BTW: getting well working 4k HDMI modes on rk3399 was real story for me. There is many different series of patches to address this - but all have = some subtle issues for me (i.e. 4k HDMI modes works but i.e. Qt is = failing with DRM atomic commits in EGLFS) I developed well working [1] giving me reliable 4k on rk3399 (including = working Qt DRM drawing in EGLFS mode)=20 Maybe it will be somehow helpful to get 4k modes solution for rk3566 = _and_ rk3399 (on single kernel binary)? [1] = https://github.com/warpme/minimyth2/blob/master/script/kernel/linux-5.16/f= iles/0730-drm-rockchip-add-4k-videomodes-support.patch br > Wiadomo=C5=9B=C4=87 napisana przez Sascha Hauer = w dniu 26.01.2022, o godz. 15:55: >=20 > From: Andy Yan >=20 > The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. > It replaces the VOP unit found in the older Rockchip SoCs. >=20 > This driver has been derived from the downstream Rockchip Kernel and > heavily modified: >=20 > - All nonstandard DRM properties have been removed > - dropped struct vop2_plane_state and pass around less data between > functions > - Dropped all DRM_FORMAT_* not known on upstream > - rework register access to get rid of excessively used macros > - Drop all waiting for framesyncs >=20 > The driver is tested with HDMI and MIPI-DSI display on a RK3568-EVB > board. Overlay support is tested with the modetest utility. AFBC = support > on the cluster windows is tested with weston-simple-dmabuf-egl on > weston using the (yet to be upstreamed) panfrost driver support. >=20 > Changes since v3: > - Sort includes > - fix typos > - Drop spinlock > - Use regmap_set_bits()/regmap_clear_bits() > - simplify vop2_scale_factor() > - simplify vop2_afbc_transform_offset() >=20