From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753119AbcAPXgc (ORCPT ); Sat, 16 Jan 2016 18:36:32 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:60145 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752902AbcAPXga (ORCPT ); Sat, 16 Jan 2016 18:36:30 -0500 From: Arnd Bergmann To: Andreas Dilger Cc: y2038@lists.linaro.org, Dave Chinner , linux-fsdevel@vger.kernel.org, Deepa Dinamani , linux-kernel@vger.kernel.org Subject: Re: [Y2038] [RFC 02/15] vfs: Change all structures to support 64 bit time Date: Sun, 17 Jan 2016 00:36:23 +0100 Message-ID: <6591497.mpSR1PpHzG@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1452144972-15802-1-git-send-email-deepa.kernel@gmail.com> <4756197.dta9JQvfZs@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:W1ba31tfBqHTMBbPGDN4gDJVIWPn4X8zjPr/3G7FPGFw1KP9yNH sQojB4ZWPnRoEtQyD/OPTf7cH9DhIOfHQZMTRTex7wXWACZlkjNe6YNMGYo0FZopN6DVLDs i6yjDdJ6KVcjIAMBQScCUtGetTi9bllnbLXJ9gtyPIe7dAO8fwbNeSoJYeC8Mha/KfVx6g7 Ex9vRrf4y8ZiIP7vPDsbQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:MY/GcvXWxOo=:j1XOJ4CUcZvr1GIoRodeH0 GmywW7qojSVQ/nJMVc6rUTO34xtcR90isk7st0w7NNUQt01UnrVlXibdqe3ZlZZBC9ptU216p zqU+gda6L2qk3h4aXIloKRYSJzRaEoKC8NN3jRxQyfaU4spiy8d+Ct4K0JbNgcuxoIEBRM10C uUbgiIiTqkMh6OlxqrFf9wAuk0Zf7dJ1D4DUV1tQNkD4g9Llg8cQb+7tmL+u/JBObQivV3Br4 cD7ghBC3lKCKMpRq52r9mkBTOhgFY+7t8WYoXSceCakRjjjVaCg6I8UCzTHjo9hT/ESBNle3U /PhCH8bJfxdZW26w/UALnjHLOU52Pcs5ZGUWDPM5O42uQ4bMkp8ir+REYC3TlpvYGkaQOWPpV rrrXwT8qAmYvaBGnzHFXs2vbjPxBMOnRRyq4vWEuv5LnKJpG8Ddeibg2WdAAdGg1bs2S16PlS 0OL7elDWwq8kSgtaNZsbeBWUTYBkONm+TqI5Q8zTyyvFQHruyicRxkQSY9IuGCxfzIbGSiB9v AKmVyv7UFwbw+ukZ9vOmassD7DIf87u5tVMtQJhZCdandNZP9Xdz1nupqxHLU/psWYQQjxDcz +YWr/S2Q3+1rZ0psHt7cz8uZVhevB5+a7NwEvqmk4lsFk3D/ftareJY7PZLFnY3Lhj3A3gHBP lAXVfka+69hEhFhrQxiDGqDOKXah8UcYJDmJ2mexmQzlJv3TIm6jJr/O3YQoQUHj6eOcmi/pG xKubWsVrecfYqSAZ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday 16 January 2016 12:14:22 Andreas Dilger wrote: > >> > >> Sure, and nfs is a pain because of all it's internal use of > >> timespecs, too. > > > > lustre is probably the worst. > > Lustre currently only has one-second granularity in a 64-bit field, > so it doesn't really care about the difference between timespec or > timespec64 at all. > > The only other uses are for measuring relative times, so the 64-bitness > shouldn't really matter. > > Could you please point out what issues exist so they can be fixed. It's not really a bug that needs to be fixed, but more the general issue of referencing inode->i_?time and attr->ia_?time and passing them around. When we change the types in the inode and iattr from timespec to timespec64, all assigments need to be modified, and lustre has more of those assignments than any other file system I'm aware of. Arnd