From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C912C48BE6 for ; Wed, 16 Jun 2021 04:59:46 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 080CF61351 for ; Wed, 16 Jun 2021 04:59:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 080CF61351 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 82C6E8164D; Wed, 16 Jun 2021 06:59:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="QOH9UhT+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DDF3C82927; Wed, 16 Jun 2021 06:59:40 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 078BB80F32 for ; Wed, 16 Jun 2021 06:59:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1623819575; bh=lP6c1wqEcI/XU5kJtBZxpPNLUiJ0TvhvrYiXUhi1y+8=; h=X-UI-Sender-Class:Date:In-Reply-To:References:Subject:To:CC:From; b=QOH9UhT+Q2JQMUuwHh7/cSNutpPznE6a8d6ce0Jxsqd05BI1XSJvUJodolKgG6zLO eWKzQ0VEAm6TYVaVcBirDYwufqwRIrEAGlvF+xM4OQ1twAhUpzlx7Yfq26TeWhj8qL eNMmgV6+wNjkJ32mCjgg/I/FAWNnAtTDqww5IS0U= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [10.137.223.84] ([46.114.111.84]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MNKlu-1led123cOA-00OpGg; Wed, 16 Jun 2021 06:59:34 +0200 Date: Wed, 16 Jun 2021 06:59:33 +0200 User-Agent: K-9 Mail for Android In-Reply-To: <20210615211028.287546-1-icenowy@aosc.io> References: <20210615211028.287546-1-icenowy@aosc.io> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] efi_loader: allow to disable GOP support To: Icenowy Zheng ,Alexander Graf CC: u-boot@lists.denx.de From: Heinrich Schuchardt Message-ID: <65D3D4A3-8E27-4CCE-BDE9-01D5FE7F32EC@gmx.de> X-Provags-ID: V03:K1:PUGe9BFBmeBYUpDqbIWfzVju1QvYTkMOFo9xZB/wQsintqSqquB mz6nZ8NpvUVh72RJBHcRyx8iOgcxe4SPgJkNvCt3sNwUYDf49tJKsf+p1xSYXmQ2YVOI0vh sIu6iTicVvNEeb79xUw22KUleXghmd39uEiY1OfW3V6HB6ffyizUi3zUesi5MEtIXmKicyA eCdGYNBIA8ihqLelwwO+Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:Fehlx9QzDXM=:HwBCTnspp0DPoZPD6WFXbd cLNWg1SFG8QhuIvBXKi/WcMcu+hxO1NF3mK+kBuNyq76074DIm+2xO7AZme4RoPRjPnUbgxUC wAFxnaY4lp3AZr+yF9pKwkmUmXGqX+bJbzNKIci89TjtFtMLdtrfA3feH/4RH8gCxQ/DIlgvp J8bWLtS/ODWicT5zE3cqyuy93eXKwqf7wgTjvjEiF5Rk62AuiNmB3eecupdIYZpNZ2MllEVFv q3RO/16mWBJuI+/vQVQi+wGHFCe/wfnCNycE2S9WoWj25YJ5s1vnU93i19dEgrFHtvUa3QLWD SBHExKA0F1TtdxNmYrO2C1H0LPiejUhCKKDd2C8cp0k5YKCN2Wy5iFZN15DGBnPQPBKd158OI R9VMXn+dhAzB5f4uCBFK3UNIQ6vsDWivuP+GQ1W9EqPUtvfUikDTeM49DtcCbuZUfjI6bdw4M QUJZvOIF3v7UoaN+AHmwhs9TYTkJK2SwDWGtIhdoTlHtPzoB6BIGA746ORIfTrCUn8dnvDVst Gccf1AFqbISZrCoz0ULEt3yQKOZ5yeCbPit0WCpumqZlEeh6s8QbkHpkoiLCG9cbPRPx7HwPz /YJnyUr/6pJgMCVhGHf9m7xGJeay3lLDR7rCAl+pIckwGzFeSc4BvF+5II3yHumVamrxUbprk p+jvURG6s3P5qUjaNd61Fb/ZVrAB8XicOzBLuh6NKRIfRitPYQynvyRrvy7ULpdD2MJdjzfao aaHT8Hv2FB/xQEJlgCV2Aq+yZ7aKjs4a70xxKabNhIln7u2w/Kbgnn+/DBK6iKq1AaIlrpus7 UYv3isD3xcgnrSEpnTtoYhXxZgJ4VZytjgmLDsCauuaDZ/G3+EkY7LsDnp/qXLkDhxOFT4uCa P1cNjniHE87wtGN+zmcSvu9MN8ZqmDWv6Kxo7AcBF8lI9GvvbQzbtfIicnvub1OdqAACmtvbZ z8KMBkBx3ZjxrOormUbqC6hC5EFGCuVzc9IWmrHS5kuWQwRnOVQR0w6Hc78Uo4bkpjF0OQka5 N0Zsq47YVBjnblFGF3Qcds0SXAtDWm4tjTpMq9ciNPNADL6soAMHntMpx5eGEycGQglpm7zGL m3umO72tqPrBwepw+qB04Fh6lBula+2VlER X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Am 15=2E Juni 2021 23:10:28 MESZ schrieb Icenowy Zheng : >Sometimes EFI GOP support may be not wanted (e=2Eg=2E because the operati= ng >system cannot operate well with it) even if video support in U-Boot is >needed=2E Which OS has which problem? Why don't you fix the OS? Best regards Heinrich > >Allow to disable EFI GOP support with a Kconfig option=2E > >Signed-off-by: Icenowy Zheng >--- > lib/efi_loader/Kconfig | 8 ++++++++ > lib/efi_loader/Makefile | 3 +-- > lib/efi_loader/efi_setup=2Ec | 11 ++++++----- > 3 files changed, 15 insertions(+), 7 deletions(-) > >diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig >index 6242caceb7=2E=2E5ba0ce6a44 100644 >--- a/lib/efi_loader/Kconfig >+++ b/lib/efi_loader/Kconfig >@@ -282,6 +282,14 @@ config EFI_HAVE_RUNTIME_RESET > depends on ARCH_BCM283X || FSL_LAYERSCAPE || PSCI_RESET || \ > SANDBOX || SYSRESET_X86 >=20 >+config EFI_GOP_PROTOCOL >+ bool "EFI_GOP_PROTOCOL support" >+ default y >+ depends on DM_VIDEO || LCD >+ help >+ Provide a EFI_GOP_PROTOCOL implementation using the graphics >+ hardware initialized by U-Boot=2E >+ > config EFI_GRUB_ARM32_WORKAROUND > bool "Workaround for GRUB on 32bit ARM" > default n if ARCH_BCM283X || ARCH_SUNXI || ARCH_QEMU >diff --git a/lib/efi_loader/Makefile b/lib/efi_loader/Makefile >index fd344cea29=2E=2E826563d9a7 100644 >--- a/lib/efi_loader/Makefile >+++ b/lib/efi_loader/Makefile >@@ -54,8 +54,7 @@ obj-$(CONFIG_EFI_VARIABLES_PRESEED) +=3D efi_var_seed= =2Eo > endif > obj-y +=3D efi_watchdog=2Eo > obj-$(CONFIG_EFI_ESRT) +=3D efi_esrt=2Eo >-obj-$(CONFIG_LCD) +=3D efi_gop=2Eo >-obj-$(CONFIG_DM_VIDEO) +=3D efi_gop=2Eo >+obj-$(CONFIG_EFI_GOP_PROTOCOL) +=3D efi_gop=2Eo > obj-$(CONFIG_PARTITIONS) +=3D efi_disk=2Eo > obj-$(CONFIG_NET) +=3D efi_net=2Eo > obj-$(CONFIG_GENERATE_ACPI_TABLE) +=3D efi_acpi=2Eo >diff --git a/lib/efi_loader/efi_setup=2Ec b/lib/efi_loader/efi_setup=2Ec >index 3c5cf9a435=2E=2E98deb63777 100644 >--- a/lib/efi_loader/efi_setup=2Ec >+++ b/lib/efi_loader/efi_setup=2Ec >@@ -254,11 +254,12 @@ efi_status_t efi_init_obj_list(void) > if (ret !=3D EFI_SUCCESS) > goto out; >=20 >-#if defined(CONFIG_LCD) || defined(CONFIG_DM_VIDEO) >- ret =3D efi_gop_register(); >- if (ret !=3D EFI_SUCCESS) >- goto out; >-#endif >+ if (IS_ENABLED(CONFIG_EFI_GOP_PROTOCOL)) { >+ ret =3D efi_gop_register(); >+ if (ret !=3D EFI_SUCCESS) >+ goto out; >+ } >+ > #ifdef CONFIG_NET > ret =3D efi_net_register(); > if (ret !=3D EFI_SUCCESS)