Re: [dpdk-dev] [RFC,v2] ethdev: extend RSS offload types

["Su, Simei" <simei.su@intel.com>]

> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Tuesday, July 30, 2019 11:50 PM
> To: Su, Simei <simei.su@intel.com>
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>;
> adrien.mazarguil@6wind.com; dev@dpdk.org
> Subject: Re: [dpdk-dev] [RFC,v2] ethdev: extend RSS offload types
> 
> On Fri, 26 Jul 2019 08:35:50 +0800
> simei <simei.su@intel.com> wrote:
> 
> > From: Simei Su <simei.su@intel.com>
> >
> > This RFC reserves several bits as input set selection from bottom of
> > the 64 bits. The flow type is combined with input set to represent rss
> > types.
> >
> > Correct the input set mask to align with the definition in rte_ethdev.h.
> > for example:
> >     ETH_RSS_IPV4 | ETH_RSS_INSET_L3_SRC: hash on src ip address only
> >     ETH_RSS_IPV4_UDP | ETH_RSS_INSET_L4_DST: hash on src/dst IP and
> > 				            dst UDP port
> >     ETH_RSS_L2_PAYLOAD | ETH_RSS_INSET_L2_DST: hash on dst mac
> address
> >
> > Signed-off-by: Simei Su <simei.su@intel.com>
> 
> NAK to any patch that "reserves" bits for future use.
> 
> Please include the patch as part of a set of patches that actually implements the
> functionality on a device.
 
  Ok. Later, I will add the implementation functionality as a set of patches.