From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Anchal Agarwal <anchalag@amazon.com>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
"Singh, Balbir" <sblbir@amazon.com>,
"Valentin, Eduardo" <eduval@amazon.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Woodhouse, David" <dwmw@amazon.co.uk>,
"vkuznets@redhat.com" <vkuznets@redhat.com>,
"sstabellini@kernel.org" <sstabellini@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"pavel@ucw.cz" <pavel@ucw.cz>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"x86@kernel.org" <x86@kernel.org>,
"roger.pau@citrix.com" <roger.pau@citrix.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"mingo@redhat.com" <mingo@redhat.com>,
"Kamata, Munehisa" <kamatam@amazon.com>,
"bp@alien8.de" <bp@alien8.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"konrad.wilk@oracle.co" <konrad.wilk@oracle.com>,
"len.brown@intel.com" <len.brown@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"fllinden@amaozn.com" <fllinden@amazon.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [RFC PATCH V2 11/11] x86: tsc: avoid system instability in hibernation
Date: Thu, 23 Jan 2020 11:27:15 -0500 [thread overview]
Message-ID: <65ae1560-241e-de68-a68a-ffea071f5cc4@oracle.com> (raw)
In-Reply-To: <20200122200710.GA3071@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com>
On 1/22/20 3:07 PM, Anchal Agarwal wrote:
>> In this case tsc_verify_tsc_adjust(true) this does nothing as
>> feature bit X86_FEATURE_TSC_ADJUST is not available to guest.
Is it not available to your specific guest? Because AFAICT it is
available in general (to HVM/PVH guests).
> 4. Also, the instances do not have InvariantTSC exposed.
If you specify "nomigrate=true" in your configuration file you should
have that feature enabled.
-boris
WARNING: multiple messages have this Message-ID (diff)
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Anchal Agarwal <anchalag@amazon.com>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Kamata, Munehisa" <kamatam@amazon.com>,
Peter Zijlstra <peterz@infradead.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"pavel@ucw.cz" <pavel@ucw.cz>, "hpa@zytor.com" <hpa@zytor.com>,
"sstabellini@kernel.org" <sstabellini@kernel.org>,
"Valentin, Eduardo" <eduval@amazon.com>,
"x86@kernel.org" <x86@kernel.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Singh, Balbir" <sblbir@amazon.com>,
"len.brown@intel.com" <len.brown@intel.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"bp@alien8.de" <bp@alien8.de>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"konrad.wilk@oracle.co" <konrad.wilk@oracle.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"fllinden@amaozn.com" <fllinden@amazon.com>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"vkuznets@redhat.com" <vkuznets@redhat.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"Woodhouse, David" <dwmw@amazon.co.uk>,
"roger.pau@citrix.com" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [RFC PATCH V2 11/11] x86: tsc: avoid system instability in hibernation
Date: Thu, 23 Jan 2020 11:27:15 -0500 [thread overview]
Message-ID: <65ae1560-241e-de68-a68a-ffea071f5cc4@oracle.com> (raw)
In-Reply-To: <20200122200710.GA3071@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com>
On 1/22/20 3:07 PM, Anchal Agarwal wrote:
>> In this case tsc_verify_tsc_adjust(true) this does nothing as
>> feature bit X86_FEATURE_TSC_ADJUST is not available to guest.
Is it not available to your specific guest? Because AFAICT it is
available in general (to HVM/PVH guests).
> 4. Also, the instances do not have InvariantTSC exposed.
If you specify "nomigrate=true" in your configuration file you should
have that feature enabled.
-boris
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-01-23 16:28 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 23:45 [RFC PATCH V2 11/11] x86: tsc: avoid system instability in hibernation Anchal Agarwal
2020-01-07 23:45 ` [Xen-devel] " Anchal Agarwal
2020-01-08 10:50 ` Peter Zijlstra
2020-01-08 10:50 ` [Xen-devel] " Peter Zijlstra
2020-01-10 15:35 ` Eduardo Valentin
2020-01-10 15:35 ` [Xen-devel] " Eduardo Valentin
2020-01-13 10:16 ` Peter Zijlstra
2020-01-13 10:16 ` [Xen-devel] " Peter Zijlstra
2020-01-13 11:43 ` Singh, Balbir
2020-01-13 11:43 ` [Xen-devel] " Singh, Balbir
2020-01-13 11:43 ` Singh, Balbir
2020-01-13 11:48 ` Rafael J. Wysocki
2020-01-13 11:48 ` [Xen-devel] " Rafael J. Wysocki
2020-01-13 11:48 ` Rafael J. Wysocki
2020-01-13 12:42 ` Peter Zijlstra
2020-01-13 12:42 ` [Xen-devel] " Peter Zijlstra
2020-01-13 12:42 ` Peter Zijlstra
2020-01-13 21:50 ` Rafael J. Wysocki
2020-01-13 21:50 ` [Xen-devel] " Rafael J. Wysocki
2020-01-13 21:50 ` Rafael J. Wysocki
2020-01-13 23:30 ` Rafael J. Wysocki
2020-01-13 23:30 ` [Xen-devel] " Rafael J. Wysocki
2020-01-13 23:30 ` Rafael J. Wysocki
2020-01-14 19:29 ` Anchal Agarwal
2020-01-14 19:29 ` [Xen-devel] " Anchal Agarwal
2020-01-22 20:07 ` Anchal Agarwal
2020-01-22 20:07 ` [Xen-devel] " Anchal Agarwal
2020-01-23 16:27 ` Boris Ostrovsky [this message]
2020-01-23 16:27 ` Boris Ostrovsky
2020-01-13 13:01 ` Andrew Cooper
2020-01-13 13:01 ` Andrew Cooper
2020-01-13 13:01 ` Andrew Cooper
2020-01-13 13:54 ` David Woodhouse
2020-01-13 13:54 ` David Woodhouse
2020-01-13 13:54 ` David Woodhouse
2020-01-13 15:02 ` Singh, Balbir
2020-01-13 15:02 ` Singh, Balbir
2020-01-13 15:02 ` Singh, Balbir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65ae1560-241e-de68-a68a-ffea071f5cc4@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=anchalag@amazon.com \
--cc=axboe@kernel.dk \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.co.uk \
--cc=eduval@amazon.com \
--cc=fllinden@amazon.com \
--cc=hpa@zytor.com \
--cc=kamatam@amazon.com \
--cc=konrad.wilk@oracle.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=roger.pau@citrix.com \
--cc=sblbir@amazon.com \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.