All of lore.kernel.org
 help / color / mirror / Atom feed
From: Georgi Djakov <georgi.djakov@linaro.org>
To: "Isaac J. Manjarres" <isaacm@codeaurora.org>,
	iommu@lists.linux-foundation.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, freedreno@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org
Cc: will@kernel.org, joro@8bytes.org, pdaly@codeaurora.org,
	pratikp@codeaurora.org, kernel-team@android.com,
	robin.murphy@arm.com
Subject: Re: [PATCH v2 1/7] iommu/io-pgtable: Introduce dynamic io-pgtable fmt registration
Date: Wed, 23 Dec 2020 17:38:19 +0200	[thread overview]
Message-ID: <65b5382c-c7a9-0f18-96da-fe49e92e3b00@linaro.org> (raw)
In-Reply-To: <1608597876-32367-2-git-send-email-isaacm@codeaurora.org>

Hi Isaac,

On 22.12.20 2:44, Isaac J. Manjarres wrote:
> The io-pgtable code constructs an array of init functions for each
> page table format at compile time. This is not ideal, as this
> increases the footprint of the io-pgtable code, as well as prevents
> io-pgtable formats from being built as kernel modules.
> 
> In preparation for modularizing the io-pgtable formats, switch to a
> dynamic registration scheme, where each io-pgtable format can register
> their init functions with the io-pgtable code at boot or module
> insertion time.
> 
> Signed-off-by: Isaac J. Manjarres <isaacm@codeaurora.org>
> ---
>   drivers/iommu/io-pgtable-arm-v7s.c | 34 +++++++++++++-
>   drivers/iommu/io-pgtable-arm.c     | 90 ++++++++++++++++++++++++++----------
>   drivers/iommu/io-pgtable.c         | 94 ++++++++++++++++++++++++++++++++------
>   include/linux/io-pgtable.h         | 51 +++++++++++++--------
>   4 files changed, 209 insertions(+), 60 deletions(-)
> 
> diff --git a/drivers/iommu/io-pgtable-arm-v7s.c b/drivers/iommu/io-pgtable-arm-v7s.c
> index 1d92ac9..89aad2f 100644
> --- a/drivers/iommu/io-pgtable-arm-v7s.c
> +++ b/drivers/iommu/io-pgtable-arm-v7s.c
> @@ -28,6 +28,7 @@
[..]
> +static int __init arm_lpae_init(void)
> +{
> +	int ret, i;
> +
> +	for (i = 0; i < ARRAY_SIZE(io_pgtable_arm_lpae_init_fns); i++) {
> +		ret = io_pgtable_ops_register(&io_pgtable_arm_lpae_init_fns[i]);
> +		if (ret < 0) {
> +			pr_err("Failed to register ARM LPAE fmt: %d\n");

I guess we want to print the format here?

Thanks,
Georgi

WARNING: multiple messages have this Message-ID
From: Georgi Djakov <georgi.djakov@linaro.org>
To: "Isaac J. Manjarres" <isaacm@codeaurora.org>,
	iommu@lists.linux-foundation.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, freedreno@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org
Cc: will@kernel.org, pdaly@codeaurora.org, kernel-team@android.com,
	robin.murphy@arm.com, pratikp@codeaurora.org
Subject: Re: [PATCH v2 1/7] iommu/io-pgtable: Introduce dynamic io-pgtable fmt registration
Date: Wed, 23 Dec 2020 17:38:19 +0200	[thread overview]
Message-ID: <65b5382c-c7a9-0f18-96da-fe49e92e3b00@linaro.org> (raw)
In-Reply-To: <1608597876-32367-2-git-send-email-isaacm@codeaurora.org>

Hi Isaac,

On 22.12.20 2:44, Isaac J. Manjarres wrote:
> The io-pgtable code constructs an array of init functions for each
> page table format at compile time. This is not ideal, as this
> increases the footprint of the io-pgtable code, as well as prevents
> io-pgtable formats from being built as kernel modules.
> 
> In preparation for modularizing the io-pgtable formats, switch to a
> dynamic registration scheme, where each io-pgtable format can register
> their init functions with the io-pgtable code at boot or module
> insertion time.
> 
> Signed-off-by: Isaac J. Manjarres <isaacm@codeaurora.org>
> ---
>   drivers/iommu/io-pgtable-arm-v7s.c | 34 +++++++++++++-
>   drivers/iommu/io-pgtable-arm.c     | 90 ++++++++++++++++++++++++++----------
>   drivers/iommu/io-pgtable.c         | 94 ++++++++++++++++++++++++++++++++------
>   include/linux/io-pgtable.h         | 51 +++++++++++++--------
>   4 files changed, 209 insertions(+), 60 deletions(-)
> 
> diff --git a/drivers/iommu/io-pgtable-arm-v7s.c b/drivers/iommu/io-pgtable-arm-v7s.c
> index 1d92ac9..89aad2f 100644
> --- a/drivers/iommu/io-pgtable-arm-v7s.c
> +++ b/drivers/iommu/io-pgtable-arm-v7s.c
> @@ -28,6 +28,7 @@
[..]
> +static int __init arm_lpae_init(void)
> +{
> +	int ret, i;
> +
> +	for (i = 0; i < ARRAY_SIZE(io_pgtable_arm_lpae_init_fns); i++) {
> +		ret = io_pgtable_ops_register(&io_pgtable_arm_lpae_init_fns[i]);
> +		if (ret < 0) {
> +			pr_err("Failed to register ARM LPAE fmt: %d\n");

I guess we want to print the format here?

Thanks,
Georgi
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID
From: Georgi Djakov <georgi.djakov@linaro.org>
To: "Isaac J. Manjarres" <isaacm@codeaurora.org>,
	iommu@lists.linux-foundation.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, freedreno@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org
Cc: will@kernel.org, pdaly@codeaurora.org, kernel-team@android.com,
	joro@8bytes.org, robin.murphy@arm.com, pratikp@codeaurora.org
Subject: Re: [PATCH v2 1/7] iommu/io-pgtable: Introduce dynamic io-pgtable fmt registration
Date: Wed, 23 Dec 2020 17:38:19 +0200	[thread overview]
Message-ID: <65b5382c-c7a9-0f18-96da-fe49e92e3b00@linaro.org> (raw)
In-Reply-To: <1608597876-32367-2-git-send-email-isaacm@codeaurora.org>

Hi Isaac,

On 22.12.20 2:44, Isaac J. Manjarres wrote:
> The io-pgtable code constructs an array of init functions for each
> page table format at compile time. This is not ideal, as this
> increases the footprint of the io-pgtable code, as well as prevents
> io-pgtable formats from being built as kernel modules.
> 
> In preparation for modularizing the io-pgtable formats, switch to a
> dynamic registration scheme, where each io-pgtable format can register
> their init functions with the io-pgtable code at boot or module
> insertion time.
> 
> Signed-off-by: Isaac J. Manjarres <isaacm@codeaurora.org>
> ---
>   drivers/iommu/io-pgtable-arm-v7s.c | 34 +++++++++++++-
>   drivers/iommu/io-pgtable-arm.c     | 90 ++++++++++++++++++++++++++----------
>   drivers/iommu/io-pgtable.c         | 94 ++++++++++++++++++++++++++++++++------
>   include/linux/io-pgtable.h         | 51 +++++++++++++--------
>   4 files changed, 209 insertions(+), 60 deletions(-)
> 
> diff --git a/drivers/iommu/io-pgtable-arm-v7s.c b/drivers/iommu/io-pgtable-arm-v7s.c
> index 1d92ac9..89aad2f 100644
> --- a/drivers/iommu/io-pgtable-arm-v7s.c
> +++ b/drivers/iommu/io-pgtable-arm-v7s.c
> @@ -28,6 +28,7 @@
[..]
> +static int __init arm_lpae_init(void)
> +{
> +	int ret, i;
> +
> +	for (i = 0; i < ARRAY_SIZE(io_pgtable_arm_lpae_init_fns); i++) {
> +		ret = io_pgtable_ops_register(&io_pgtable_arm_lpae_init_fns[i]);
> +		if (ret < 0) {
> +			pr_err("Failed to register ARM LPAE fmt: %d\n");

I guess we want to print the format here?

Thanks,
Georgi

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID
From: Georgi Djakov <georgi.djakov@linaro.org>
To: "Isaac J. Manjarres" <isaacm@codeaurora.org>,
	iommu@lists.linux-foundation.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, freedreno@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org
Cc: will@kernel.org, pdaly@codeaurora.org, kernel-team@android.com,
	joro@8bytes.org, robin.murphy@arm.com, pratikp@codeaurora.org
Subject: Re: [PATCH v2 1/7] iommu/io-pgtable: Introduce dynamic io-pgtable fmt registration
Date: Wed, 23 Dec 2020 17:38:19 +0200	[thread overview]
Message-ID: <65b5382c-c7a9-0f18-96da-fe49e92e3b00@linaro.org> (raw)
In-Reply-To: <1608597876-32367-2-git-send-email-isaacm@codeaurora.org>

Hi Isaac,

On 22.12.20 2:44, Isaac J. Manjarres wrote:
> The io-pgtable code constructs an array of init functions for each
> page table format at compile time. This is not ideal, as this
> increases the footprint of the io-pgtable code, as well as prevents
> io-pgtable formats from being built as kernel modules.
> 
> In preparation for modularizing the io-pgtable formats, switch to a
> dynamic registration scheme, where each io-pgtable format can register
> their init functions with the io-pgtable code at boot or module
> insertion time.
> 
> Signed-off-by: Isaac J. Manjarres <isaacm@codeaurora.org>
> ---
>   drivers/iommu/io-pgtable-arm-v7s.c | 34 +++++++++++++-
>   drivers/iommu/io-pgtable-arm.c     | 90 ++++++++++++++++++++++++++----------
>   drivers/iommu/io-pgtable.c         | 94 ++++++++++++++++++++++++++++++++------
>   include/linux/io-pgtable.h         | 51 +++++++++++++--------
>   4 files changed, 209 insertions(+), 60 deletions(-)
> 
> diff --git a/drivers/iommu/io-pgtable-arm-v7s.c b/drivers/iommu/io-pgtable-arm-v7s.c
> index 1d92ac9..89aad2f 100644
> --- a/drivers/iommu/io-pgtable-arm-v7s.c
> +++ b/drivers/iommu/io-pgtable-arm-v7s.c
> @@ -28,6 +28,7 @@
[..]
> +static int __init arm_lpae_init(void)
> +{
> +	int ret, i;
> +
> +	for (i = 0; i < ARRAY_SIZE(io_pgtable_arm_lpae_init_fns); i++) {
> +		ret = io_pgtable_ops_register(&io_pgtable_arm_lpae_init_fns[i]);
> +		if (ret < 0) {
> +			pr_err("Failed to register ARM LPAE fmt: %d\n");

I guess we want to print the format here?

Thanks,
Georgi
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-12-23 15:39 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-22  0:44 [RFC PATCH v2 0/7] iommu: Permit modular builds of io-pgtable drivers Isaac J. Manjarres
2020-12-22  0:44 ` Isaac J. Manjarres
2020-12-22  0:44 ` Isaac J. Manjarres
2020-12-22  0:44 ` [PATCH v2 1/7] iommu/io-pgtable: Introduce dynamic io-pgtable fmt registration Isaac J. Manjarres
2020-12-22  0:44   ` Isaac J. Manjarres
2020-12-22  0:44   ` Isaac J. Manjarres
2020-12-22 19:27   ` Robin Murphy
2020-12-22 19:27     ` Robin Murphy
2020-12-22 19:27     ` Robin Murphy
2020-12-22 19:27     ` Robin Murphy
2020-12-22 19:54     ` isaacm
2020-12-22 19:54       ` isaacm
2020-12-22 19:54       ` isaacm
2020-12-23 13:44       ` Robin Murphy
2020-12-23 13:44         ` Robin Murphy
2020-12-23 13:44         ` Robin Murphy
2020-12-23 13:44         ` Robin Murphy
2020-12-23 15:14         ` isaacm
2020-12-23 15:14           ` isaacm
2020-12-23 15:14           ` isaacm
2020-12-23 15:38   ` Georgi Djakov [this message]
2020-12-23 15:38     ` Georgi Djakov
2020-12-23 15:38     ` Georgi Djakov
2020-12-23 15:38     ` Georgi Djakov
2020-12-23 19:17   ` kernel test robot
2020-12-23 19:17     ` kernel test robot
2020-12-23 19:17     ` kernel test robot
2020-12-23 19:17     ` kernel test robot
2020-12-22  0:44 ` [PATCH v2 2/7] iommu/io-pgtable: Add refcounting for io-pgtable format modules Isaac J. Manjarres
2020-12-22  0:44   ` Isaac J. Manjarres
2020-12-22  0:44   ` Isaac J. Manjarres
2020-12-22  0:44 ` [PATCH v2 3/7] iommu/arm-smmu: Add dependency on " Isaac J. Manjarres
2020-12-22  0:44   ` Isaac J. Manjarres
2020-12-22  0:44   ` Isaac J. Manjarres
2020-12-22 19:27   ` Robin Murphy
2020-12-22 19:27     ` Robin Murphy
2020-12-22 19:27     ` Robin Murphy
2020-12-22 19:27     ` Robin Murphy
2020-12-22 19:49     ` isaacm
2020-12-22 19:49       ` isaacm
2020-12-22 19:49       ` isaacm
2020-12-23 13:05       ` Robin Murphy
2020-12-23 13:05         ` Robin Murphy
2020-12-23 13:05         ` Robin Murphy
2020-12-23 13:05         ` Robin Murphy
2020-12-23 15:10         ` isaacm
2020-12-23 15:10           ` isaacm
2020-12-23 15:10           ` isaacm
2020-12-22  0:44 ` [PATCH v2 4/7] iommu/arm-smmu-v3: Add dependency on io-pgtable-arm format module Isaac J. Manjarres
2020-12-22  0:44   ` Isaac J. Manjarres
2020-12-22  0:44   ` Isaac J. Manjarres
2020-12-22  0:44 ` [PATCH v2 5/7] drm/msm: " Isaac J. Manjarres
2020-12-22  0:44   ` Isaac J. Manjarres
2020-12-22  0:44   ` Isaac J. Manjarres
2021-01-18 21:16   ` Rob Clark
2021-01-18 21:16     ` Rob Clark
2021-01-18 21:16     ` Rob Clark
2021-01-18 21:16     ` Rob Clark
2021-01-18 21:39     ` Will Deacon
2021-01-18 21:39       ` Will Deacon
2021-01-18 21:39       ` Will Deacon
2021-01-18 21:39       ` Will Deacon
2021-01-19 17:19       ` Rob Clark
2021-01-19 17:19         ` Rob Clark
2021-01-19 17:19         ` Rob Clark
2021-01-19 17:19         ` Rob Clark
2020-12-22  0:44 ` [PATCH v2 6/7] drm/panfrost: " Isaac J. Manjarres
2020-12-22  0:44   ` Isaac J. Manjarres
2020-12-22  0:44   ` Isaac J. Manjarres
2020-12-22  0:44 ` [PATCH v2 7/7] iommu/io-pgtable-arm: Allow building modular io-pgtable fmts Isaac J. Manjarres
2020-12-22  0:44   ` Isaac J. Manjarres
2020-12-22  0:44   ` Isaac J. Manjarres

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65b5382c-c7a9-0f18-96da-fe49e92e3b00@linaro.org \
    --to=georgi.djakov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=isaacm@codeaurora.org \
    --cc=joro@8bytes.org \
    --cc=kernel-team@android.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pdaly@codeaurora.org \
    --cc=pratikp@codeaurora.org \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    --subject='Re: [PATCH v2 1/7] iommu/io-pgtable: Introduce dynamic io-pgtable fmt registration' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.