From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752424AbeFDKMS (ORCPT ); Mon, 4 Jun 2018 06:12:18 -0400 Received: from mga09.intel.com ([134.134.136.24]:8104 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752315AbeFDKMP (ORCPT ); Mon, 4 Jun 2018 06:12:15 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,476,1520924400"; d="scan'208";a="234187004" Message-ID: <65c26f5db1275e958cfe6390e9336568b0158dea.camel@linux.intel.com> Subject: Re: [PATCH 0/8] serial: 8250: Add 485 emulation to 8250_dw. From: Andy Shevchenko To: Giulio Benetti , Greg Kroah-Hartman , "Matwey V.Kornilov" Cc: Jiri Slaby , Kees Cook , Matthias Brugger , Allen Pais , Sean Young , Ed Blake , Stefan Potyra , Philipp Zabel , Joshua Scott , Vignesh R , Rolf Evers-Fischer , Aaron Sierra , Rafael Gago , Joel Stanley , Sean Wang , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 04 Jun 2018 13:12:07 +0300 In-Reply-To: <20180601124021.102970-1-giulio.benetti@micronovasrl.com> References: <20180601124021.102970-1-giulio.benetti@micronovasrl.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.1-2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2018-06-01 at 14:40 +0200, Giulio Benetti wrote: > Need to handle rs485 with 8250_dw port. > > Use existing em485 emulation layer for 8250 taking care to fix some > bug > and taking care especially of RTS_AFTER_SEND case. > I don't see in Cc list author of rs485 code, who might be interested in this. So, added him here. > Giulio Benetti (8): > serial: 8250_dw: add em485 support > serial: 8250_dw: allow enable rs485 at boot time > serial: 8250: Copy em485 from port to real port. > serial: 8250: Handle case port doesn't have TEMT interrupt using > em485. > serial: 8250_dw: treat rpm suspend with -EBUSY if RS485 ON and > RTS_AFTER_SEND > serial: 8250: Copy mctrl when register port. > serial: 8250: Make em485_rts_after_send() set mctrl according to rts > state. > serial: core: Mask mctrl with TIOCM_RTS too if rs485 on and > RTS_AFTER_SEND set. > > drivers/tty/serial/8250/8250.h | 2 +- > drivers/tty/serial/8250/8250_core.c | 2 ++ > drivers/tty/serial/8250/8250_dw.c | 41 > ++++++++++++++++++++++++++++- > drivers/tty/serial/8250/8250_omap.c | 2 +- > drivers/tty/serial/8250/8250_port.c | 33 ++++++++++++++++------- > drivers/tty/serial/serial_core.c | 12 ++++++++- > include/linux/serial_8250.h | 1 + > 7 files changed, 79 insertions(+), 14 deletions(-) > -- Andy Shevchenko Intel Finland Oy