From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AD1DC352A3 for ; Fri, 7 Feb 2020 12:58:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 36D36217BA for ; Fri, 7 Feb 2020 12:58:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727005AbgBGM6m (ORCPT ); Fri, 7 Feb 2020 07:58:42 -0500 Received: from smtprelay0073.hostedemail.com ([216.40.44.73]:39613 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726860AbgBGM6m (ORCPT ); Fri, 7 Feb 2020 07:58:42 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 9BCF4182CF66A; Fri, 7 Feb 2020 12:58:40 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: offer22_2e74bd6f96125 X-Filterd-Recvd-Size: 3248 Received: from XPS-9350.home (unknown [47.151.143.254]) (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA; Fri, 7 Feb 2020 12:58:39 +0000 (UTC) Message-ID: <65c84256f27fd0231176ed726ef2cd95a644147b.camel@perches.com> Subject: Re: Checkpatch being daft, Was: [PATCH -v2 08/10] m68k,mm: Extend table allocator for multiple sizes From: Joe Perches To: Peter Zijlstra , Geert Uytterhoeven Cc: linux-m68k , Linux Kernel Mailing List , Will Deacon , Michael Schmitz , Greg Ungerer , sean.j.christopherson@intel.com Date: Fri, 07 Feb 2020 04:57:26 -0800 In-Reply-To: <20200207123035.GI14914@hirez.programming.kicks-ass.net> References: <20200131124531.623136425@infradead.org> <20200131125403.882175409@infradead.org> <20200207113417.GG14914@hirez.programming.kicks-ass.net> <20200207123035.GI14914@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2020-02-07 at 13:30 +0100, Peter Zijlstra wrote: > On Fri, Feb 07, 2020 at 01:11:54PM +0100, Geert Uytterhoeven wrote: > > On Fri, Feb 7, 2020 at 12:34 PM Peter Zijlstra wrote: > > > On Fri, Feb 07, 2020 at 11:56:40AM +0100, Geert Uytterhoeven wrote: > > > > WARNING: Missing Signed-off-by: line by nominal patch author 'Peter > > > > Zijlstra ' > > > > (in all patches) > > > > > > > > I can fix that (the From?) up while applying. > > > > > > I'm not sure where that warning comes from, but if you feel it needs > > > fixing, sure. I normally only add the (Intel) thing to the SoB. I've so > > > far never had complaints about that. > > > > Checkpatch doesn't like this. > > Ooh, I see, that's a relatively new warning, pretty daft if you ask me. > > Now I have to rediscover how I went about teaching checkpatch to STFU ;-) > > Joe, should that '$email eq $author' not ignore rfc822 comments? That > is: > > Peter Zijlstra > > and: > > Peter Zijlstra (Intel) > > are, in actual fact, the same. checkpatch doesn't really have an rfc822 parser and would likely require some fairly involved changes to use one. For instance: adding --- scripts/checkpatch.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index f3b8434..959b8ef 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1164,6 +1164,7 @@ sub parse_email { $name = trim($name); $name =~ s/^\"|\"$//g; + $name =~ s/\s*\([^\)]+\)\s*//; $address = trim($address); $address =~ s/^\<|\>$//g; --- Into the parse_email function to strip rfc822 comments from email addresses would just create a couple different warnings. For now, how about adding --ignore=NO_AUTHOR_SIGN_OFF