From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11B3CC433ED for ; Wed, 28 Apr 2021 11:37:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCCFC6141E for ; Wed, 28 Apr 2021 11:37:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239366AbhD1LiA (ORCPT ); Wed, 28 Apr 2021 07:38:00 -0400 Received: from first.geanix.com ([116.203.34.67]:38050 "EHLO first.geanix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234158AbhD1LiA (ORCPT ); Wed, 28 Apr 2021 07:38:00 -0400 Received: from [192.168.64.189] (unknown [185.17.218.86]) by first.geanix.com (Postfix) with ESMTPSA id 3CF7B4661E5; Wed, 28 Apr 2021 11:37:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=geanix.com; s=first; t=1619609833; bh=cJNNPY3OXkJ4ZqpUBnyX7/E7d3vUz7Wmr4y6JSvleG8=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=C2K8dg19zdapAoSgRnbXbnwpMavkswJvsO1k9RragI8B99zvlmb73BpS9EFCQOGe3 bvEXl7MBECSaJK3V+mTmtWKJQGSVGy5pDymjhdZi3h8eiBSu7hkibdwVSN7MEP256n nbSxAo029Vc2kNBRnABIV5VnGyj998t1sBVmxgelWzc/f9yGg16npw9mcejhcPtoiC h3c+SdWK/DPCiE2YVpQjHBneUM0aYZKOU2+GNZuBkEJQlmWoynULclbt5m8/bc52WT 5nFddBpABRLLuV2bfID/mm/MB840Y+vOoMprLXvAORaKxo4EmWX2v9KOt6dfKUPS0H iBw5w42vR4zug== Subject: Re: [RFC PATCH 4/4] iio: accel: fxls8962af: fix errata bug E3 - I2C burst reads To: Andy Shevchenko Cc: Jonathan Cameron , linux-iio , Lars-Peter Clausen , =?UTF-8?Q?Nuno_S=c3=a1?= , Rob Herring , devicetree References: <20210428082203.3587022-1-sean@geanix.com> <20210428082203.3587022-4-sean@geanix.com> From: Sean Nyekjaer Message-ID: <65d00eec-6787-b9f5-c954-bbf1eac47050@geanix.com> Date: Wed, 28 Apr 2021 13:37:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/04/2021 13.24, Andy Shevchenko wrote: > This should be part of that series. OK, will include next week... > > Besides, see below. > > ... > >> + bool i2c_device; >> + data->i2c_device = i2c_device; > This is redundant. Use i2c_verify_client() instead. Thanks I've been looking for a that functionality :) /Sean