All of lore.kernel.org
 help / color / mirror / Atom feed
From: Glenn Washburn <development@efficientek.com>
To: grub-devel@gnu.org, Daniel Kiper <dkiper@net-space.pl>
Cc: Peter Jones <pjones@redhat.com>,
	Robbie Harwood <rharwood@redhat.com>,
	Glenn Washburn <development@efficientek.com>
Subject: [PATCH v2 03/15] gdb: If no modules have been loaded, do not try to load module symbols
Date: Fri, 13 May 2022 18:12:36 -0500	[thread overview]
Message-ID: <65d35d5c4df01295712bb9845c2086ca6c6118c6.1652482822.git.development@efficientek.com> (raw)
In-Reply-To: <cover.1652482822.git.development@efficientek.com>

This prevents load_all_modules from failing when called before any
modules have been loaded. Failures in GDB user-defined functions cause
any function which called them to also fail.

Signed-off-by: Glenn Washburn <development@efficientek.com>
---
 grub-core/gdb_grub.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/grub-core/gdb_grub.in b/grub-core/gdb_grub.in
index 083731408..77491816f 100644
--- a/grub-core/gdb_grub.in
+++ b/grub-core/gdb_grub.in
@@ -62,7 +62,9 @@ define load_all_modules
 		dump_module_sections $this
 		set $this = $this->next
 	end
-	match_and_load_symbols
+	if (grub_dl_head != 0)
+		match_and_load_symbols
+	end
 end
 document load_all_modules
 	Load debugging information for all loaded modules.
-- 
2.34.1



  parent reply	other threads:[~2022-05-13 23:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-13 23:12 [PATCH v2 00/15] GDB script fixes and improvements Glenn Washburn
2022-05-13 23:12 ` [PATCH v2 01/15] gdb: Fix redirection issue in dump_module_sections Glenn Washburn
2022-05-13 23:12 ` [PATCH v2 02/15] gdb: Prevent wrapping when writing to .segments.tmp Glenn Washburn
2022-05-13 23:12 ` Glenn Washburn [this message]
2022-05-13 23:12 ` [PATCH v2 04/15] gdb: Move runtime module loading into runtime_load_module Glenn Washburn
2022-05-13 23:12 ` [PATCH v2 05/15] gdb: Get correct mod variable value Glenn Washburn
2022-05-13 23:12 ` [PATCH v2 06/15] gdb: Do not run load_module if module has already been loaded Glenn Washburn
2022-05-13 23:12 ` [PATCH v2 07/15] gdb: Add functions to make loading from dynamically positioned targets easier Glenn Washburn
2022-05-13 23:12 ` [PATCH v2 08/15] gdb: Remove Perl dependency for GRUB GDB script Glenn Washburn
2022-05-13 23:12 ` [PATCH v2 09/15] gdb: If enabled, print line used to load EFI kernel symbols when using gdb_grub script Glenn Washburn
2022-05-13 23:12 ` [PATCH v2 10/15] gdb: Conditionally run GDB script logic for dynamically or statically positioned GRUB Glenn Washburn
2022-05-13 23:12 ` [PATCH v2 11/15] gdb: Only connect to remote target once when first sourced Glenn Washburn
2022-05-13 23:12 ` [PATCH v2 12/15] gdb: Allow user defined "onload_<modname>" command to be run when module is loaded Glenn Washburn
2022-05-13 23:12 ` [PATCH v2 13/15] gdb: Allow running user-defined commands at GRUB start Glenn Washburn
2022-05-13 23:12 ` [PATCH v2 14/15] gdb: Add ability to turn on shell tracing for gdb helper script Glenn Washburn
2022-05-13 23:12 ` [PATCH v2 15/15] docs: Add debugging chapter to development documentation Glenn Washburn
2022-07-05 11:16 ` [PATCH v2 00/15] GDB script fixes and improvements Daniel Kiper
2022-07-08  4:42   ` Glenn Washburn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65d35d5c4df01295712bb9845c2086ca6c6118c6.1652482822.git.development@efficientek.com \
    --to=development@efficientek.com \
    --cc=dkiper@net-space.pl \
    --cc=grub-devel@gnu.org \
    --cc=pjones@redhat.com \
    --cc=rharwood@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.