From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D8F0C433EF for ; Sun, 26 Jun 2022 02:39:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233692AbiFZCjv (ORCPT ); Sat, 25 Jun 2022 22:39:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232327AbiFZCjv (ORCPT ); Sat, 25 Jun 2022 22:39:51 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7605712AC0; Sat, 25 Jun 2022 19:39:49 -0700 (PDT) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4LVw6Q2fbjzDsC8; Sun, 26 Jun 2022 10:39:10 +0800 (CST) Received: from kwepemm600009.china.huawei.com (7.193.23.164) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sun, 26 Jun 2022 10:39:47 +0800 Received: from [10.174.176.73] (10.174.176.73) by kwepemm600009.china.huawei.com (7.193.23.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sun, 26 Jun 2022 10:39:46 +0800 Subject: Re: [PATCH -next v5 4/8] blk-throttle: fix io hung due to config updates To: Jens Axboe , =?UTF-8?Q?Michal_Koutn=c3=bd?= , CC: , , , , References: <20220528064330.3471000-1-yukuai3@huawei.com> <20220528064330.3471000-5-yukuai3@huawei.com> <20220622172621.GA28246@blackbody.suse.cz> <20220623162620.GB16004@blackbody.suse.cz> <75b3cdcc-1aa3-7259-4900-f09a2a081716@huawei.com> <7e14a11b-225e-13c4-35ff-762eafd20b70@kernel.dk> From: Yu Kuai Message-ID: <65dac189-92f5-f2bc-b322-cbda10f897b4@huawei.com> Date: Sun, 26 Jun 2022 10:39:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <7e14a11b-225e-13c4-35ff-762eafd20b70@kernel.dk> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.176.73] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600009.china.huawei.com (7.193.23.164) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org 在 2022/06/26 0:41, Jens Axboe 写道: > On 6/25/22 2:36 AM, Yu Kuai wrote: >> ? 2022/06/24 0:26, Michal Koutn? ??: >>> On Thu, Jun 23, 2022 at 08:27:11PM +0800, Yu Kuai wrote: >>>>> Here we may allow to dispatch a bio above current slice's >>>>> calculate_bytes_allowed() if bytes_skipped is already >0. >>>> >>>> Hi, I don't expect that to happen. For example, if a bio is still >>>> throttled, then old slice is keeped with proper 'bytes_skipped', >>>> then new wait time is caculated based on (bio_size - bytes_skipped). >>>> >>>> After the bio is dispatched(I assum that other bios can't preempt), >>> >>> With this assumptions it adds up as you write. I believe we're in >>> agreement. >>> >>> It's the same assumption I made below (FIFO everywhere, i.e. no >>> reordering). So the discussed difference shouldn't really be negative >>> (and if the assumption didn't hold, so the modular arithmetic yields >>> corerct bytes_skipped value). >> Yes, nice that we're in aggreement. >> >> I'll wait to see if Tejun has any suggestions. > > I flushed more emails from spam again. Please stop using the buggy > huawei address until this gets resolved, your patches are getting lost > left and right and I don't have time to go hunting for emails. > My apologize for that, I'm quite annoied that our IT still can't solve this. I'll stop sending new emails with this address for now.. Thanks, Kuai From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yu Kuai Subject: Re: [PATCH -next v5 4/8] blk-throttle: fix io hung due to config updates Date: Sun, 26 Jun 2022 10:39:45 +0800 Message-ID: <65dac189-92f5-f2bc-b322-cbda10f897b4@huawei.com> References: <20220528064330.3471000-1-yukuai3@huawei.com> <20220528064330.3471000-5-yukuai3@huawei.com> <20220622172621.GA28246@blackbody.suse.cz> <20220623162620.GB16004@blackbody.suse.cz> <75b3cdcc-1aa3-7259-4900-f09a2a081716@huawei.com> <7e14a11b-225e-13c4-35ff-762eafd20b70@kernel.dk> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <7e14a11b-225e-13c4-35ff-762eafd20b70@kernel.dk> List-ID: Content-Type: text/plain; charset="utf-8"; format="flowed" To: Jens Axboe , =?UTF-8?Q?Michal_Koutn=c3=bd?= , tj@kernel.org Cc: ming.lei@redhat.com, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com 在 2022/06/26 0:41, Jens Axboe 写道: > On 6/25/22 2:36 AM, Yu Kuai wrote: >> ? 2022/06/24 0:26, Michal Koutn? ??: >>> On Thu, Jun 23, 2022 at 08:27:11PM +0800, Yu Kuai wrote: >>>>> Here we may allow to dispatch a bio above current slice's >>>>> calculate_bytes_allowed() if bytes_skipped is already >0. >>>> >>>> Hi, I don't expect that to happen. For example, if a bio is still >>>> throttled, then old slice is keeped with proper 'bytes_skipped', >>>> then new wait time is caculated based on (bio_size - bytes_skipped). >>>> >>>> After the bio is dispatched(I assum that other bios can't preempt), >>> >>> With this assumptions it adds up as you write. I believe we're in >>> agreement. >>> >>> It's the same assumption I made below (FIFO everywhere, i.e. no >>> reordering). So the discussed difference shouldn't really be negative >>> (and if the assumption didn't hold, so the modular arithmetic yields >>> corerct bytes_skipped value). >> Yes, nice that we're in aggreement. >> >> I'll wait to see if Tejun has any suggestions. > > I flushed more emails from spam again. Please stop using the buggy > huawei address until this gets resolved, your patches are getting lost > left and right and I don't have time to go hunting for emails. > My apologize for that, I'm quite annoied that our IT still can't solve this. I'll stop sending new emails with this address for now.. Thanks, Kuai