From: "Tomáš Golembiovský" <tgolembi@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Michael Roth" <mdroth@linux.vnet.ibm.com>,
"Tomáš Golembiovský" <tgolembi@redhat.com>
Subject: [Qemu-devel] [PATCH v2 1/4] build: rename CONFIG_QGA_NTDDDISK to CONFIG_QGA_NTDDSCSI
Date: Tue, 7 Aug 2018 12:51:35 +0200 [thread overview]
Message-ID: <65e1a15b5c2bb532a26a4fe908c67f4c9ea5f138.1533639095.git.tgolembi@redhat.com> (raw)
In-Reply-To: <cover.1533639095.git.tgolembi@redhat.com>
There was inconsistency between commits:
50cbebb9a3 configure: add configure check for ntdddisk.h
a3ef3b2272 qga: added bus type and disk location path
The first commit added #define CONFIG_QGA_NTDDDISK but the second commit
expected the name to be CONFIG_QGA_NTDDSCSI. As a result the code in
second patch was never used.
Renaming the option to CONFIG_QGA_NTDDSCSI to match the name of header
file that is being checked for.
Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 2a7796ea80..b31f37ed50 100755
--- a/configure
+++ b/configure
@@ -6111,7 +6111,7 @@ if test "$mingw32" = "yes" ; then
echo "WIN_SDK=\"$win_sdk\"" >> $config_host_mak
fi
if test "$guest_agent_ntddscsi" = "yes" ; then
- echo "CONFIG_QGA_NTDDDISK=y" >> $config_host_mak
+ echo "CONFIG_QGA_NTDDSCSI=y" >> $config_host_mak
fi
if test "$guest_agent_msi" = "yes"; then
echo "QEMU_GA_MSI_ENABLED=yes" >> $config_host_mak
--
2.18.0
next prev parent reply other threads:[~2018-08-07 10:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 10:51 [Qemu-devel] [PATCH v2 0/4] qga: report serial number and disk node Tomáš Golembiovský
2018-08-07 10:51 ` Tomáš Golembiovský [this message]
2018-08-07 10:51 ` [Qemu-devel] [PATCH v2 2/4] qga: win32: add debugging information Tomáš Golembiovský
2018-08-07 10:51 ` [Qemu-devel] [PATCH v2 3/4] qga: win32: fix crashes when PCI info cannot be retrived Tomáš Golembiovský
2018-09-05 23:21 ` Michael Roth
2018-09-07 11:24 ` Tomáš Golembiovský
2018-08-07 10:51 ` [Qemu-devel] [PATCH v2 4/4] qga: report serial ID and device node Tomáš Golembiovský
2018-08-07 13:52 ` Eric Blake
2018-08-09 11:50 ` Tomáš Golembiovský
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65e1a15b5c2bb532a26a4fe908c67f4c9ea5f138.1533639095.git.tgolembi@redhat.com \
--to=tgolembi@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.