From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5237C433B4 for ; Sun, 9 May 2021 17:04:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4A84613C5 for ; Sun, 9 May 2021 17:04:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229956AbhEIRFq (ORCPT ); Sun, 9 May 2021 13:05:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:29154 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229924AbhEIRFn (ORCPT ); Sun, 9 May 2021 13:05:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620579879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gS221mF5itctneFLHEBt6dN2sStEXBf4HlghBIHalXQ=; b=Klo7aRUn90HST8as5YuFq55GNW3oH5p3JNGPNUT1kCyv2SZNPcUt1dT8STnwt0TAKThP8q +ru4fws8UN5YWbOEl+tjVqL9KtKVQbz5sQ/Q8Z6l0sz1sO68xSH3KZ8ygm1YTLrh2kZOxu o+Sjs3ihDBUGY8mw48MRDqmQaqOt/DA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-591-NKNK1PMkMt-tlAQTihZAUg-1; Sun, 09 May 2021 13:04:36 -0400 X-MC-Unique: NKNK1PMkMt-tlAQTihZAUg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9A58B18397A6; Sun, 9 May 2021 17:04:34 +0000 (UTC) Received: from [10.36.113.168] (ovpn-113-168.ams2.redhat.com [10.36.113.168]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DAF1169FCE; Sun, 9 May 2021 17:04:24 +0000 (UTC) Subject: Re: [PATCH] Revert "irqbypass: do not start cons/prod when failed connect" To: Marc Zyngier , Zhu Lingshan Cc: jasowang@redhat.com, mst@redhat.com, alex.williamson@redhat.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, cohuck@redhat.com, stable@vger.kernel.org, Shaokun Zhang References: <20210508071152.722425-1-lingshan.zhu@intel.com> <8735uxvajh.wl-maz@kernel.org> From: Auger Eric Message-ID: <65e48458-f94c-e5fd-03d5-93d6acfb356c@redhat.com> Date: Sun, 9 May 2021 19:04:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <8735uxvajh.wl-maz@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi, On 5/8/21 11:29 AM, Marc Zyngier wrote: > On Sat, 08 May 2021 08:11:52 +0100, > Zhu Lingshan wrote: >> >> This reverts commit a979a6aa009f3c99689432e0cdb5402a4463fb88. >> >> The reverted commit may cause VM freeze on arm64 platform. >> Because on arm64 platform, stop a consumer will suspend the VM, >> the VM will freeze without a start consumer > > It also unconditionally calls del_consumer on the producer, which > isn't exactly expected. > >> >> Signed-off-by: Zhu Lingshan > > Reported-by: Shaokun Zhang Reviewed-by: Eric Auger Thanks Eric > Suggested-by: Marc Zyngier > Acked-by: Marc Zyngier > Fixes: a979a6aa009f ("irqbypass: do not start cons/prod when failed connect") > Link: https://lore.kernel.org/r/3a2c66d6-6ca0-8478-d24b-61e8e3241b20@hisilicon.com > Cc: stable@vger.kernel.org > > Thanks, > > M. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 835B3C433ED for ; Sun, 9 May 2021 17:04:42 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id D4FE7613B6 for ; Sun, 9 May 2021 17:04:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4FE7613B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4F9F44B2B4; Sun, 9 May 2021 13:04:41 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qy-ecB6YD1Mq; Sun, 9 May 2021 13:04:40 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 6DE574B815; Sun, 9 May 2021 13:04:40 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 0F4774B4D3 for ; Sun, 9 May 2021 13:04:39 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xM4sFo-56CG6 for ; Sun, 9 May 2021 13:04:38 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 190924B4CB for ; Sun, 9 May 2021 13:04:38 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620579877; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gS221mF5itctneFLHEBt6dN2sStEXBf4HlghBIHalXQ=; b=QVxhoh4BCi/g0FZ8LYBFSQshkIJo+qTIylhd6aENrQootgCXqyIh+1/X0E7x8i8i5qF38R QSZ/g/a7DhF/3uy2G3CLWuDx4723mIPnBaQurDpg5tS9MAnZrywbP2XfJU5EHdla/KlUG4 Ms29MZCb90/hV+PCH5HThFSubo69504= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-591-NKNK1PMkMt-tlAQTihZAUg-1; Sun, 09 May 2021 13:04:36 -0400 X-MC-Unique: NKNK1PMkMt-tlAQTihZAUg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9A58B18397A6; Sun, 9 May 2021 17:04:34 +0000 (UTC) Received: from [10.36.113.168] (ovpn-113-168.ams2.redhat.com [10.36.113.168]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DAF1169FCE; Sun, 9 May 2021 17:04:24 +0000 (UTC) Subject: Re: [PATCH] Revert "irqbypass: do not start cons/prod when failed connect" To: Marc Zyngier , Zhu Lingshan References: <20210508071152.722425-1-lingshan.zhu@intel.com> <8735uxvajh.wl-maz@kernel.org> From: Auger Eric Message-ID: <65e48458-f94c-e5fd-03d5-93d6acfb356c@redhat.com> Date: Sun, 9 May 2021 19:04:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <8735uxvajh.wl-maz@kernel.org> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Cc: kvm@vger.kernel.org, mst@redhat.com, jasowang@redhat.com, cohuck@redhat.com, stable@vger.kernel.org, Shaokun Zhang , alex.williamson@redhat.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi, On 5/8/21 11:29 AM, Marc Zyngier wrote: > On Sat, 08 May 2021 08:11:52 +0100, > Zhu Lingshan wrote: >> >> This reverts commit a979a6aa009f3c99689432e0cdb5402a4463fb88. >> >> The reverted commit may cause VM freeze on arm64 platform. >> Because on arm64 platform, stop a consumer will suspend the VM, >> the VM will freeze without a start consumer > > It also unconditionally calls del_consumer on the producer, which > isn't exactly expected. > >> >> Signed-off-by: Zhu Lingshan > > Reported-by: Shaokun Zhang Reviewed-by: Eric Auger Thanks Eric > Suggested-by: Marc Zyngier > Acked-by: Marc Zyngier > Fixes: a979a6aa009f ("irqbypass: do not start cons/prod when failed connect") > Link: https://lore.kernel.org/r/3a2c66d6-6ca0-8478-d24b-61e8e3241b20@hisilicon.com > Cc: stable@vger.kernel.org > > Thanks, > > M. > _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 934D7C433ED for ; Sun, 9 May 2021 17:06:19 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 128686128E for ; Sun, 9 May 2021 17:06:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 128686128E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KmVjnkR9PiwJiSQmO5zK2yAN9LMSATOM3WS/6XrF5AE=; b=ehUAI3+4cG1E0xFYkL91SMqE7 NvXap6qJc/8NsfL9SESn3E9OCKzZLG708U5sRkQ4cXjabND6FZd6sSLBADb5mNcK7FgW/VOVfklkO lmx46MHl4vFPBG3g1H63z7NBcYYP6xiry2gx2l8AQzW6np1/au1PF3x3NuqTA9oeCsSFEREPF4MpS qLdK/kT6VsK6FPiqIiC0jthHjdY7XK2md0AusgveZsHte2IsVpWMJC0rxLJ2eMEN+1F+I/yA9n+wH eXnJCTT728wR47dJ5eXaaYTTPD7PwaVSHBpI+3d6Wu54ns4xq62/rWlz3WWsh4UVjMv4rNwc6wb0r BTLAy8iXg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lfmrF-00By2D-7m; Sun, 09 May 2021 17:04:45 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lfmrB-00By1f-S0 for linux-arm-kernel@desiato.infradead.org; Sun, 09 May 2021 17:04:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=gS221mF5itctneFLHEBt6dN2sStEXBf4HlghBIHalXQ=; b=3+9ZiGGd2iP0Tqdz5ZL1LYkvkP AYb7wL/AtcS5S5wSFU66g7gkwJrfMyQPo+JWUt2pJa8xOhFuEu0/5z2FTqhs4CrganJzU/XZNlG6n FZ6v9OKP5DkYkJH8Ms9FzvlFdlxhjJ/Vx23qncnqQjAvgxHo6w9RzxF9d0+eVsNSe8LitsdPg9wpb KFHNKY8gDk4xv401K/ticQE3XlcDCp+82XrxG9EJ9CjN46IqcnEo9SoSEkOq8isfTRBnZQsvhCHV6 YS22hm76j9oy3y7jOzTe+36MCG9Lb+VXoYvWrpH3Vn4lUJdmHfFQr+vbOWX7eEqsUPKT8nDxjwiBB rQ+xs6bg==; Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lfmr9-0083Ez-5Z for linux-arm-kernel@lists.infradead.org; Sun, 09 May 2021 17:04:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620579877; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gS221mF5itctneFLHEBt6dN2sStEXBf4HlghBIHalXQ=; b=QVxhoh4BCi/g0FZ8LYBFSQshkIJo+qTIylhd6aENrQootgCXqyIh+1/X0E7x8i8i5qF38R QSZ/g/a7DhF/3uy2G3CLWuDx4723mIPnBaQurDpg5tS9MAnZrywbP2XfJU5EHdla/KlUG4 Ms29MZCb90/hV+PCH5HThFSubo69504= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-591-NKNK1PMkMt-tlAQTihZAUg-1; Sun, 09 May 2021 13:04:36 -0400 X-MC-Unique: NKNK1PMkMt-tlAQTihZAUg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9A58B18397A6; Sun, 9 May 2021 17:04:34 +0000 (UTC) Received: from [10.36.113.168] (ovpn-113-168.ams2.redhat.com [10.36.113.168]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DAF1169FCE; Sun, 9 May 2021 17:04:24 +0000 (UTC) Subject: Re: [PATCH] Revert "irqbypass: do not start cons/prod when failed connect" To: Marc Zyngier , Zhu Lingshan Cc: jasowang@redhat.com, mst@redhat.com, alex.williamson@redhat.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, cohuck@redhat.com, stable@vger.kernel.org, Shaokun Zhang References: <20210508071152.722425-1-lingshan.zhu@intel.com> <8735uxvajh.wl-maz@kernel.org> From: Auger Eric Message-ID: <65e48458-f94c-e5fd-03d5-93d6acfb356c@redhat.com> Date: Sun, 9 May 2021 19:04:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <8735uxvajh.wl-maz@kernel.org> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210509_100439_318667_75EC0595 X-CRM114-Status: GOOD ( 14.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 5/8/21 11:29 AM, Marc Zyngier wrote: > On Sat, 08 May 2021 08:11:52 +0100, > Zhu Lingshan wrote: >> >> This reverts commit a979a6aa009f3c99689432e0cdb5402a4463fb88. >> >> The reverted commit may cause VM freeze on arm64 platform. >> Because on arm64 platform, stop a consumer will suspend the VM, >> the VM will freeze without a start consumer > > It also unconditionally calls del_consumer on the producer, which > isn't exactly expected. > >> >> Signed-off-by: Zhu Lingshan > > Reported-by: Shaokun Zhang Reviewed-by: Eric Auger Thanks Eric > Suggested-by: Marc Zyngier > Acked-by: Marc Zyngier > Fixes: a979a6aa009f ("irqbypass: do not start cons/prod when failed connect") > Link: https://lore.kernel.org/r/3a2c66d6-6ca0-8478-d24b-61e8e3241b20@hisilicon.com > Cc: stable@vger.kernel.org > > Thanks, > > M. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel