From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@lst.de>, Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH, RFC] xfs: re-enable FIBMAP on reflink; disable for swap
Date: Thu, 30 Aug 2018 11:35:46 -0500 [thread overview]
Message-ID: <65e818f2-885d-50a4-0d4a-7700c703c2af@sandeen.net> (raw)
In-Reply-To: <20180830163614.GA27069@lst.de>
On 8/30/18 11:36 AM, Christoph Hellwig wrote:
> On Thu, Aug 30, 2018 at 11:31:40AM -0500, Eric Sandeen wrote:
>> That's no reason to uniquely disallow it for reflinked files, though;
>> the problem is universal. It's true for fiemap as well. So I'm not sure
>> that's an argument against the patch?
>
> fiemap at least tells you an extent is shared, bmap does not.
yes, so bmap is clearly the wrong interface to use if you want to
write directly to a file's blocks. But if you know enough to check
the fiemap shared flag, you know enough to not use fibmap for that purpose...
-Eric
next prev parent reply other threads:[~2018-08-30 20:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 16:10 [PATCH, RFC] xfs: re-enable FIBMAP on reflink; disable for swap Eric Sandeen
2018-08-30 16:25 ` Christoph Hellwig
2018-08-30 16:31 ` Eric Sandeen
2018-08-30 16:36 ` Christoph Hellwig
2018-08-30 16:35 ` Eric Sandeen [this message]
2018-08-30 18:02 ` Brian Foster
2018-08-30 18:28 ` Darrick J. Wong
2018-08-30 18:51 ` Eric Sandeen
2018-08-30 19:39 ` Brian Foster
2018-08-30 19:47 ` Eric Sandeen
2018-08-30 19:58 ` Brian Foster
2018-08-31 0:11 ` Dave Chinner
2018-08-31 1:34 ` Eric Sandeen
2018-08-31 3:05 ` Dave Chinner
2018-08-31 13:08 ` Eric Sandeen
2018-09-01 8:32 ` Christoph Hellwig
2018-08-31 6:28 ` Christoph Hellwig
2018-08-31 12:36 ` Brian Foster
2018-09-01 8:31 ` Christoph Hellwig
2018-09-02 14:08 ` Carlos Maiolino
2018-09-02 17:52 ` Eric Sandeen
2018-09-03 10:21 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65e818f2-885d-50a4-0d4a-7700c703c2af@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.