From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74D0AC5DF63 for ; Wed, 6 Nov 2019 16:40:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 484D120650 for ; Wed, 6 Nov 2019 16:40:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b="aZjOEKuw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732229AbfKFQkA (ORCPT ); Wed, 6 Nov 2019 11:40:00 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:44705 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727149AbfKFQj6 (ORCPT ); Wed, 6 Nov 2019 11:39:58 -0500 Received: by mail-pl1-f194.google.com with SMTP id q16so11690776pll.11 for ; Wed, 06 Nov 2019 08:39:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=googlenew; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=h+8AXOejPKtSX84fzeR4pP1AIGKjnaVzTWbF4IpDTlY=; b=aZjOEKuwvk4LUjS0Pg/iyqv8fUwr+4Eqr4VNsOuYqjPBPirNxvv5KtXr/6+DvhEEeS fmtm+BfBI6Fgt3CeqBDIV/tP+8GstwQh0JsjJ3sYRdaIk0GLhOwMvca5Ymb8nyz5sCB8 bhaQzrbAb+6CErGpjDhkRIjrO5rlEPsDprWki5Fb2Mum/9MbX9Jf95N6JsliyllKSJVI Il7Rovp8XoqxkTcJcmJjRSncQE73tk/DeDoYM/TjrvEBhtbrtNoyTrcJLbJRh7+3wUG2 FTBbSr+lLJZwiQA0K1a6KQpZqVbUp7Vc8DofHhprXygu6WGOo7KWvqM7uY4vVgFlF9/9 qKPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=h+8AXOejPKtSX84fzeR4pP1AIGKjnaVzTWbF4IpDTlY=; b=extI0ICVjP0Q8R1hlHofie2tp7WE1+iBUMji2+vgNZLHJyK7293Cr7uzLTQUAw10yZ ixJBi15Hg6/fqZmXJ77R296s2wA4RrdQlFnDM6NKDU0vJcSRmFYJ5ESb4x/cY5xT/txg gXwfpQSmmBqTycKTIIgdUFyKfLRMfebNwFJDVJpZDnnZ2zZ19u1qLBYiWuDzjFVBLiez yl01j3XPIfYuyIEgmfjPiKWgA9aowcfcthP5xuon7vMN3J2tENJHsRdiHGk9tMZP8zyV WQEPAhOHiNwEeWRWDnYtYVM6GLgp4CILbMvK9o9yUyoeXB4ILBF5XScr2UoaK6vKlRuX Jrrg== X-Gm-Message-State: APjAAAXfrRBZh0QTOtReZnEPs+ZKO8z52S6tSmPZmjqSAPvAtqxSAZj6 uc6BMzyCS9l+5VmcGLnNpa6FPQ== X-Google-Smtp-Source: APXvYqywfR9UQlZvtVaHdkOoCsd877Kid/BBKE9QMojVPiD4B1uPWPELoLK/DLKCNhVOxuK2oHgGlQ== X-Received: by 2002:a17:902:8647:: with SMTP id y7mr2024671plt.285.1573058397431; Wed, 06 Nov 2019 08:39:57 -0800 (PST) Received: from [10.83.36.153] ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id y26sm13229647pfo.76.2019.11.06.08.39.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Nov 2019 08:39:56 -0800 (PST) Subject: Re: [PATCH 01/50] kallsyms/printk: Add loglvl to print_ip_sym() To: Sergey Senozhatsky Cc: linux-kernel@vger.kernel.org, Dmitry Safonov <0x7f454c46@gmail.com>, Andrew Morton , Greg Kroah-Hartman , Ingo Molnar , Jiri Slaby , Petr Mladek , Sergey Senozhatsky , Steven Rostedt , Tetsuo Handa , Albert Ou , Ben Segall , Dietmar Eggemann , Greentime Hu , Ingo Molnar , James Hogan , Juri Lelli , Mel Gorman , Michal Simek , Palmer Dabbelt , Paul Burton , Paul Walmsley , Peter Zijlstra , Ralf Baechle , Thomas Gleixner , Vincent Chen , Vincent Guittot , Will Deacon , linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org References: <20191106030542.868541-1-dima@arista.com> <20191106030542.868541-2-dima@arista.com> <20191106043851.GA131976@google.com> From: Dmitry Safonov Message-ID: <65ef777b-ceb0-09d7-6fb0-fb79328ad87d@arista.com> Date: Wed, 6 Nov 2019 16:39:43 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191106043851.GA131976@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sergey, On 11/6/19 4:38 AM, Sergey Senozhatsky wrote: > On (19/11/06 03:04), Dmitry Safonov wrote: > [..] >> diff --git a/kernel/sched/core.c b/kernel/sched/core.c >> index dd05a378631a..774ff0d8dfe9 100644 >> --- a/kernel/sched/core.c >> +++ b/kernel/sched/core.c >> @@ -3858,7 +3858,7 @@ static noinline void __schedule_bug(struct task_struct *prev) >> if (IS_ENABLED(CONFIG_DEBUG_PREEMPT) >> && in_atomic_preempt_off()) { >> pr_err("Preemption disabled at:"); >> - print_ip_sym(preempt_disable_ip); >> + print_ip_sym(KERN_ERR, preempt_disable_ip); >> pr_cont("\n"); > > Is this working with pr_cont()? print_ip_sym() will cause log_store().. And pr_cont("\n") will go here: : /* Skip empty continuation lines that couldn't be added - they just flush */ : if (!text_len && (lflags & LOG_CONT)) : return 0; So it doesn't do anything. I didn't want to change any behavior in the patch, but seems that I can remove this pr_cont() while at here. Thanks, Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9EA6C5DF65 for ; Wed, 6 Nov 2019 16:40:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEE3820650 for ; Wed, 6 Nov 2019 16:40:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uTwqmiwF"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=arista.com header.i=@arista.com header.b="aZjOEKuw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AEE3820650 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=arista.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i77rMSxREABSLBv+ymf+kwAsQNrJe8dDaapBfVM1NjQ=; b=uTwqmiwFvL0j+D 5C7GSuAGdns8UgROVJbxkoQofigcQc1L4BdK/qSCQ1kMGisB+gadHk1wshPRBsLUkds4RUyZUx2+U IZDC4iaBUFJcRotPCMUSZTCqnB3yZcHA+y6NUnd/6zmvOf8WGr3lEppEfn98YoQspCpFHtM+K2Crm 2p9IGn2+GTgXwMGL93TzgMmox5/Wk8y/0tBoO4QNMqaXSJkKzVc1zjq4Q8KXbxDspc4r3ArN4Cfy3 /OA5fwn0Yo7gHCmmExmy+JCgW27K3SbUK0vQFL99qaZtU9oDiafmGM2TnpsPJtYC/s6uoDtCGbJpT degfQLL1mPcoGmsczpFw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSOLh-0001hm-Jc; Wed, 06 Nov 2019 16:40:01 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSOLe-0001gr-3T for linux-riscv@lists.infradead.org; Wed, 06 Nov 2019 16:39:59 +0000 Received: by mail-pl1-x641.google.com with SMTP id k7so11698606pll.1 for ; Wed, 06 Nov 2019 08:39:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=googlenew; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=h+8AXOejPKtSX84fzeR4pP1AIGKjnaVzTWbF4IpDTlY=; b=aZjOEKuwvk4LUjS0Pg/iyqv8fUwr+4Eqr4VNsOuYqjPBPirNxvv5KtXr/6+DvhEEeS fmtm+BfBI6Fgt3CeqBDIV/tP+8GstwQh0JsjJ3sYRdaIk0GLhOwMvca5Ymb8nyz5sCB8 bhaQzrbAb+6CErGpjDhkRIjrO5rlEPsDprWki5Fb2Mum/9MbX9Jf95N6JsliyllKSJVI Il7Rovp8XoqxkTcJcmJjRSncQE73tk/DeDoYM/TjrvEBhtbrtNoyTrcJLbJRh7+3wUG2 FTBbSr+lLJZwiQA0K1a6KQpZqVbUp7Vc8DofHhprXygu6WGOo7KWvqM7uY4vVgFlF9/9 qKPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=h+8AXOejPKtSX84fzeR4pP1AIGKjnaVzTWbF4IpDTlY=; b=aptX8YC+3FSTkV6RHPL9HcuPPioYHkAwr2Zk9WIdD+2hPPl9aEiU3UIW7DlLS7YTX+ KJkKgMghfzpGYAfgRVO0OdkKwaz6spD8Di41JC32RC/9jISZoFK+o48Nyc8n3cS2y+kw lH2Sx+gA2iDq83H/Fbfa/wCgJKQeLBeUbh8KpOdjkVXNeaKBrRCefBCvg7sJi3QR4yAL SWghBG8gT+fDweSGlHW88mjPaMbhsnlpJ1VTY+0gtV3MQWERKzfgmyxxhSsSkqjmaGhu QszwRLRX+N85tqGxyqeEZcQ/BqjvwFunNzpJLLT+ooLChujUvQfbjuPBFSowDKZKiIWi PMhw== X-Gm-Message-State: APjAAAUMklSb+ixanzT4J223w9h+h+6o4aCpsfSmZ9SWkt9fmEZb9EQl aNKgQNa2rFyaMlXWQvIn8lWLuw== X-Google-Smtp-Source: APXvYqywfR9UQlZvtVaHdkOoCsd877Kid/BBKE9QMojVPiD4B1uPWPELoLK/DLKCNhVOxuK2oHgGlQ== X-Received: by 2002:a17:902:8647:: with SMTP id y7mr2024671plt.285.1573058397431; Wed, 06 Nov 2019 08:39:57 -0800 (PST) Received: from [10.83.36.153] ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id y26sm13229647pfo.76.2019.11.06.08.39.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Nov 2019 08:39:56 -0800 (PST) Subject: Re: [PATCH 01/50] kallsyms/printk: Add loglvl to print_ip_sym() To: Sergey Senozhatsky References: <20191106030542.868541-1-dima@arista.com> <20191106030542.868541-2-dima@arista.com> <20191106043851.GA131976@google.com> From: Dmitry Safonov Message-ID: <65ef777b-ceb0-09d7-6fb0-fb79328ad87d@arista.com> Date: Wed, 6 Nov 2019 16:39:43 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191106043851.GA131976@google.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191106_083958_146953_0873157A X-CRM114-Status: GOOD ( 11.52 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juri Lelli , Tetsuo Handa , James Hogan , Dmitry Safonov <0x7f454c46@gmail.com>, linux-mips@vger.kernel.org, Ben Segall , linux-riscv@lists.infradead.org, Vincent Chen , Will Deacon , Ingo Molnar , Vincent Guittot , Paul Burton , Peter Zijlstra , Ingo Molnar , Mel Gorman , Jiri Slaby , Petr Mladek , Albert Ou , Steven Rostedt , Greentime Hu , Paul Walmsley , Thomas Gleixner , Dietmar Eggemann , Michal Simek , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Ralf Baechle , Sergey Senozhatsky , Palmer Dabbelt , Andrew Morton Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org Hi Sergey, On 11/6/19 4:38 AM, Sergey Senozhatsky wrote: > On (19/11/06 03:04), Dmitry Safonov wrote: > [..] >> diff --git a/kernel/sched/core.c b/kernel/sched/core.c >> index dd05a378631a..774ff0d8dfe9 100644 >> --- a/kernel/sched/core.c >> +++ b/kernel/sched/core.c >> @@ -3858,7 +3858,7 @@ static noinline void __schedule_bug(struct task_struct *prev) >> if (IS_ENABLED(CONFIG_DEBUG_PREEMPT) >> && in_atomic_preempt_off()) { >> pr_err("Preemption disabled at:"); >> - print_ip_sym(preempt_disable_ip); >> + print_ip_sym(KERN_ERR, preempt_disable_ip); >> pr_cont("\n"); > > Is this working with pr_cont()? print_ip_sym() will cause log_store().. And pr_cont("\n") will go here: : /* Skip empty continuation lines that couldn't be added - they just flush */ : if (!text_len && (lflags & LOG_CONT)) : return 0; So it doesn't do anything. I didn't want to change any behavior in the patch, but seems that I can remove this pr_cont() while at here. Thanks, Dmitry _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv