From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41A14C433E2 for ; Tue, 14 Jul 2020 12:01:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DDEC22224 for ; Tue, 14 Jul 2020 12:01:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dLe9dBSR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728032AbgGNMBo (ORCPT ); Tue, 14 Jul 2020 08:01:44 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:56591 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726332AbgGNMBn (ORCPT ); Tue, 14 Jul 2020 08:01:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594728102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NzuBDHY8WxHVw+Kc5uxbtm+Tv/UGUbdolVzEdoMmBhE=; b=dLe9dBSR9M22lUiewVkUKzlGVErNUDlbdK76Jkp+dcTjjXG+OOBBtpV6ASU6Om/TIRqxDV IrMbodwMAweYCRh4kcBVo4r0JuUvnVSw17t7933z9Sm05osEfLD3hWU2y0Z3MZtk5kjsdp 6nGO1Qs2jNe2tag6bvovoOKZulGkdLg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-508-_mSLh9LIO06BuCc_3WfXRg-1; Tue, 14 Jul 2020 08:01:37 -0400 X-MC-Unique: _mSLh9LIO06BuCc_3WfXRg-1 Received: by mail-wm1-f69.google.com with SMTP id s134so3613622wme.6 for ; Tue, 14 Jul 2020 05:01:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NzuBDHY8WxHVw+Kc5uxbtm+Tv/UGUbdolVzEdoMmBhE=; b=S+URF2NwE+erbNCGzqyn6hAZtZc7i71l8ySUJLDY+fYYSJEv8KNaUuVhEP7NhnIoDP fUEfDtXmlapeM74SA/COscRnibiwdNXkX0LtsJt2xWvoZNbjX/PvcfJaMuenyXNPWaJu CItJR6ScFbdMubtUBc4gV4ltqEZRun4vbhQ07FQyGPWCP7/Venl4q1X4y7BLAJ88/02H CSedzH5EZCbcalnk3VwmHeCJ5GvSxcQKDxxIA+dxmeTtyurgR7Ejc7mhlg61lksICkWr IeW0fmwLUcuyKZ9wBodG9LfIY/1mwhUw7RyBn6r8OP9hGBIEq7ufAS3th2djGAEIJUek WbyQ== X-Gm-Message-State: AOAM530VcOE38UoRnpnZJiUmrsgsDUC/0OxlXt9b75mrivjRuvfJo1CH UvdltYzS6IYg6J1i0fnep5SNNkh33u4XcZgvvByLuM/QX9RNN16ENlSWDqNBVtb1d4kWZrYbGJR USGAqKhrefTLRulL43vLvzpx0 X-Received: by 2002:a05:6000:46:: with SMTP id k6mr4915626wrx.102.1594728095803; Tue, 14 Jul 2020 05:01:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwRWb7tTc7UzuLqaB4EtVaorEanJOKFyDzDcud2e1J9/uU8AvfG3tw0yBdSHRwNxyEMbrjmtQ== X-Received: by 2002:a05:6000:46:: with SMTP id k6mr4915596wrx.102.1594728095573; Tue, 14 Jul 2020 05:01:35 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c0c-fe00-d2ea-f29d-118b-24dc.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:d2ea:f29d:118b:24dc]) by smtp.gmail.com with ESMTPSA id v7sm29697902wrp.45.2020.07.14.05.01.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jul 2020 05:01:34 -0700 (PDT) Subject: Re: [PATCH 08/32] usb: typec: tcpm: tcpm: Remove dangling unused 'struct tcpm_altmode_ops' To: Lee Jones Cc: gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Guenter Roeck , Heikki Krogerus References: <20200706133341.476881-1-lee.jones@linaro.org> <20200706133341.476881-9-lee.jones@linaro.org> <20200706142051.GA3500@dell> From: Hans de Goede Message-ID: <65f27abc-69c8-3877-be5b-e5e478153af9@redhat.com> Date: Tue, 14 Jul 2020 14:01:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200706142051.GA3500@dell> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 7/6/20 4:20 PM, Lee Jones wrote: > On Mon, 06 Jul 2020, Hans de Goede wrote: > >> Hi, >> >> On 7/6/20 3:33 PM, Lee Jones wrote: >>> Looks as though a079973f462a3 ("usb: typec: tcpm: Remove tcpc_config >>> configuration mechanism") pulled out the only use of 'tcpm_altmode_ops' >>> last year. No need to keep it around. >>> >>> Fixes the following W=1 kernel build warning(s): >>> >>> drivers/usb/typec/tcpm/tcpm.c:1551:39: warning: ‘tcpm_altmode_ops’ defined but not used [-Wunused-const-variable=] >>> 1551 | static const struct typec_altmode_ops tcpm_altmode_ops = { >>> | ^~~~~~~~~~~~~~~~ >>> >>> Cc: Guenter Roeck >>> Cc: Heikki Krogerus >>> Cc: Hans de Goede >>> Signed-off-by: Lee Jones >> >> This is necessary for adding Display port over Type-C support >> on devices using the tcpm code, rather then firmware, to do >> the Type-C alt-mode negotiation. >> >> I have a local patch in my tree which adds support for this. >> >> But Heikki did not like my approach, so that patch >> (which needs the bits you are removing) never landed >> upstream: >> >> https://patchwork.kernel.org/patch/11199517/ >> >> Which is somewhat old now. > > Yes, that's a just a little old now. > > If it drags on for much longer, perhaps consider taking it out for the > time being and adding it back when you start to make use of it again? Ok, I've just submitted a reworked patch-series upstream which actually uses this code. So please drop this patch from your patch-set. Regards, Hans s From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4914C433E0 for ; Tue, 14 Jul 2020 12:03:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9181122224 for ; Tue, 14 Jul 2020 12:03:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="g+t3o4wr"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dLe9dBSR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9181122224 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RIUlDtheaywEzonHo62ITTzVouAQGOqR2kX58THPR7c=; b=g+t3o4wrEXh93JijWge4d8qpA WUjAybkicf6oEnc0qkBTt1wDTQEWusnQIX5NesHj5lgFmZdjBm7GJUD0RwpLnO+Uqz5u/bmnn3ehx P/y4SLR7/wsyeRT8PYRR1Obz+eR9ahXrrC6xdJntOJc6gHq+aQ9HQONfrW/xM+NtDtZ90/hNYfnRw V6LhBD8bw/4f0XeDpC1nZkRqA8+D3SWNmSsLZXjH6M2KcHiwKxnW+L2PpQz/CFGZpppTIkXqRrOpd t/+it94O2HQxkVvuZ2AWI9mDfAY9trysPTNJSuRrm8hCDA40SfHCADvCEnfSs538BmhTtA6L9RXJA w2zeGe1Jw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvJd3-0005Uq-R5; Tue, 14 Jul 2020 12:01:45 +0000 Received: from us-smtp-1.mimecast.com ([205.139.110.61] helo=us-smtp-delivery-1.mimecast.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvJd0-0005Tv-QZ for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2020 12:01:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594728102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NzuBDHY8WxHVw+Kc5uxbtm+Tv/UGUbdolVzEdoMmBhE=; b=dLe9dBSR9M22lUiewVkUKzlGVErNUDlbdK76Jkp+dcTjjXG+OOBBtpV6ASU6Om/TIRqxDV IrMbodwMAweYCRh4kcBVo4r0JuUvnVSw17t7933z9Sm05osEfLD3hWU2y0Z3MZtk5kjsdp 6nGO1Qs2jNe2tag6bvovoOKZulGkdLg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-386-g5MEUoW9O5maNyrW1pjnmA-1; Tue, 14 Jul 2020 08:01:37 -0400 X-MC-Unique: g5MEUoW9O5maNyrW1pjnmA-1 Received: by mail-wr1-f70.google.com with SMTP id b8so21441514wro.19 for ; Tue, 14 Jul 2020 05:01:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NzuBDHY8WxHVw+Kc5uxbtm+Tv/UGUbdolVzEdoMmBhE=; b=ibmd0xzB3qg7U57BQMXvpzCa70lQbC5QlZbc/hDWD05sxCudxFjcLX2KOQdb9KDcJ7 lPAinsy53JyEFksECmrrCPdUuSTOJEDM20gT05kbf/TuLY743TtmYVm/eJ8h6PQ4XBLp MLACFkksGlEN3a+34cguvU1yUpy7MF6pam4IEub7+6WhI06nHAcycljjoIh0JHGAko1T I9V8Ydt6WBv8dmD6TxyXdbnPEGS0D8/60OIYDJW2Mxbic9Lmwp/+/vjpNRDR10Qcem+F 1r/M5EYOPEvYozPT5jn3j1lHNxB7G0DtzcWRWsNZ2sPaO7sqMHjRhCIgDkpGCo76vOUA mhhQ== X-Gm-Message-State: AOAM532eBWz6RmrPtdFsZxwkUwh6rNZKMVJUlnKB3P1/Ib9MMBYP9hp1 vf8EMjhz7Rz77fbd22L6e+ldmxxYyVeM8zf/S08+i+lwinDVh412yI5ymFYmZ3/LIn9pRIti8v+ 9/rITOAb7jxXY23OO2j3Bvy0BsMi0JFldPgM= X-Received: by 2002:a05:6000:46:: with SMTP id k6mr4915625wrx.102.1594728095802; Tue, 14 Jul 2020 05:01:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwRWb7tTc7UzuLqaB4EtVaorEanJOKFyDzDcud2e1J9/uU8AvfG3tw0yBdSHRwNxyEMbrjmtQ== X-Received: by 2002:a05:6000:46:: with SMTP id k6mr4915596wrx.102.1594728095573; Tue, 14 Jul 2020 05:01:35 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c0c-fe00-d2ea-f29d-118b-24dc.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:d2ea:f29d:118b:24dc]) by smtp.gmail.com with ESMTPSA id v7sm29697902wrp.45.2020.07.14.05.01.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jul 2020 05:01:34 -0700 (PDT) Subject: Re: [PATCH 08/32] usb: typec: tcpm: tcpm: Remove dangling unused 'struct tcpm_altmode_ops' To: Lee Jones References: <20200706133341.476881-1-lee.jones@linaro.org> <20200706133341.476881-9-lee.jones@linaro.org> <20200706142051.GA3500@dell> From: Hans de Goede Message-ID: <65f27abc-69c8-3877-be5b-e5e478153af9@redhat.com> Date: Tue, 14 Jul 2020 14:01:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200706142051.GA3500@dell> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_080143_185098_6AA4707A X-CRM114-Status: GOOD ( 15.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heikki Krogerus , gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpPbiA3LzYvMjAgNDoyMCBQTSwgTGVlIEpvbmVzIHdyb3RlOgo+IE9uIE1vbiwgMDYgSnVs IDIwMjAsIEhhbnMgZGUgR29lZGUgd3JvdGU6Cj4gCj4+IEhpLAo+Pgo+PiBPbiA3LzYvMjAgMzoz MyBQTSwgTGVlIEpvbmVzIHdyb3RlOgo+Pj4gTG9va3MgYXMgdGhvdWdoIGEwNzk5NzNmNDYyYTMg KCJ1c2I6IHR5cGVjOiB0Y3BtOiBSZW1vdmUgdGNwY19jb25maWcKPj4+IGNvbmZpZ3VyYXRpb24g bWVjaGFuaXNtIikgcHVsbGVkIG91dCB0aGUgb25seSB1c2Ugb2YgJ3RjcG1fYWx0bW9kZV9vcHMn Cj4+PiBsYXN0IHllYXIuICBObyBuZWVkIHRvIGtlZXAgaXQgYXJvdW5kLgo+Pj4KPj4+IEZpeGVz IHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5lbCBidWlsZCB3YXJuaW5nKHMpOgo+Pj4KPj4+ICAgIGRy aXZlcnMvdXNiL3R5cGVjL3RjcG0vdGNwbS5jOjE1NTE6Mzk6IHdhcm5pbmc6IOKAmHRjcG1fYWx0 bW9kZV9vcHPigJkgZGVmaW5lZCBidXQgbm90IHVzZWQgWy1XdW51c2VkLWNvbnN0LXZhcmlhYmxl PV0KPj4+ICAgIDE1NTEgfCBzdGF0aWMgY29uc3Qgc3RydWN0IHR5cGVjX2FsdG1vZGVfb3BzIHRj cG1fYWx0bW9kZV9vcHMgPSB7Cj4+PiAgICB8IF5+fn5+fn5+fn5+fn5+fn4KPj4+Cj4+PiBDYzog R3VlbnRlciBSb2VjayA8bGludXhAcm9lY2stdXMubmV0Pgo+Pj4gQ2M6IEhlaWtraSBLcm9nZXJ1 cyA8aGVpa2tpLmtyb2dlcnVzQGxpbnV4LmludGVsLmNvbT4KPj4+IENjOiBIYW5zIGRlIEdvZWRl IDxoZGVnb2VkZUByZWRoYXQuY29tPgo+Pj4gU2lnbmVkLW9mZi1ieTogTGVlIEpvbmVzIDxsZWUu am9uZXNAbGluYXJvLm9yZz4KPj4KPj4gVGhpcyBpcyBuZWNlc3NhcnkgZm9yIGFkZGluZyBEaXNw bGF5IHBvcnQgb3ZlciBUeXBlLUMgc3VwcG9ydAo+PiBvbiBkZXZpY2VzIHVzaW5nIHRoZSB0Y3Bt IGNvZGUsIHJhdGhlciB0aGVuIGZpcm13YXJlLCB0byBkbwo+PiB0aGUgVHlwZS1DIGFsdC1tb2Rl IG5lZ290aWF0aW9uLgo+Pgo+PiBJIGhhdmUgYSBsb2NhbCBwYXRjaCBpbiBteSB0cmVlIHdoaWNo IGFkZHMgc3VwcG9ydCBmb3IgdGhpcy4KPj4KPj4gQnV0IEhlaWtraSBkaWQgbm90IGxpa2UgbXkg YXBwcm9hY2gsIHNvIHRoYXQgcGF0Y2gKPj4gKHdoaWNoIG5lZWRzIHRoZSBiaXRzIHlvdSBhcmUg cmVtb3ZpbmcpIG5ldmVyIGxhbmRlZAo+PiB1cHN0cmVhbToKPj4KPj4gaHR0cHM6Ly9wYXRjaHdv cmsua2VybmVsLm9yZy9wYXRjaC8xMTE5OTUxNy8KPj4KPj4gV2hpY2ggaXMgc29tZXdoYXQgb2xk IG5vdy4KPiAKPiBZZXMsIHRoYXQncyBhIGp1c3QgYSBsaXR0bGUgb2xkIG5vdy4KPiAKPiBJZiBp dCBkcmFncyBvbiBmb3IgbXVjaCBsb25nZXIsIHBlcmhhcHMgY29uc2lkZXIgdGFraW5nIGl0IG91 dCBmb3IgdGhlCj4gdGltZSBiZWluZyBhbmQgYWRkaW5nIGl0IGJhY2sgd2hlbiB5b3Ugc3RhcnQg dG8gbWFrZSB1c2Ugb2YgaXQgYWdhaW4/CgpPaywgSSd2ZSBqdXN0IHN1Ym1pdHRlZCBhIHJld29y a2VkIHBhdGNoLXNlcmllcyB1cHN0cmVhbSB3aGljaAphY3R1YWxseSB1c2VzIHRoaXMgY29kZS4g U28gcGxlYXNlIGRyb3AgdGhpcyBwYXRjaCBmcm9tIHlvdXIKcGF0Y2gtc2V0LgoKUmVnYXJkcywK CkhhbnMKCgpzCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo=