All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/4] btrfs: delete identified alien device in open_fs_devices
Date: Sun, 6 Oct 2019 10:51:55 +0800	[thread overview]
Message-ID: <65fab107-87f6-b15f-3e1c-74b586bcf3fe@oracle.com> (raw)
In-Reply-To: <66defad6-6757-76d2-8819-fd22b9cd1b9e@suse.com>



>> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
>> index 06ec3577c6b4..05ade8c7342b 100644
>> --- a/fs/btrfs/volumes.c
>> +++ b/fs/btrfs/volumes.c
>> @@ -803,10 +803,10 @@ static int btrfs_open_one_device(struct btrfs_fs_devices *fs_devices,
>>   	disk_super = (struct btrfs_super_block *)bh->b_data;
>>   	devid = btrfs_stack_device_id(&disk_super->dev_item);
>>   	if (devid != device->devid)
>> -		goto error_brelse;
>> +		goto free_alien;
>>   
>>   	if (memcmp(device->uuid, disk_super->dev_item.uuid, BTRFS_UUID_SIZE))
>> -		goto error_brelse;
>> +		goto free_alien;
>>   
> 
> Imo a better approach is to return a particular error code and do the
> deletion in open_fs_devices. Otherwise it's not apparent why you use
> list_for_each_entry_safe in one function to delete something in a
> different one (whose name by the way doesn't suggest a deletion is going
> on). Looking at the error I think enodev/enxio is appropriate.

  Agreed. And used -EUCLEAN I think that's most appropriate.
  Thanks, Anand

  parent reply	other threads:[~2019-10-06  2:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-04  7:49 [PATCH 0/4] btrfs: fix issues due to alien device Anand Jain
2019-10-04  7:50 ` [PATCH 1/4] btrfs: drop useless goto in open_fs_devices Anand Jain
2019-10-04  8:12   ` Nikolay Borisov
2019-10-04  7:50 ` [PATCH 2/4] btrfs: delete identified alien device " Anand Jain
2019-10-04  8:18   ` Nikolay Borisov
2019-10-06  2:47     ` [PATCH v2 " Anand Jain
2019-10-06 11:44       ` Nikolay Borisov
2019-10-06  2:51     ` Anand Jain [this message]
2019-10-04  7:50 ` [PATCH 3/4] btrfs: include non-missing as a qualifier for the latest_bdev Anand Jain
2019-10-04  8:11   ` Nikolay Borisov
2019-10-04  9:08     ` [Not TLS] " Graham Cobb
2019-10-04  9:20       ` Nikolay Borisov
2019-10-04  7:50 ` [PATCH 4/4] btrfs: free alien device due to device add Anand Jain
2019-10-04  8:19 ` [PATCH 0/4] btrfs: fix issues due to alien device Nikolay Borisov
2019-10-07  9:42   ` Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65fab107-87f6-b15f-3e1c-74b586bcf3fe@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=nborisov@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.