From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79B67C433E0 for ; Mon, 22 Mar 2021 14:49:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 314456192B for ; Mon, 22 Mar 2021 14:49:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230312AbhCVOtT (ORCPT ); Mon, 22 Mar 2021 10:49:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229984AbhCVOst (ORCPT ); Mon, 22 Mar 2021 10:48:49 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3A87C061574 for ; Mon, 22 Mar 2021 07:48:48 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id n138so21710994lfa.3 for ; Mon, 22 Mar 2021 07:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/fZAw+4NiDFcgCHrlrGbQDPrYTTv6kbwUEtQSv61zqs=; b=uWXu5sM6j9p6UAdXDmXHXNods3NAIXQo6QRBvok8FlIH2o0IlS5LnfqMrHqe7Q2BmI fAIBh1+Na57dou/HqlvXReLw19EPtpVqzNPBfSdT8+Gu/dc1FgUMkMlTiQhTH9h3PRCm ptbTZ9kf/ocg3YA2aLgmQiu60FBdaeDoIBB+naU/WNrcLxv3c7Y8FOAc17MsYq4yrLmM D3fApXpJkI1MaHaosCT9+/1nx6ySJZ6n8l6FWnWjoxC/o96vUP8qk0IhqZ9glMzXlYo6 OtiRr4DGpUq2wGeVO8r7mEoIBO5JENPaqZ30ujvMd+DqouZV9+iYH6gTbH7DUpFgoP3g a9sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/fZAw+4NiDFcgCHrlrGbQDPrYTTv6kbwUEtQSv61zqs=; b=teEhAM9eTgZh7XEr+BmXVIdnFdnhuhUDYz5jVq5cDzGSXG/LTgQTDmZonvqTJcEDPj V5TQcpZ+NVrFjThTs884sdxd02USv6kBYPm3lZjbgHjDfI0kkKM+Bt2T2Epldw2idvd9 sGcsVqByGKDl3lO0iu1/sKvUk8rZa03GxeIMdBlZ6SnWYvilXZ0mrhHahSgxJA51O254 Mu/YSS0fQNTH6xSwrnu58OrXylIZE1I2dzpMrCssAtiHJnyaTp9QPaNd2hYIUtqY3MYd j+KOlj69zfeOysVvZU/GSrRiIBbEa2Ulr8TUNt7YKncwqfaHJiXeHHoKcgCj/oWWjTWN p1xA== X-Gm-Message-State: AOAM533yscnfbTwy4KMnjGbGoyABVb59/4Fc/Yt0WtawdBIIdmLcrgt5 eYCyrsiDNXz4f2nKxVIZFkg= X-Google-Smtp-Source: ABdhPJysSCaiPo03sO9bykrRBdDLruy+482nEDsgN0vR2QWZdV2ZWoP7ivyB6E2B88FT/fhsUx1Jaw== X-Received: by 2002:ac2:4e82:: with SMTP id o2mr9206984lfr.489.1616424527005; Mon, 22 Mar 2021 07:48:47 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-47.dynamic.spd-mgts.ru. [109.252.193.47]) by smtp.googlemail.com with ESMTPSA id x7sm1955517ljc.118.2021.03.22.07.48.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Mar 2021 07:48:46 -0700 (PDT) Subject: Re: [PATCH v5 01/21] gpu: host1x: Use different lock classes for each client To: Thierry Reding , Mikko Perttunen Cc: jonathanh@nvidia.com, airlied@linux.ie, daniel@ffwll.ch, linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, talho@nvidia.com, bhuntsman@nvidia.com References: <20210111130019.3515669-1-mperttunen@nvidia.com> <20210111130019.3515669-2-mperttunen@nvidia.com> From: Dmitry Osipenko Message-ID: <6615105f-ccf1-7833-512c-090817c47952@gmail.com> Date: Mon, 22 Mar 2021 17:48:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 22.03.2021 17:46, Thierry Reding пишет: > On Mon, Jan 11, 2021 at 02:59:59PM +0200, Mikko Perttunen wrote: >> To avoid false lockdep warnings, give each client lock a different >> lock class, passed from the initialization site by macro. >> >> Signed-off-by: Mikko Perttunen >> --- >> drivers/gpu/host1x/bus.c | 7 ++++--- >> include/linux/host1x.h | 9 ++++++++- >> 2 files changed, 12 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/host1x/bus.c b/drivers/gpu/host1x/bus.c >> index 347fb962b6c9..8fc79e9cb652 100644 >> --- a/drivers/gpu/host1x/bus.c >> +++ b/drivers/gpu/host1x/bus.c >> @@ -715,13 +715,14 @@ EXPORT_SYMBOL(host1x_driver_unregister); >> * device and call host1x_device_init(), which will in turn call each client's >> * &host1x_client_ops.init implementation. >> */ >> -int host1x_client_register(struct host1x_client *client) >> +int __host1x_client_register(struct host1x_client *client, >> + struct lock_class_key *key) > > I've seen the kbuild robot warn about this because the kerneldoc is now > out of date. > >> { >> struct host1x *host1x; >> int err; >> >> INIT_LIST_HEAD(&client->list); >> - mutex_init(&client->lock); >> + __mutex_init(&client->lock, "host1x client lock", key); > > Should we maybe attempt to make this unique? Could we use something like > dev_name(client->dev) for this? I'm curious who the lockdep warning could be triggered at all, I don't recall ever seeing it. Mikko, could you please clarify how to reproduce the warning? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E696C433DB for ; Mon, 22 Mar 2021 14:48:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D45E76192A for ; Mon, 22 Mar 2021 14:48:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D45E76192A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D40536E4CA; Mon, 22 Mar 2021 14:48:49 +0000 (UTC) Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by gabe.freedesktop.org (Postfix) with ESMTPS id BA3D56E4B7 for ; Mon, 22 Mar 2021 14:48:48 +0000 (UTC) Received: by mail-lf1-x12d.google.com with SMTP id x28so21714252lfu.6 for ; Mon, 22 Mar 2021 07:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/fZAw+4NiDFcgCHrlrGbQDPrYTTv6kbwUEtQSv61zqs=; b=uWXu5sM6j9p6UAdXDmXHXNods3NAIXQo6QRBvok8FlIH2o0IlS5LnfqMrHqe7Q2BmI fAIBh1+Na57dou/HqlvXReLw19EPtpVqzNPBfSdT8+Gu/dc1FgUMkMlTiQhTH9h3PRCm ptbTZ9kf/ocg3YA2aLgmQiu60FBdaeDoIBB+naU/WNrcLxv3c7Y8FOAc17MsYq4yrLmM D3fApXpJkI1MaHaosCT9+/1nx6ySJZ6n8l6FWnWjoxC/o96vUP8qk0IhqZ9glMzXlYo6 OtiRr4DGpUq2wGeVO8r7mEoIBO5JENPaqZ30ujvMd+DqouZV9+iYH6gTbH7DUpFgoP3g a9sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/fZAw+4NiDFcgCHrlrGbQDPrYTTv6kbwUEtQSv61zqs=; b=A/eJFgrOzkgxrlhlRY6PkYA/Mj5Q6vbATmHC5P7Vn9W7uJ8pbRitFOYhaI8ulH7i8t SQhfh3hXPgKpO8kZST53WPPJSPxyOY6MPHpAjzQYHwX42Zly25l9OVTAgWpgOCuNPtpI iCE/lcHkMTdqkV1IPFUd60S8iM84xDr80v62mH4GEuIte+qW39JbKVFfrxbQjYP6Qa86 ePiwKxSurqz/YArtLeCd19fYSImY2AXsCuy8ibR+VsVMrNLtwMBX8mWudyxPPQS5I/FH oeJCV80os2I0SPioOfuxKvw1ONXXUyuzm+lBaCKc4zhZC/w/fBZJa3HvDIaUf6YNmNY1 Hr2A== X-Gm-Message-State: AOAM530RVvxObPIEzgi+Xfs2nb6s7fEhEarXhIZVuIJMPXsCxd26cHxl dpUHvWIJ4APi0oFEvejCHY62Bnfok4A= X-Google-Smtp-Source: ABdhPJysSCaiPo03sO9bykrRBdDLruy+482nEDsgN0vR2QWZdV2ZWoP7ivyB6E2B88FT/fhsUx1Jaw== X-Received: by 2002:ac2:4e82:: with SMTP id o2mr9206984lfr.489.1616424527005; Mon, 22 Mar 2021 07:48:47 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-47.dynamic.spd-mgts.ru. [109.252.193.47]) by smtp.googlemail.com with ESMTPSA id x7sm1955517ljc.118.2021.03.22.07.48.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Mar 2021 07:48:46 -0700 (PDT) Subject: Re: [PATCH v5 01/21] gpu: host1x: Use different lock classes for each client To: Thierry Reding , Mikko Perttunen References: <20210111130019.3515669-1-mperttunen@nvidia.com> <20210111130019.3515669-2-mperttunen@nvidia.com> From: Dmitry Osipenko Message-ID: <6615105f-ccf1-7833-512c-090817c47952@gmail.com> Date: Mon, 22 Mar 2021 17:48:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, jonathanh@nvidia.com, talho@nvidia.com, bhuntsman@nvidia.com, linux-tegra@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" MjIuMDMuMjAyMSAxNzo0NiwgVGhpZXJyeSBSZWRpbmcg0L/QuNGI0LXRgjoKPiBPbiBNb24sIEph biAxMSwgMjAyMSBhdCAwMjo1OTo1OVBNICswMjAwLCBNaWtrbyBQZXJ0dHVuZW4gd3JvdGU6Cj4+ IFRvIGF2b2lkIGZhbHNlIGxvY2tkZXAgd2FybmluZ3MsIGdpdmUgZWFjaCBjbGllbnQgbG9jayBh IGRpZmZlcmVudAo+PiBsb2NrIGNsYXNzLCBwYXNzZWQgZnJvbSB0aGUgaW5pdGlhbGl6YXRpb24g c2l0ZSBieSBtYWNyby4KPj4KPj4gU2lnbmVkLW9mZi1ieTogTWlra28gUGVydHR1bmVuIDxtcGVy dHR1bmVuQG52aWRpYS5jb20+Cj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvaG9zdDF4L2J1cy5jIHwg NyArKysrLS0tCj4+ICBpbmNsdWRlL2xpbnV4L2hvc3QxeC5oICAgfCA5ICsrKysrKysrLQo+PiAg MiBmaWxlcyBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+Pgo+PiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvaG9zdDF4L2J1cy5jIGIvZHJpdmVycy9ncHUvaG9zdDF4 L2J1cy5jCj4+IGluZGV4IDM0N2ZiOTYyYjZjOS4uOGZjNzllOWNiNjUyIDEwMDY0NAo+PiAtLS0g YS9kcml2ZXJzL2dwdS9ob3N0MXgvYnVzLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvaG9zdDF4L2J1 cy5jCj4+IEBAIC03MTUsMTMgKzcxNSwxNCBAQCBFWFBPUlRfU1lNQk9MKGhvc3QxeF9kcml2ZXJf dW5yZWdpc3Rlcik7Cj4+ICAgKiBkZXZpY2UgYW5kIGNhbGwgaG9zdDF4X2RldmljZV9pbml0KCks IHdoaWNoIHdpbGwgaW4gdHVybiBjYWxsIGVhY2ggY2xpZW50J3MKPj4gICAqICZob3N0MXhfY2xp ZW50X29wcy5pbml0IGltcGxlbWVudGF0aW9uLgo+PiAgICovCj4+IC1pbnQgaG9zdDF4X2NsaWVu dF9yZWdpc3RlcihzdHJ1Y3QgaG9zdDF4X2NsaWVudCAqY2xpZW50KQo+PiAraW50IF9faG9zdDF4 X2NsaWVudF9yZWdpc3RlcihzdHJ1Y3QgaG9zdDF4X2NsaWVudCAqY2xpZW50LAo+PiArCQkJICAg c3RydWN0IGxvY2tfY2xhc3Nfa2V5ICprZXkpCj4gCj4gSSd2ZSBzZWVuIHRoZSBrYnVpbGQgcm9i b3Qgd2FybiBhYm91dCB0aGlzIGJlY2F1c2UgdGhlIGtlcm5lbGRvYyBpcyBub3cKPiBvdXQgb2Yg ZGF0ZS4KPiAKPj4gIHsKPj4gIAlzdHJ1Y3QgaG9zdDF4ICpob3N0MXg7Cj4+ICAJaW50IGVycjsK Pj4gIAo+PiAgCUlOSVRfTElTVF9IRUFEKCZjbGllbnQtPmxpc3QpOwo+PiAtCW11dGV4X2luaXQo JmNsaWVudC0+bG9jayk7Cj4+ICsJX19tdXRleF9pbml0KCZjbGllbnQtPmxvY2ssICJob3N0MXgg Y2xpZW50IGxvY2siLCBrZXkpOwo+IAo+IFNob3VsZCB3ZSBtYXliZSBhdHRlbXB0IHRvIG1ha2Ug dGhpcyB1bmlxdWU/IENvdWxkIHdlIHVzZSBzb21ldGhpbmcgbGlrZQo+IGRldl9uYW1lKGNsaWVu dC0+ZGV2KSBmb3IgdGhpcz8KCkknbSBjdXJpb3VzIHdobyB0aGUgbG9ja2RlcCB3YXJuaW5nIGNv dWxkIGJlIHRyaWdnZXJlZCBhdCBhbGwsIEkgZG9uJ3QKcmVjYWxsIGV2ZXIgc2VlaW5nIGl0LiBN aWtrbywgY291bGQgeW91IHBsZWFzZSBjbGFyaWZ5IGhvdyB0byByZXByb2R1Y2UKdGhlIHdhcm5p bmc/Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=