From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org, raphael.pour@hetzner.com
Cc: qemu-stable@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH v2 0/1] qemu-nbd: Close inherited stderr
Date: Thu, 14 May 2020 09:55:02 -0500 [thread overview]
Message-ID: <661abf79-c560-3d2f-b377-3d4535b6691f@redhat.com> (raw)
In-Reply-To: <ece77427-d918-d766-b2bc-08cf7d4660bc@redhat.com>
On 5/14/20 9:29 AM, Eric Blake wrote:
>> WARNING: Block comments use a leading /* on a separate line
>> #20: FILE: qemu-nbd.c:919:
>> + /* Remember parents stderr only if the fork option is set.
>>
> The comment could use some grammar help (s/parents/parent's/), and in
> truth, I don't think it adds much beyond what the code itself is already
> doing, so rather than adding another line to silence patchew, you could
> instead just eliminate the comment and life would still be fine. Or if
> you want a one-line comment, I might suggest:
>
> /* Remember parent's stderr if we will restoring it. */
It helps if I don't hit 'send' too early.
/* Remember parent's stderr if we will be restoring it. */
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-05-14 15:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1jYr2L-0004mc-Jj@mail.hetzner.company>
2020-05-14 6:31 ` [PATCH v2 0/1] qemu-nbd: Close inherited stderr Raphael Pour
2020-05-14 6:31 ` [PATCH v2 1/1] " Raphael Pour
2020-05-14 12:51 ` [PATCH v2 0/1] " no-reply
2020-05-14 14:29 ` Eric Blake
2020-05-14 14:55 ` Eric Blake [this message]
2020-05-15 6:36 ` Raphael Pour
2020-05-15 17:31 ` Eric Blake
2020-05-14 6:35 ` Raphael Pour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=661abf79-c560-3d2f-b377-3d4535b6691f@redhat.com \
--to=eblake@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=raphael.pour@hetzner.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.