From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFA4EC433B4 for ; Mon, 19 Apr 2021 21:21:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95A96611F0 for ; Mon, 19 Apr 2021 21:21:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95A96611F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYbKV-0005NO-He for qemu-devel@archiver.kernel.org; Mon, 19 Apr 2021 17:21:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38524) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYajP-0002sd-38 for qemu-devel@nongnu.org; Mon, 19 Apr 2021 16:42:55 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:51971) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lYajN-0002Mu-33 for qemu-devel@nongnu.org; Mon, 19 Apr 2021 16:42:54 -0400 Received: by mail-wm1-x334.google.com with SMTP id z6so1131267wmg.1 for ; Mon, 19 Apr 2021 13:42:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=dMT7YHA0gkC0JknwKDiVLa22QnPnnRvrAvwd8nyxGtk=; b=jgUeYAR3kgI5XaG41mTCXj8KwMYLf6LbYkkfylzUGrOYpDMX+cY3Oy5edE1jlCS1G3 41n7nM+afoBofNhSYXsZ/lEQcW0m5kw5KQEPohv8bWcmKP/eKpTUF/9jfYN9jJLgn6jN 55qkJlOl6jH0NUNsupjnbAjTDmu03ECTYfUnaYH5HZ865YvSR+d2Y0qGGLaHHpItjdFU TbsntbHG/+YaM7vyEr0zcM93nZKv/2u3XdPvxDgwk+CMbHwSkm/FGaDSwJ8sjjLz57O/ yWD+ZhlMcsaBCIhgKcvzDeV5g5iFyJB7kBbwLwJLU5Z+rQET0mXWe9QJWZJVFP9nt7kf isfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dMT7YHA0gkC0JknwKDiVLa22QnPnnRvrAvwd8nyxGtk=; b=rfyzIUHFONgexQ/zmocPgzJXYX7VXmQy9y/iArKrzZodCNWYC0ri9t21mR/2+Hl3rF LSex/SjoSnZoPRdw+XB3vGOBj+FVfnWRnj1gjsRRMFi7vvWspnPGL5BS5dpSn5E92qlt f1foQaeEeSMFtzR3sIdh5iP3mil4e/MvX569WmVkbKbEvuPFPquXUkfYNZcINxk7djC4 57joXXVbffBgz8jo3z3voU7iMJaaTqlR186+l2bfbdwTc2Yy4DdANyfPb7fTEdVkJWw2 Cta/xesyS8iIgJrqNs5/G+tYeYxIwXJH54Wr2lzuH9BVTusvOAxpA8U0MpdDTRVZ7rFq GzCg== X-Gm-Message-State: AOAM532ZLsH9bPJHrx3wVwEJOJg3ruLTGGe4MzPilvU6TEs4hPVjsYI4 e8fDim/2sz25i2q9KS/C0xA= X-Google-Smtp-Source: ABdhPJxabyzaZtrZNWr6o1IqC/VhkR6ssyG/Xil/kc5Ecx+phB5/pn3MmV428hZeqdhmYWcde+RqDg== X-Received: by 2002:a7b:c8cf:: with SMTP id f15mr836661wml.135.1618864971601; Mon, 19 Apr 2021 13:42:51 -0700 (PDT) Received: from [192.168.1.36] (39.red-81-40-121.staticip.rima-tde.net. [81.40.121.39]) by smtp.gmail.com with ESMTPSA id s10sm24256085wrt.23.2021.04.19.13.42.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Apr 2021 13:42:51 -0700 (PDT) Subject: Re: [PATCH v3 08/30] target/mips: Declare mips_cpu_set_error_pc() inlined in "internal.h" To: Richard Henderson , qemu-devel@nongnu.org References: <20210419191823.1555482-1-f4bug@amsat.org> <20210419191823.1555482-9-f4bug@amsat.org> <5ff019aa-00c5-f600-eb2a-4c8d3e3a0dd1@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <6643eb6f-ab02-c66e-7689-20864f93565f@amsat.org> Date: Mon, 19 Apr 2021 22:42:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <5ff019aa-00c5-f600-eb2a-4c8d3e3a0dd1@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x334.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , Huacai Chen , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/19/21 9:27 PM, Richard Henderson wrote: > On 4/19/21 12:18 PM, Philippe Mathieu-Daudé wrote: >> Rename set_pc() as mips_cpu_set_error_pc(), declare it inlined >> and use it in cpu.c and op_helper.c. > > Why "error_pc"?  The usage in mips_cpu_set_pc certainly isn't in > response to any kind of error... Indeed, but I couldn't find any good name. mips_cpu_set_pc() is already taken, as is cpu_set_pc(): static void mips_cpu_set_pc(CPUState *cs, vaddr value) mips_cpu_state_set_pc() maybe?