From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755879AbdJPQbV (ORCPT ); Mon, 16 Oct 2017 12:31:21 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:59730 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756085AbdJPQaf (ORCPT ); Mon, 16 Oct 2017 12:30:35 -0400 Subject: Re: [RFC 00/19] KVM: s390/crypto/vfio: guest dedicated crypto adapters To: Christian Borntraeger , Martin Schwidefsky Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, freude@de.ibm.com, heiko.carstens@de.ibm.com, cohuck@redhat.com, kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com, alex.williamson@redhat.com, pmorel@linux.vnet.ibm.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, qemu-s390x@nongnu.org, jjherne@linux.vnet.ibm.com, thuth@redhat.com, pasic@linux.vnet.ibm.com References: <1507916344-3896-1-git-send-email-akrowiak@linux.vnet.ibm.com> <20171016112755.4d6b3ea1@mschwideX1> From: Tony Krowiak Date: Mon, 16 Oct 2017 12:30:28 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 17101616-2213-0000-0000-0000022C90CC X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007899; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000236; SDB=6.00932013; UDB=6.00469302; IPR=6.00712302; BA=6.00005641; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017560; XFM=3.00000015; UTC=2017-10-16 16:30:33 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17101616-2214-0000-0000-000057DFAF8D Message-Id: <66490023-ade1-8cac-962f-da0038c26c4d@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-16_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710160230 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/2017 06:06 AM, Christian Borntraeger wrote: > > On 10/16/2017 11:27 AM, Martin Schwidefsky wrote: >> On Fri, 13 Oct 2017 13:38:45 -0400 >> Tony Krowiak wrote: >> >>> Tony Krowiak (19): >>> KVM: s390: SIE considerations for AP Queue virtualization >>> KVM: s390: refactor crypto initialization >>> s390/zcrypt: new AP matrix bus >>> s390/zcrypt: create an AP matrix device on the AP matrix bus >>> s390/zcrypt: base implementation of AP matrix device driver >>> s390/zcrypt: register matrix device with VFIO mediated device >>> framework >>> KVM: s390: introduce AP matrix configuration interface >>> s390/zcrypt: support for assigning adapters to matrix mdev >>> s390/zcrypt: validate adapter assignment >>> s390/zcrypt: sysfs interfaces supporting AP domain assignment >>> s390/zcrypt: validate domain assignment >>> s390/zcrypt: sysfs support for control domain assignment >>> s390/zcrypt: validate control domain assignment >>> KVM: s390: Connect the AP mediated matrix device to KVM >>> s390/zcrypt: introduce ioctl access to VFIO AP Matrix driver >>> KVM: s390: interface to configure KVM guest's AP matrix >>> KVM: s390: validate input to AP matrix config interface >>> KVM: s390: New ioctl to configure KVM guest's AP matrix >>> s390/facilities: enable AP facilities needed by guest >> Overall I am quite happy with the patches, only minor things I would >> like to see improved. We have to agree how we want to approach the >> upstream process between my s390/linux tree and the s390/kvm tree. >> Probably a tip branch again for the both tress to pull from. > Thanks a lot for the review of the zcrypt patches. Its very good to know > that these base changes are ok with you. > > Regarding merging: yes, this should be a tip branch then. Before that, we > have to finalize the interface and design to make sure that the changes > will work throughout the whole stack (kvm/vfio/qemu/libvirt). I would also like to add my thank you for the review comments. I am currently debugging the QEMU code I've written and Farhan Ali is in the review process for the libvirt component. > > >