From: Sagi Grimberg <sagi@grimberg.me>
To: amit.engel@dell.com, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvmet: return Invalid Field error on set features cmd fid 07h
Date: Fri, 28 Feb 2020 12:33:26 -0800 [thread overview]
Message-ID: <6653e6ab-0fb4-7cb9-e759-eecaef4eddbd@grimberg.me> (raw)
In-Reply-To: <20200228125214.100729-1-amit.engel@dell.com>
> From: Amit Engel <amit.engel@dell.com>
>
> If the value specified in NCQR and NSQR fields (0's based) is 65,535
> the controller should return an error of Invalid field in command
>
> Signed-off-by: Amit Engel <Amit.Engel@dell.com>
> ---
> drivers/nvme/target/admin-cmd.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
> index 19f949570625..94b0ac923e99 100644
> --- a/drivers/nvme/target/admin-cmd.c
> +++ b/drivers/nvme/target/admin-cmd.c
> @@ -733,6 +733,9 @@ static void nvmet_execute_set_features(struct nvmet_req *req)
> {
> struct nvmet_subsys *subsys = req->sq->ctrl->subsys;
> u32 cdw10 = le32_to_cpu(req->cmd->common.cdw10);
> + u32 cdw11 = le32_to_cpu(req->cmd->common.cdw11);
> + u16 ncqr = (cdw11 >> 16) & 0xffff;
> + u16 nsqr = cdw11 & 0xffff;
I meant that here we only declare, assignment should go to where these
are used.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-02-28 20:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 12:52 [PATCH] nvmet: return Invalid Field error on set features cmd fid 07h amit.engel
2020-02-28 20:33 ` Sagi Grimberg [this message]
2020-03-01 0:30 ` Chaitanya Kulkarni
2020-03-01 4:47 ` Engel, Amit
-- strict thread matches above, loose matches on Subject: below --
2020-02-27 14:16 amit.engel
2020-02-27 23:16 ` Sagi Grimberg
2020-02-28 12:53 ` Engel, Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6653e6ab-0fb4-7cb9-e759-eecaef4eddbd@grimberg.me \
--to=sagi@grimberg.me \
--cc=amit.engel@dell.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.