From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10008C4363D for ; Thu, 24 Sep 2020 14:20:20 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99868221EB for ; Thu, 24 Sep 2020 14:20:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99868221EB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ACULAB.COM Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=containers-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 331D6874FE; Thu, 24 Sep 2020 14:20:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Lb6wIKvTqO7U; Thu, 24 Sep 2020 14:20:18 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 8A652874F6; Thu, 24 Sep 2020 14:20:18 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 768B8C0859; Thu, 24 Sep 2020 14:20:18 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id B1C53C0051 for ; Thu, 24 Sep 2020 14:20:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id AD54A874F6 for ; Thu, 24 Sep 2020 14:20:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8ki7RCka-jr1 for ; Thu, 24 Sep 2020 14:20:15 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [207.82.80.151]) by hemlock.osuosl.org (Postfix) with ESMTPS id E003A874E0 for ; Thu, 24 Sep 2020 14:20:14 +0000 (UTC) Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-218-ndXhimk2PgyG-5cmTZlPGg-1; Thu, 24 Sep 2020 15:20:10 +0100 X-MC-Unique: ndXhimk2PgyG-5cmTZlPGg-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Thu, 24 Sep 2020 15:20:09 +0100 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Thu, 24 Sep 2020 15:20:09 +0100 From: David Laight To: 'YiFei Zhu' Subject: RE: [PATCH v2 seccomp 2/6] asm/syscall.h: Add syscall_arches[] array Thread-Topic: [PATCH v2 seccomp 2/6] asm/syscall.h: Add syscall_arches[] array Thread-Index: AQHWknD17ZW/yCPmvkCTJZb3HlQhMal3ymow///6ngCAABEUAA== Date: Thu, 24 Sep 2020 14:20:09 +0000 Message-ID: <665ea57e360a421c958fffa08da77920@AcuMS.aculab.com> References: <20bbc8ed4b9f2c83d0f67f37955eb2d789268525.1600951211.git.yifeifz2@illinois.edu> <7042ba3307b34ce3b95e5fede823514e@AcuMS.aculab.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Cc: Andrea Arcangeli , Giuseppe Scrivano , Valentin Rothberg , Kees Cook , Jann Horn , YiFei Zhu , "containers@lists.linux-foundation.org" , Tobin Feldman-Fitzthum , "linux-kernel@vger.kernel.org" , Andy Lutomirski , Hubertus Franke , Jack Chen , Dimitrios Skarlatos , Josep Torrellas , Will Drewry , "bpf@vger.kernel.org" , Tianyin Xu X-BeenThere: containers@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux Containers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: containers-bounces@lists.linux-foundation.org Sender: "Containers" From: YiFei Zhu > Sent: 24 September 2020 15:17 > > On Thu, Sep 24, 2020 at 8:47 AM David Laight wrote: > > I doubt the compiler will do what you want. > > Looking at it, in most cases there are one or two entries. > > I think only MIPS has three. > > It does ;) GCC 10.2.0: > > $ objdump -d kernel/seccomp.o | less > [...] > 0000000000001520 <__seccomp_filter>: > [...] > 1587: 41 8b 54 24 04 mov 0x4(%r12),%edx > 158c: b9 08 01 00 00 mov $0x108,%ecx > 1591: 81 fa 3e 00 00 c0 cmp $0xc000003e,%edx > 1597: 75 2e jne 15c7 <__seccomp_filter+0xa7> > [...] > 15c7: 81 fa 03 00 00 40 cmp $0x40000003,%edx > 15cd: b9 40 01 00 00 mov $0x140,%ecx > 15d2: 74 c5 je 1599 <__seccomp_filter+0x79> > 15d4: 0f 0b ud2 > [...] > 0000000000001cb0 : > [...] > 1cc4: 41 b9 3e 00 00 c0 mov $0xc000003e,%r9d > [...] > 1dba: 41 b9 03 00 00 40 mov $0x40000003,%r9d > [...] > 0000000000002e30 : > [...] > 2e72: ba 3e 00 00 c0 mov $0xc000003e,%edx > [...] > 2eb5: ba 03 00 00 40 mov $0x40000003,%edx > > Granted, I have CC_OPTIMIZE_FOR_PERFORMANCE rather than > CC_OPTIMIZE_FOR_SIZE, but this patch itself is trying to sacrifice > some of the memory for speed. Don't both CC_OPTIMIZE_FOR_PERFORMANCE (-??) and CC_OPTIMIZE_FOR_SIZE (-s) generate terrible code? Try with a slghtly older gcc. I think that entire optimisation (discarding const arrays) is very recent. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) _______________________________________________ Containers mailing list Containers@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/containers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CF7BC4363D for ; Thu, 24 Sep 2020 14:20:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 444CA206B6 for ; Thu, 24 Sep 2020 14:20:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728230AbgIXOUP (ORCPT ); Thu, 24 Sep 2020 10:20:15 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([207.82.80.151]:59810 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727974AbgIXOUO (ORCPT ); Thu, 24 Sep 2020 10:20:14 -0400 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-218-ndXhimk2PgyG-5cmTZlPGg-1; Thu, 24 Sep 2020 15:20:10 +0100 X-MC-Unique: ndXhimk2PgyG-5cmTZlPGg-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Thu, 24 Sep 2020 15:20:09 +0100 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Thu, 24 Sep 2020 15:20:09 +0100 From: David Laight To: 'YiFei Zhu' CC: "containers@lists.linux-foundation.org" , YiFei Zhu , "bpf@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Aleksa Sarai , "Andrea Arcangeli" , Andy Lutomirski , Dimitrios Skarlatos , Giuseppe Scrivano , Hubertus Franke , Jack Chen , Jann Horn , Josep Torrellas , Kees Cook , Tianyin Xu , Tobin Feldman-Fitzthum , Tycho Andersen , Valentin Rothberg , Will Drewry Subject: RE: [PATCH v2 seccomp 2/6] asm/syscall.h: Add syscall_arches[] array Thread-Topic: [PATCH v2 seccomp 2/6] asm/syscall.h: Add syscall_arches[] array Thread-Index: AQHWknD17ZW/yCPmvkCTJZb3HlQhMal3ymow///6ngCAABEUAA== Date: Thu, 24 Sep 2020 14:20:09 +0000 Message-ID: <665ea57e360a421c958fffa08da77920@AcuMS.aculab.com> References: <20bbc8ed4b9f2c83d0f67f37955eb2d789268525.1600951211.git.yifeifz2@illinois.edu> <7042ba3307b34ce3b95e5fede823514e@AcuMS.aculab.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org RnJvbTogWWlGZWkgWmh1DQo+IFNlbnQ6IDI0IFNlcHRlbWJlciAyMDIwIDE1OjE3DQo+IA0KPiBP biBUaHUsIFNlcCAyNCwgMjAyMCBhdCA4OjQ3IEFNIERhdmlkIExhaWdodCA8RGF2aWQuTGFpZ2h0 QGFjdWxhYi5jb20+IHdyb3RlOg0KPiA+IEkgZG91YnQgdGhlIGNvbXBpbGVyIHdpbGwgZG8gd2hh dCB5b3Ugd2FudC4NCj4gPiBMb29raW5nIGF0IGl0LCBpbiBtb3N0IGNhc2VzIHRoZXJlIGFyZSBv bmUgb3IgdHdvIGVudHJpZXMuDQo+ID4gSSB0aGluayBvbmx5IE1JUFMgaGFzIHRocmVlLg0KPiAN Cj4gSXQgZG9lcyA7KSBHQ0MgMTAuMi4wOg0KPiANCj4gJCBvYmpkdW1wIC1kIGtlcm5lbC9zZWNj b21wLm8gfCBsZXNzDQo+IFsuLi5dDQo+IDAwMDAwMDAwMDAwMDE1MjAgPF9fc2VjY29tcF9maWx0 ZXI+Og0KPiBbLi4uXQ0KPiAgICAgMTU4NzogICAgICAgNDEgOGIgNTQgMjQgMDQgICAgICAgICAg bW92ICAgIDB4NCglcjEyKSwlZWR4DQo+ICAgICAxNThjOiAgICAgICBiOSAwOCAwMSAwMCAwMCAg ICAgICAgICBtb3YgICAgJDB4MTA4LCVlY3gNCj4gICAgIDE1OTE6ICAgICAgIDgxIGZhIDNlIDAw IDAwIGMwICAgICAgIGNtcCAgICAkMHhjMDAwMDAzZSwlZWR4DQo+ICAgICAxNTk3OiAgICAgICA3 NSAyZSAgICAgICAgICAgICAgICAgICBqbmUgICAgMTVjNyA8X19zZWNjb21wX2ZpbHRlcisweGE3 Pg0KPiBbLi4uXQ0KPiAgICAgMTVjNzogICAgICAgODEgZmEgMDMgMDAgMDAgNDAgICAgICAgY21w ICAgICQweDQwMDAwMDAzLCVlZHgNCj4gICAgIDE1Y2Q6ICAgICAgIGI5IDQwIDAxIDAwIDAwICAg ICAgICAgIG1vdiAgICAkMHgxNDAsJWVjeA0KPiAgICAgMTVkMjogICAgICAgNzQgYzUgICAgICAg ICAgICAgICAgICAgamUgICAgIDE1OTkgPF9fc2VjY29tcF9maWx0ZXIrMHg3OT4NCj4gICAgIDE1 ZDQ6ICAgICAgIDBmIDBiICAgICAgICAgICAgICAgICAgIHVkMg0KPiBbLi4uXQ0KPiAwMDAwMDAw MDAwMDAxY2IwIDxzZWNjb21wX2NhY2hlX3ByZXBhcmU+Og0KPiBbLi4uXQ0KPiAgICAgMWNjNDog ICAgICAgNDEgYjkgM2UgMDAgMDAgYzAgICAgICAgbW92ICAgICQweGMwMDAwMDNlLCVyOWQNCj4g Wy4uLl0NCj4gICAgIDFkYmE6ICAgICAgIDQxIGI5IDAzIDAwIDAwIDQwICAgICAgIG1vdiAgICAk MHg0MDAwMDAwMywlcjlkDQo+IFsuLi5dDQo+IDAwMDAwMDAwMDAwMDJlMzAgPHByb2NfcGlkX3Nl Y2NvbXBfY2FjaGU+Og0KPiBbLi4uXQ0KPiAgICAgMmU3MjogICAgICAgYmEgM2UgMDAgMDAgYzAg ICAgICAgICAgbW92ICAgICQweGMwMDAwMDNlLCVlZHgNCj4gWy4uLl0NCj4gICAgIDJlYjU6ICAg ICAgIGJhIDAzIDAwIDAwIDQwICAgICAgICAgIG1vdiAgICAkMHg0MDAwMDAwMywlZWR4DQo+IA0K PiBHcmFudGVkLCBJIGhhdmUgQ0NfT1BUSU1JWkVfRk9SX1BFUkZPUk1BTkNFIHJhdGhlciB0aGFu DQo+IENDX09QVElNSVpFX0ZPUl9TSVpFLCBidXQgdGhpcyBwYXRjaCBpdHNlbGYgaXMgdHJ5aW5n IHRvIHNhY3JpZmljZQ0KPiBzb21lIG9mIHRoZSBtZW1vcnkgZm9yIHNwZWVkLg0KDQpEb24ndCBi b3RoIENDX09QVElNSVpFX0ZPUl9QRVJGT1JNQU5DRSAoLT8/KSBhbmQgQ0NfT1BUSU1JWkVfRk9S X1NJWkUgKC1zKQ0KZ2VuZXJhdGUgdGVycmlibGUgY29kZT8NCg0KVHJ5IHdpdGggYSBzbGdodGx5 IG9sZGVyIGdjYy4NCkkgdGhpbmsgdGhhdCBlbnRpcmUgb3B0aW1pc2F0aW9uIChkaXNjYXJkaW5n IGNvbnN0IGFycmF5cykNCmlzIHZlcnkgcmVjZW50Lg0KDQoJRGF2aWQNCiANCg0KLQ0KUmVnaXN0 ZXJlZCBBZGRyZXNzIExha2VzaWRlLCBCcmFtbGV5IFJvYWQsIE1vdW50IEZhcm0sIE1pbHRvbiBL ZXluZXMsIE1LMSAxUFQsIFVLDQpSZWdpc3RyYXRpb24gTm86IDEzOTczODYgKFdhbGVzKQ0K