* [PATCH] f2fs: fix use-after-free issue
@ 2020-07-23 10:28 ` Chao Yu
0 siblings, 0 replies; 6+ messages in thread
From: Chao Yu @ 2020-07-23 10:28 UTC (permalink / raw)
To: jaegeuk; +Cc: linux-f2fs-devel, linux-kernel, chao, Li Guifu, Chao Yu
From: Li Guifu <bluce.liguifu@huawei.com>
During umount, f2fs_put_super() unregisters procfs entries after
f2fs_destroy_segment_manager(), it may cause use-after-free
issue when umount races with procfs accessing, fix it by relcating
f2fs_unregister_sysfs().
[Chao Yu: change commit title/message a bit]
Signed-off-by: Li Guifu <bluce.liguifu@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
fs/f2fs/super.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 80cb7cd358f8..bf8bd64c8380 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -1175,6 +1175,9 @@ static void f2fs_put_super(struct super_block *sb)
int i;
bool dropped;
+ /* unregister procfs/sysfs entries to avoid race case */
+ f2fs_unregister_sysfs(sbi);
+
f2fs_quota_off_umount(sb);
/* prevent remaining shrinker jobs */
@@ -1240,8 +1243,6 @@ static void f2fs_put_super(struct super_block *sb)
kvfree(sbi->ckpt);
- f2fs_unregister_sysfs(sbi);
-
sb->s_fs_info = NULL;
if (sbi->s_chksum_driver)
crypto_free_shash(sbi->s_chksum_driver);
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [f2fs-dev] [PATCH] f2fs: fix use-after-free issue
@ 2020-07-23 10:28 ` Chao Yu
0 siblings, 0 replies; 6+ messages in thread
From: Chao Yu @ 2020-07-23 10:28 UTC (permalink / raw)
To: jaegeuk; +Cc: linux-kernel, linux-f2fs-devel
From: Li Guifu <bluce.liguifu@huawei.com>
During umount, f2fs_put_super() unregisters procfs entries after
f2fs_destroy_segment_manager(), it may cause use-after-free
issue when umount races with procfs accessing, fix it by relcating
f2fs_unregister_sysfs().
[Chao Yu: change commit title/message a bit]
Signed-off-by: Li Guifu <bluce.liguifu@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
fs/f2fs/super.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 80cb7cd358f8..bf8bd64c8380 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -1175,6 +1175,9 @@ static void f2fs_put_super(struct super_block *sb)
int i;
bool dropped;
+ /* unregister procfs/sysfs entries to avoid race case */
+ f2fs_unregister_sysfs(sbi);
+
f2fs_quota_off_umount(sb);
/* prevent remaining shrinker jobs */
@@ -1240,8 +1243,6 @@ static void f2fs_put_super(struct super_block *sb)
kvfree(sbi->ckpt);
- f2fs_unregister_sysfs(sbi);
-
sb->s_fs_info = NULL;
if (sbi->s_chksum_driver)
crypto_free_shash(sbi->s_chksum_driver);
--
2.26.2
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re:[f2fs-dev] [PATCH] f2fs: fix use-after-free issue
2020-07-23 10:28 ` [f2fs-dev] " Chao Yu
@ 2020-07-23 15:26 ` Song Feng
-1 siblings, 0 replies; 6+ messages in thread
From: Song Feng @ 2020-07-23 15:26 UTC (permalink / raw)
To: Chao Yu; +Cc: jaegeuk, linux-kernel, linux-f2fs-devel
At 2020-07-23 17:28:06, "Chao Yu" <yuchao0@huawei.com> wrote:
>From: Li Guifu <bluce.liguifu@huawei.com>
>
>During umount, f2fs_put_super() unregisters procfs entries after
>f2fs_destroy_segment_manager(), it may cause use-after-free
>issue when umount races with procfs accessing, fix it by relcating
typo issue: relcating -> relocating?
>f2fs_unregister_sysfs().
>
>[Chao Yu: change commit title/message a bit]
>
>Signed-off-by: Li Guifu <bluce.liguifu@huawei.com>
>Reviewed-by: Chao Yu <yuchao0@huawei.com>
>Signed-off-by: Chao Yu <yuchao0@huawei.com>
>---
> fs/f2fs/super.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
>index 80cb7cd358f8..bf8bd64c8380 100644
>--- a/fs/f2fs/super.c
>+++ b/fs/f2fs/super.c
>@@ -1175,6 +1175,9 @@ static void f2fs_put_super(struct super_block *sb)
> int i;
> bool dropped;
>
>+ /* unregister procfs/sysfs entries to avoid race case */
>+ f2fs_unregister_sysfs(sbi);
>+
> f2fs_quota_off_umount(sb);
>
> /* prevent remaining shrinker jobs */
>@@ -1240,8 +1243,6 @@ static void f2fs_put_super(struct super_block *sb)
>
> kvfree(sbi->ckpt);
>
>- f2fs_unregister_sysfs(sbi);
>-
> sb->s_fs_info = NULL;
> if (sbi->s_chksum_driver)
> crypto_free_shash(sbi->s_chksum_driver);
>--
>2.26.2
>
>
>
>_______________________________________________
>Linux-f2fs-devel mailing list
>Linux-f2fs-devel@lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
please check typo issue for comment: relcating->relocating?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: fix use-after-free issue
@ 2020-07-23 15:26 ` Song Feng
0 siblings, 0 replies; 6+ messages in thread
From: Song Feng @ 2020-07-23 15:26 UTC (permalink / raw)
To: Chao Yu; +Cc: jaegeuk, linux-kernel, linux-f2fs-devel
At 2020-07-23 17:28:06, "Chao Yu" <yuchao0@huawei.com> wrote:
>From: Li Guifu <bluce.liguifu@huawei.com>
>
>During umount, f2fs_put_super() unregisters procfs entries after
>f2fs_destroy_segment_manager(), it may cause use-after-free
>issue when umount races with procfs accessing, fix it by relcating
typo issue: relcating -> relocating?
>f2fs_unregister_sysfs().
>
>[Chao Yu: change commit title/message a bit]
>
>Signed-off-by: Li Guifu <bluce.liguifu@huawei.com>
>Reviewed-by: Chao Yu <yuchao0@huawei.com>
>Signed-off-by: Chao Yu <yuchao0@huawei.com>
>---
> fs/f2fs/super.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
>index 80cb7cd358f8..bf8bd64c8380 100644
>--- a/fs/f2fs/super.c
>+++ b/fs/f2fs/super.c
>@@ -1175,6 +1175,9 @@ static void f2fs_put_super(struct super_block *sb)
> int i;
> bool dropped;
>
>+ /* unregister procfs/sysfs entries to avoid race case */
>+ f2fs_unregister_sysfs(sbi);
>+
> f2fs_quota_off_umount(sb);
>
> /* prevent remaining shrinker jobs */
>@@ -1240,8 +1243,6 @@ static void f2fs_put_super(struct super_block *sb)
>
> kvfree(sbi->ckpt);
>
>- f2fs_unregister_sysfs(sbi);
>-
> sb->s_fs_info = NULL;
> if (sbi->s_chksum_driver)
> crypto_free_shash(sbi->s_chksum_driver);
>--
>2.26.2
>
>
>
>_______________________________________________
>Linux-f2fs-devel mailing list
>Linux-f2fs-devel@lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
please check typo issue for comment: relcating->relocating?
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: fix use-after-free issue
2020-07-23 15:26 ` [f2fs-dev] " Song Feng
@ 2020-07-24 1:22 ` Chao Yu
-1 siblings, 0 replies; 6+ messages in thread
From: Chao Yu @ 2020-07-24 1:22 UTC (permalink / raw)
To: Song Feng; +Cc: jaegeuk, linux-kernel, linux-f2fs-devel
Hi Feng,
Thanks for the reminder. :)
Jaegeuk, could you please fix this while merging.
Thanks,
On 2020/7/23 23:26, Song Feng wrote:
> At 2020-07-23 17:28:06, "Chao Yu" <yuchao0@huawei.com> wrote:
>
>> From: Li Guifu <bluce.liguifu@huawei.com>
>>
>> During umount, f2fs_put_super() unregisters procfs entries after
>> f2fs_destroy_segment_manager(), it may cause use-after-free
>> issue when umount races with procfs accessing, fix it by relcating
> typo issue: relcating -> relocating?
>> f2fs_unregister_sysfs().
>>
>> [Chao Yu: change commit title/message a bit]
>>
>> Signed-off-by: Li Guifu <bluce.liguifu@huawei.com>
>> Reviewed-by: Chao Yu <yuchao0@huawei.com>
>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>> ---
>> fs/f2fs/super.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
>> index 80cb7cd358f8..bf8bd64c8380 100644
>> --- a/fs/f2fs/super.c
>> +++ b/fs/f2fs/super.c
>> @@ -1175,6 +1175,9 @@ static void f2fs_put_super(struct super_block *sb)
>> int i;
>> bool dropped;
>>
>> + /* unregister procfs/sysfs entries to avoid race case */
>> + f2fs_unregister_sysfs(sbi);
>> +
>> f2fs_quota_off_umount(sb);
>>
>> /* prevent remaining shrinker jobs */
>> @@ -1240,8 +1243,6 @@ static void f2fs_put_super(struct super_block *sb)
>>
>> kvfree(sbi->ckpt);
>>
>> - f2fs_unregister_sysfs(sbi);
>> -
>> sb->s_fs_info = NULL;
>> if (sbi->s_chksum_driver)
>> crypto_free_shash(sbi->s_chksum_driver);
>> --
>> 2.26.2
>>
>>
>>
>> _______________________________________________
>> Linux-f2fs-devel mailing list
>> Linux-f2fs-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> please check typo issue for comment: relcating->relocating?
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: fix use-after-free issue
@ 2020-07-24 1:22 ` Chao Yu
0 siblings, 0 replies; 6+ messages in thread
From: Chao Yu @ 2020-07-24 1:22 UTC (permalink / raw)
To: Song Feng; +Cc: jaegeuk, linux-kernel, linux-f2fs-devel
Hi Feng,
Thanks for the reminder. :)
Jaegeuk, could you please fix this while merging.
Thanks,
On 2020/7/23 23:26, Song Feng wrote:
> At 2020-07-23 17:28:06, "Chao Yu" <yuchao0@huawei.com> wrote:
>
>> From: Li Guifu <bluce.liguifu@huawei.com>
>>
>> During umount, f2fs_put_super() unregisters procfs entries after
>> f2fs_destroy_segment_manager(), it may cause use-after-free
>> issue when umount races with procfs accessing, fix it by relcating
> typo issue: relcating -> relocating?
>> f2fs_unregister_sysfs().
>>
>> [Chao Yu: change commit title/message a bit]
>>
>> Signed-off-by: Li Guifu <bluce.liguifu@huawei.com>
>> Reviewed-by: Chao Yu <yuchao0@huawei.com>
>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>> ---
>> fs/f2fs/super.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
>> index 80cb7cd358f8..bf8bd64c8380 100644
>> --- a/fs/f2fs/super.c
>> +++ b/fs/f2fs/super.c
>> @@ -1175,6 +1175,9 @@ static void f2fs_put_super(struct super_block *sb)
>> int i;
>> bool dropped;
>>
>> + /* unregister procfs/sysfs entries to avoid race case */
>> + f2fs_unregister_sysfs(sbi);
>> +
>> f2fs_quota_off_umount(sb);
>>
>> /* prevent remaining shrinker jobs */
>> @@ -1240,8 +1243,6 @@ static void f2fs_put_super(struct super_block *sb)
>>
>> kvfree(sbi->ckpt);
>>
>> - f2fs_unregister_sysfs(sbi);
>> -
>> sb->s_fs_info = NULL;
>> if (sbi->s_chksum_driver)
>> crypto_free_shash(sbi->s_chksum_driver);
>> --
>> 2.26.2
>>
>>
>>
>> _______________________________________________
>> Linux-f2fs-devel mailing list
>> Linux-f2fs-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> please check typo issue for comment: relcating->relocating?
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-24 1:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-23 10:28 [PATCH] f2fs: fix use-after-free issue Chao Yu
2020-07-23 10:28 ` [f2fs-dev] " Chao Yu
2020-07-23 15:26 ` Song Feng
2020-07-23 15:26 ` [f2fs-dev] " Song Feng
2020-07-24 1:22 ` Chao Yu
2020-07-24 1:22 ` Chao Yu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.