[PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

[PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

[Stuart Summers]

To allow easier debug of platforms which do not fully support
power-saving render C-state 6, add back the module parameter
to allow RC6 flows to be disabled. Instead of directly affecting
the RC6 states via a bitmask as done previously, use this module
parameter to clear the has_rc6 field for these platforms.

Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Suggested-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Signed-off-by: Stuart Summers <stuart.summers@intel.com>
---
 drivers/gpu/drm/i915/i915_params.c | 3 +++
 drivers/gpu/drm/i915/i915_params.h | 3 ++-
 drivers/gpu/drm/i915/intel_pm.c    | 3 +++
 3 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index b5be0abbba35..e31406c6821d 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -169,6 +169,9 @@ i915_param_named_unsafe(inject_load_failure, uint, 0400,
 i915_param_named(enable_dpcd_backlight, bool, 0600,
 	"Enable support for DPCD backlight control (default:false)");
 
+i915_param_named_unsafe(enable_rc6, bool, 0400,
+	"Enable power-saving render C-state 6. (default: true)");
+
 #if IS_ENABLED(CONFIG_DRM_I915_GVT)
 i915_param_named(enable_gvt, bool, 0400,
 	"Enable support for Intel GVT-g graphics virtualization host support(default:false)");
diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
index 3f14e9881a0d..28bf4005a610 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm/i915/i915_params.h
@@ -76,7 +76,8 @@ struct drm_printer;
 	param(bool, nuclear_pageflip, false) \
 	param(bool, enable_dp_mst, true) \
 	param(bool, enable_dpcd_backlight, false) \
-	param(bool, enable_gvt, false)
+	param(bool, enable_gvt, false) \
+	param(bool, enable_rc6, true)
 
 #define MEMBER(T, member, ...) T member;
 struct i915_params {
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index decdd79c3805..6b514dd033cb 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -7020,6 +7020,9 @@ static bool sanitize_rc6(struct drm_i915_private *i915)
 {
 	struct intel_device_info *info = mkwrite_device_info(i915);
 
+	if (!i915_modparams.enable_rc6)
+		info->has_rc6 = 0;
+
 	/* Powersaving is controlled by the host when inside a VM */
 	if (intel_vgpu_active(i915)) {
 		info->has_rc6 = 0;
-- 
2.21.0.5.gaeb582a983

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH 2/2] drm/i915: Extend reset modparam to domain resets

[Stuart Summers]

In the event a platform does not properly implement reset,
do not go through reset flows for engine domains to avoid
an unlikely situation where writes are accepted but register
values are never cleared, as this can result in GPU wedges
in these cases.

Signed-off-by: Stuart Summers <stuart.summers@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_reset.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c
index 464369bc55ad..81f9f9f73b1c 100644
--- a/drivers/gpu/drm/i915/gt/intel_reset.c
+++ b/drivers/gpu/drm/i915/gt/intel_reset.c
@@ -309,6 +309,12 @@ static int gen6_hw_domain_reset(struct drm_i915_private *i915,
 	struct intel_uncore *uncore = &i915->uncore;
 	int err;
 
+	if (!i915_modparams.reset) {
+		DRM_DEBUG_DRIVER("Skipping 0x%08x engines reset\n",
+				 hw_domain_mask);
+		return 0;
+	}
+
 	/*
 	 * GEN6_GDRST is not in the gt power well, no need to check
 	 * for fifo space for the write or forcewake the chip for
@@ -517,6 +523,13 @@ static int gen8_engine_reset_prepare(struct intel_engine_cs *engine)
 		return 0;
 	}
 
+	if (!i915_modparams.reset) {
+		DRM_DEBUG_DRIVER("Skipping %s reset request {request: %08x, RESET_CTL: %08x}\n",
+				 engine->name, request,
+				 intel_uncore_read_fw(uncore, reg));
+		return 0;
+	}
+
 	intel_uncore_write_fw(uncore, reg, _MASKED_BIT_ENABLE(request));
 	ret = __intel_wait_for_register_fw(uncore, reg, mask, ack,
 					   700, 0, NULL);
-- 
2.21.0.5.gaeb582a983

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

[Chris Wilson]

Quoting Stuart Summers (2019-05-14 17:46:52)
> To allow easier debug of platforms which do not fully support
> power-saving render C-state 6, add back the module parameter
> to allow RC6 flows to be disabled. Instead of directly affecting
> the RC6 states via a bitmask as done previously, use this module
> parameter to clear the has_rc6 field for these platforms.

If you know which platforms don't support rc6, don't enable rc6.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915: Extend reset modparam to domain resets

[Chris Wilson]

Quoting Stuart Summers (2019-05-14 17:46:53)
> In the event a platform does not properly implement reset,

Then don't enable reset.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915: Extend reset modparam to domain resets

[Summers, Stuart]

[-- Attachment #1.1: Type: text/plain, Size: 426 bytes --]

On Tue, 2019-05-14 at 17:54 +0100, Chris Wilson wrote:
> Quoting Stuart Summers (2019-05-14 17:46:53)
> > In the event a platform does not properly implement reset,
> 
> Then don't enable reset.

Hey Chris,

I'm not sure I fully understand your comment here. The module parameter
is there to do just this. This patch simply extends the usage to apply
to these engine domains as well.

Thanks,
Stuart

> -Chris

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3270 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Re-add enable_rc6 modparam

[Patchwork]

== Series Details ==

Series: series starting with [1/2] drm/i915: Re-add enable_rc6 modparam
URL   : https://patchwork.freedesktop.org/series/60637/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
14d287f37981 drm/i915: Re-add enable_rc6 modparam
-:25: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#25: FILE: drivers/gpu/drm/i915/i915_params.c:173:
+i915_param_named_unsafe(enable_rc6, bool, 0400,
+	"Enable power-saving render C-state 6. (default: true)");

total: 0 errors, 0 warnings, 1 checks, 27 lines checked
ebcadee9c4d2 drm/i915: Extend reset modparam to domain resets

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Re-add enable_rc6 modparam

[Patchwork]

== Series Details ==

Series: series starting with [1/2] drm/i915: Re-add enable_rc6 modparam
URL   : https://patchwork.freedesktop.org/series/60637/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6081 -> Patchwork_13016
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/

Known issues
------------

  Here are the changes found in Patchwork_13016 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_contexts:
    - fi-skl-gvtdvm:      [PASS][1] -> [DMESG-FAIL][2] ([fdo#110235])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html

  * igt@kms_busy@basic-flip-c:
    - fi-skl-6770hq:      [PASS][3] -> [SKIP][4] ([fdo#109271] / [fdo#109278]) +2 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/fi-skl-6770hq/igt@kms_busy@basic-flip-c.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/fi-skl-6770hq/igt@kms_busy@basic-flip-c.html

  * igt@kms_flip@basic-flip-vs-dpms:
    - fi-skl-6770hq:      [PASS][5] -> [SKIP][6] ([fdo#109271]) +23 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/fi-skl-6770hq/igt@kms_flip@basic-flip-vs-dpms.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/fi-skl-6770hq/igt@kms_flip@basic-flip-vs-dpms.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - fi-blb-e6850:       [PASS][7] -> [INCOMPLETE][8] ([fdo#107718])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/fi-blb-e6850/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/fi-blb-e6850/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html

  
#### Possible fixes ####

  * igt@gem_cpu_reloc@basic:
    - {fi-cml-u}:         [INCOMPLETE][9] -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/fi-cml-u/igt@gem_cpu_reloc@basic.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/fi-cml-u/igt@gem_cpu_reloc@basic.html

  * igt@i915_selftest@live_hangcheck:
    - fi-icl-u2:          [INCOMPLETE][11] ([fdo#107713] / [fdo#108569]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/fi-icl-u2/igt@i915_selftest@live_hangcheck.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/fi-icl-u2/igt@i915_selftest@live_hangcheck.html
    - fi-skl-iommu:       [INCOMPLETE][13] ([fdo#108602] / [fdo#108744]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/fi-skl-iommu/igt@i915_selftest@live_hangcheck.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/fi-skl-iommu/igt@i915_selftest@live_hangcheck.html
    - {fi-icl-y}:         [INCOMPLETE][15] ([fdo#107713] / [fdo#108569]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/fi-icl-y/igt@i915_selftest@live_hangcheck.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/fi-icl-y/igt@i915_selftest@live_hangcheck.html
    - {fi-icl-dsi}:       [INCOMPLETE][17] ([fdo#107713] / [fdo#108569]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/fi-icl-dsi/igt@i915_selftest@live_hangcheck.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/fi-icl-dsi/igt@i915_selftest@live_hangcheck.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
  [fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
  [fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235


Participating hosts (53 -> 45)
------------------------------

  Missing    (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-bwr-2160 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_6081 -> Patchwork_13016

  CI_DRM_6081: 871d8bc4020bef25e14ea242cf5e73d3372f1f49 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4988: 2f6303d13e09b2457762540383c7f36cecd02bbf @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_13016: ebcadee9c4d270c31872f402be8a6992cb313a0c @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

ebcadee9c4d2 drm/i915: Extend reset modparam to domain resets
14d287f37981 drm/i915: Re-add enable_rc6 modparam

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

[Summers, Stuart]

[-- Attachment #1.1: Type: text/plain, Size: 925 bytes --]

On Tue, 2019-05-14 at 17:53 +0100, Chris Wilson wrote:
> Quoting Stuart Summers (2019-05-14 17:46:52)
> > To allow easier debug of platforms which do not fully support
> > power-saving render C-state 6, add back the module parameter
> > to allow RC6 flows to be disabled. Instead of directly affecting
> > the RC6 states via a bitmask as done previously, use this module
> > parameter to clear the has_rc6 field for these platforms.
> 
> If you know which platforms don't support rc6, don't enable rc6.

I'd really prefer to have this parameter in place for debug purposes.
It seems more useful to allow quick testing by reloading i915 than by
requiring a rebuild.

Of course, once debug is complete and the platform is known to either
not support the feature or has some cripling bug around this, I agree,
rc6 shouldn't be enabled on that platform and i915 should be updated.

Thanks,
Stuart

> -Chris

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3270 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

[Rodrigo Vivi]

On Tue, May 14, 2019 at 06:32:01PM +0000, Summers, Stuart wrote:
> On Tue, 2019-05-14 at 17:53 +0100, Chris Wilson wrote:
> > Quoting Stuart Summers (2019-05-14 17:46:52)
> > > To allow easier debug of platforms which do not fully support
> > > power-saving render C-state 6, add back the module parameter
> > > to allow RC6 flows to be disabled. Instead of directly affecting
> > > the RC6 states via a bitmask as done previously, use this module
> > > parameter to clear the has_rc6 field for these platforms.
> > 
> > If you know which platforms don't support rc6, don't enable rc6.
> 
> I'd really prefer to have this parameter in place for debug purposes.
> It seems more useful to allow quick testing by reloading i915 than by
> requiring a rebuild.
> 
> Of course, once debug is complete and the platform is known to either
> not support the feature or has some cripling bug around this, I agree,
> rc6 shouldn't be enabled on that platform and i915 should be updated.

Exactly. We need the flexibility for debug that.
unfortunately using debugfs doesn't look a solution.

One possibility that just came to my mind now is, what if we make
this only for platforms that are still protected by is_alpha_support=1
(soon becoming require_force_probe=1)

But this is just one side of the coin... when product is out there
and we want the user to debug the issue to see if it is a RC6 bug
we have no way to verify that. :/

Please let's add this back one way or another.

Thanks,
Rodrigo.

> 
> Thanks,
> Stuart
> 
> > -Chris



> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Re-add enable_rc6 modparam

[Patchwork]

== Series Details ==

Series: series starting with [1/2] drm/i915: Re-add enable_rc6 modparam
URL   : https://patchwork.freedesktop.org/series/60637/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_6081_full -> Patchwork_13016_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_13016_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_13016_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_13016_full:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_mocs_settings@mocs-settings-render:
    - shard-iclb:         [PASS][1] -> [SKIP][2] +3 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-iclb1/igt@gem_mocs_settings@mocs-settings-render.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-iclb7/igt@gem_mocs_settings@mocs-settings-render.html

  
#### Warnings ####

  * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
    - shard-iclb:         [SKIP][3] ([fdo#109274]) -> [SKIP][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-iclb1/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-iclb7/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html

  * igt@kms_psr@psr2_suspend:
    - shard-iclb:         [SKIP][5] ([fdo#109441]) -> [SKIP][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-iclb1/igt@kms_psr@psr2_suspend.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-iclb7/igt@kms_psr@psr2_suspend.html

  
Known issues
------------

  Here are the changes found in Patchwork_13016_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_eio@hibernate:
    - shard-iclb:         [PASS][7] -> [INCOMPLETE][8] ([fdo#107713]) +1 similar issue
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-iclb6/igt@gem_eio@hibernate.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-iclb1/igt@gem_eio@hibernate.html

  * igt@gem_eio@suspend:
    - shard-kbl:          [PASS][9] -> [INCOMPLETE][10] ([fdo#103665]) +1 similar issue
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-kbl4/igt@gem_eio@suspend.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-kbl1/igt@gem_eio@suspend.html
    - shard-apl:          [PASS][11] -> [INCOMPLETE][12] ([fdo#103927]) +1 similar issue
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-apl7/igt@gem_eio@suspend.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-apl1/igt@gem_eio@suspend.html
    - shard-skl:          [PASS][13] -> [INCOMPLETE][14] ([fdo#104108])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-skl6/igt@gem_eio@suspend.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-skl1/igt@gem_eio@suspend.html
    - shard-glk:          [PASS][15] -> [INCOMPLETE][16] ([fdo#103359] / [k.org#198133]) +1 similar issue
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-glk6/igt@gem_eio@suspend.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-glk7/igt@gem_eio@suspend.html

  * igt@i915_pm_rpm@gem-mmap-cpu:
    - shard-skl:          [PASS][17] -> [INCOMPLETE][18] ([fdo#107807])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-skl7/igt@i915_pm_rpm@gem-mmap-cpu.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-skl6/igt@i915_pm_rpm@gem-mmap-cpu.html

  * igt@kms_draw_crc@fill-fb:
    - shard-skl:          [PASS][19] -> [FAIL][20] ([fdo#103184])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-skl1/igt@kms_draw_crc@fill-fb.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-skl9/igt@kms_draw_crc@fill-fb.html

  * igt@kms_flip@flip-vs-expired-vblank:
    - shard-glk:          [PASS][21] -> [FAIL][22] ([fdo#102887] / [fdo#105363])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-glk5/igt@kms_flip@flip-vs-expired-vblank.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-glk4/igt@kms_flip@flip-vs-expired-vblank.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt:
    - shard-iclb:         [PASS][23] -> [FAIL][24] ([fdo#103167]) +2 similar issues
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
    - shard-apl:          [PASS][25] -> [DMESG-WARN][26] ([fdo#108566]) +1 similar issue
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-apl5/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-apl5/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html

  * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
    - shard-skl:          [PASS][27] -> [FAIL][28] ([fdo#108145] / [fdo#110403])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-skl8/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html

  * igt@kms_psr2_su@frontbuffer:
    - shard-iclb:         [PASS][29] -> [SKIP][30] ([fdo#109642])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-iclb5/igt@kms_psr2_su@frontbuffer.html

  * igt@kms_psr@psr2_cursor_plane_onoff:
    - shard-iclb:         [PASS][31] -> [SKIP][32] ([fdo#109441]) +3 similar issues
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-iclb3/igt@kms_psr@psr2_cursor_plane_onoff.html

  
#### Possible fixes ####

  * igt@gem_mmap_gtt@forked-medium-copy-xy:
    - shard-iclb:         [TIMEOUT][33] ([fdo#109673]) -> [PASS][34]
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-iclb8/igt@gem_mmap_gtt@forked-medium-copy-xy.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-iclb3/igt@gem_mmap_gtt@forked-medium-copy-xy.html

  * igt@i915_pm_rpm@dpms-mode-unset-lpsp:
    - shard-skl:          [INCOMPLETE][35] ([fdo#107807]) -> [PASS][36] +3 similar issues
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-skl1/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-skl10/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
    - shard-iclb:         [FAIL][37] ([fdo#103167]) -> [PASS][38] +4 similar issues
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu:
    - shard-iclb:         [SKIP][39] -> [PASS][40] +47 similar issues
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-iclb8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-iclb8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu.html

  * igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
    - shard-iclb:         [SKIP][41] ([fdo#109278]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-iclb8/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-iclb8/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html

  * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
    - shard-skl:          [FAIL][43] ([fdo#108145]) -> [PASS][44] +2 similar issues
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html

  * igt@kms_plane_lowres@pipe-a-tiling-y:
    - shard-iclb:         [FAIL][45] ([fdo#103166]) -> [PASS][46]
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-y.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-y.html

  * igt@kms_psr@psr2_cursor_mmap_cpu:
    - shard-iclb:         [SKIP][47] ([fdo#109441]) -> [PASS][48] +1 similar issue
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-iclb1/igt@kms_psr@psr2_cursor_mmap_cpu.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html

  * igt@kms_vblank@pipe-c-ts-continuation-suspend:
    - shard-apl:          [DMESG-WARN][49] ([fdo#108566]) -> [PASS][50] +10 similar issues
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-apl6/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-apl8/igt@kms_vblank@pipe-c-ts-continuation-suspend.html

  
#### Warnings ####

  * igt@i915_pm_lpsp@edp-native:
    - shard-iclb:         [SKIP][51] -> [SKIP][52] ([fdo#109301])
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-iclb8/igt@i915_pm_lpsp@edp-native.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-iclb8/igt@i915_pm_lpsp@edp-native.html

  * igt@kms_atomic_transition@4x-modeset-transitions-nonblocking-fencing:
    - shard-iclb:         [SKIP][53] -> [SKIP][54] ([fdo#109278]) +1 similar issue
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-iclb8/igt@kms_atomic_transition@4x-modeset-transitions-nonblocking-fencing.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-iclb8/igt@kms_atomic_transition@4x-modeset-transitions-nonblocking-fencing.html

  * igt@kms_chamelium@hdmi-hpd-storm-disable:
    - shard-iclb:         [SKIP][55] -> [SKIP][56] ([fdo#109284])
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-iclb8/igt@kms_chamelium@hdmi-hpd-storm-disable.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-iclb8/igt@kms_chamelium@hdmi-hpd-storm-disable.html

  * igt@kms_flip@2x-dpms-vs-vblank-race:
    - shard-iclb:         [SKIP][57] -> [SKIP][58] ([fdo#109274]) +1 similar issue
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-iclb8/igt@kms_flip@2x-dpms-vs-vblank-race.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-iclb8/igt@kms_flip@2x-dpms-vs-vblank-race.html

  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-pgflip-blt:
    - shard-iclb:         [SKIP][59] -> [SKIP][60] ([fdo#109280]) +5 similar issues
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-pgflip-blt.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-pgflip-blt.html

  * igt@kms_psr@psr2_sprite_blt:
    - shard-iclb:         [SKIP][61] -> [SKIP][62] ([fdo#109441]) +1 similar issue
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6081/shard-iclb8/igt@kms_psr@psr2_sprite_blt.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/shard-iclb8/igt@kms_psr@psr2_sprite_blt.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
  [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
  [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
  [fdo#109301]: https://bugs.freedesktop.org/show_bug.cgi?id=109301
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
  [fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673
  [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
  [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133


Participating hosts (10 -> 10)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * Linux: CI_DRM_6081 -> Patchwork_13016

  CI_DRM_6081: 871d8bc4020bef25e14ea242cf5e73d3372f1f49 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4988: 2f6303d13e09b2457762540383c7f36cecd02bbf @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_13016: ebcadee9c4d270c31872f402be8a6992cb313a0c @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13016/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

[Tvrtko Ursulin]

On 15/05/2019 01:06, Rodrigo Vivi wrote:
> On Tue, May 14, 2019 at 06:32:01PM +0000, Summers, Stuart wrote:
>> On Tue, 2019-05-14 at 17:53 +0100, Chris Wilson wrote:
>>> Quoting Stuart Summers (2019-05-14 17:46:52)
>>>> To allow easier debug of platforms which do not fully support
>>>> power-saving render C-state 6, add back the module parameter
>>>> to allow RC6 flows to be disabled. Instead of directly affecting
>>>> the RC6 states via a bitmask as done previously, use this module
>>>> parameter to clear the has_rc6 field for these platforms.
>>>
>>> If you know which platforms don't support rc6, don't enable rc6.
>>
>> I'd really prefer to have this parameter in place for debug purposes.
>> It seems more useful to allow quick testing by reloading i915 than by
>> requiring a rebuild.
>>
>> Of course, once debug is complete and the platform is known to either
>> not support the feature or has some cripling bug around this, I agree,
>> rc6 shouldn't be enabled on that platform and i915 should be updated.
> 
> Exactly. We need the flexibility for debug that.
> unfortunately using debugfs doesn't look a solution.
> 
> One possibility that just came to my mind now is, what if we make
> this only for platforms that are still protected by is_alpha_support=1
> (soon becoming require_force_probe=1)
> 
> But this is just one side of the coin... when product is out there
> and we want the user to debug the issue to see if it is a RC6 bug
> we have no way to verify that. :/
> 
> Please let's add this back one way or another.

To throw a compromise option out there - add the modparam for debug 
builds only (CONFIG_DRM_I915_DEBUG)?

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

[Summers, Stuart]

[-- Attachment #1.1: Type: text/plain, Size: 2054 bytes --]

On Wed, 2019-05-15 at 06:43 +0100, Tvrtko Ursulin wrote:
> On 15/05/2019 01:06, Rodrigo Vivi wrote:
> > On Tue, May 14, 2019 at 06:32:01PM +0000, Summers, Stuart wrote:
> > > On Tue, 2019-05-14 at 17:53 +0100, Chris Wilson wrote:
> > > > Quoting Stuart Summers (2019-05-14 17:46:52)
> > > > > To allow easier debug of platforms which do not fully support
> > > > > power-saving render C-state 6, add back the module parameter
> > > > > to allow RC6 flows to be disabled. Instead of directly
> > > > > affecting
> > > > > the RC6 states via a bitmask as done previously, use this
> > > > > module
> > > > > parameter to clear the has_rc6 field for these platforms.
> > > > 
> > > > If you know which platforms don't support rc6, don't enable
> > > > rc6.
> > > 
> > > I'd really prefer to have this parameter in place for debug
> > > purposes.
> > > It seems more useful to allow quick testing by reloading i915
> > > than by
> > > requiring a rebuild.
> > > 
> > > Of course, once debug is complete and the platform is known to
> > > either
> > > not support the feature or has some cripling bug around this, I
> > > agree,
> > > rc6 shouldn't be enabled on that platform and i915 should be
> > > updated.
> > 
> > Exactly. We need the flexibility for debug that.
> > unfortunately using debugfs doesn't look a solution.
> > 
> > One possibility that just came to my mind now is, what if we make
> > this only for platforms that are still protected by
> > is_alpha_support=1
> > (soon becoming require_force_probe=1)
> > 
> > But this is just one side of the coin... when product is out there
> > and we want the user to debug the issue to see if it is a RC6 bug
> > we have no way to verify that. :/
> > 
> > Please let's add this back one way or another.
> 
> To throw a compromise option out there - add the modparam for debug 
> builds only (CONFIG_DRM_I915_DEBUG)?

No issues here, and makes sense. If we have concensus, I'd be happy to
add this and repost.

-Stuart

> 
> Regards,
> 
> Tvrtko

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3270 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

[Jani Nikula]

On Tue, 14 May 2019, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> One possibility that just came to my mind now is, what if we make
> this only for platforms that are still protected by is_alpha_support=1
> (soon becoming require_force_probe=1)

Please don't conflate alpha_support or force_probe with *anything* else.

> But this is just one side of the coin... when product is out there
> and we want the user to debug the issue to see if it is a RC6 bug
> we have no way to verify that. :/

The problem is, if it works with rc6 disabled, it doesn't prove it's an
rc6 bug either.


BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

[Summers, Stuart]

[-- Attachment #1.1: Type: text/plain, Size: 1140 bytes --]

On Thu, 2019-05-16 at 12:59 +0300, Jani Nikula wrote:
> On Tue, 14 May 2019, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> > One possibility that just came to my mind now is, what if we make
> > this only for platforms that are still protected by
> > is_alpha_support=1
> > (soon becoming require_force_probe=1)
> 
> Please don't conflate alpha_support or force_probe with *anything*
> else.
> 
> > But this is just one side of the coin... when product is out there
> > and we want the user to debug the issue to see if it is a RC6 bug
> > we have no way to verify that. :/
> 
> The problem is, if it works with rc6 disabled, it doesn't prove it's
> an
> rc6 bug either.

Good point. I'm not saying we should enforce a process of disabling RC6
for the platform if enable_rc6=0 results in success. I'm just saying
having the option is useful from a debug perspective. We will still
need to do the appropriate full analysis, including the normal code
review process on a pre-case basis when debug involves this parameter.
But the parameter itself is still useful.

Thanks,
Stuart

> 
> 
> BR,
> Jani.
> 
> 

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3270 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

[Jani Nikula]

On Thu, 16 May 2019, "Summers, Stuart" <stuart.summers@intel.com> wrote:
> On Thu, 2019-05-16 at 12:59 +0300, Jani Nikula wrote:
>> On Tue, 14 May 2019, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
>> > One possibility that just came to my mind now is, what if we make
>> > this only for platforms that are still protected by
>> > is_alpha_support=1
>> > (soon becoming require_force_probe=1)
>> 
>> Please don't conflate alpha_support or force_probe with *anything*
>> else.
>> 
>> > But this is just one side of the coin... when product is out there
>> > and we want the user to debug the issue to see if it is a RC6 bug
>> > we have no way to verify that. :/
>> 
>> The problem is, if it works with rc6 disabled, it doesn't prove it's
>> an
>> rc6 bug either.
>
> Good point. I'm not saying we should enforce a process of disabling RC6
> for the platform if enable_rc6=0 results in success. I'm just saying
> having the option is useful from a debug perspective. We will still
> need to do the appropriate full analysis, including the normal code
> review process on a pre-case basis when debug involves this parameter.
> But the parameter itself is still useful.

The trouble starts when users figure out that enable_rc6=0 works around
a particular problem they have (likely by way of disabling runtime pm,
not directly related to rc6). You could argue this is a good thing, but
unfortunately we generally never hear from them again, and the root
cause remains unsolved, with degraded user experience wrt power
management.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

[Summers, Stuart]

[-- Attachment #1.1: Type: text/plain, Size: 2251 bytes --]

On Thu, 2019-05-16 at 18:42 +0300, Jani Nikula wrote:
> On Thu, 16 May 2019, "Summers, Stuart" <stuart.summers@intel.com>
> wrote:
> > On Thu, 2019-05-16 at 12:59 +0300, Jani Nikula wrote:
> > > On Tue, 14 May 2019, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> > > > One possibility that just came to my mind now is, what if we
> > > > make
> > > > this only for platforms that are still protected by
> > > > is_alpha_support=1
> > > > (soon becoming require_force_probe=1)
> > > 
> > > Please don't conflate alpha_support or force_probe with
> > > *anything*
> > > else.
> > > 
> > > > But this is just one side of the coin... when product is out
> > > > there
> > > > and we want the user to debug the issue to see if it is a RC6
> > > > bug
> > > > we have no way to verify that. :/
> > > 
> > > The problem is, if it works with rc6 disabled, it doesn't prove
> > > it's
> > > an
> > > rc6 bug either.
> > 
> > Good point. I'm not saying we should enforce a process of disabling
> > RC6
> > for the platform if enable_rc6=0 results in success. I'm just
> > saying
> > having the option is useful from a debug perspective. We will still
> > need to do the appropriate full analysis, including the normal code
> > review process on a pre-case basis when debug involves this
> > parameter.
> > But the parameter itself is still useful.
> 
> The trouble starts when users figure out that enable_rc6=0 works
> around
> a particular problem they have (likely by way of disabling runtime
> pm,
> not directly related to rc6). You could argue this is a good thing,
> but
> unfortunately we generally never hear from them again, and the root
> cause remains unsolved, with degraded user experience wrt power
> management.

So I understand the reasoning here, and agree that isn't an ideal
situation. I'd also like a way to debug more efficiently. What did you
think about the suggestion from Tvrtko to only apply on
CONFIG_DRM_I915_DEBUG?

Or we could even wrap this entirely with a CONFIG_I915_DEBUG_PM -
although I'd like to suggest we still use the module parameter, we
could just use the config option to hide the modparam under normal
operation.

Thanks,
Stuart

> 
> BR,
> Jani.
> 
> 

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3270 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

[Rodrigo Vivi]

On Thu, May 16, 2019 at 03:49:19PM +0000, Summers, Stuart wrote:
> On Thu, 2019-05-16 at 18:42 +0300, Jani Nikula wrote:
> > On Thu, 16 May 2019, "Summers, Stuart" <stuart.summers@intel.com>
> > wrote:
> > > On Thu, 2019-05-16 at 12:59 +0300, Jani Nikula wrote:
> > > > On Tue, 14 May 2019, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> > > > > One possibility that just came to my mind now is, what if we
> > > > > make
> > > > > this only for platforms that are still protected by
> > > > > is_alpha_support=1
> > > > > (soon becoming require_force_probe=1)
> > > > 
> > > > Please don't conflate alpha_support or force_probe with
> > > > *anything*
> > > > else.
> > > > 
> > > > > But this is just one side of the coin... when product is out
> > > > > there
> > > > > and we want the user to debug the issue to see if it is a RC6
> > > > > bug
> > > > > we have no way to verify that. :/
> > > > 
> > > > The problem is, if it works with rc6 disabled, it doesn't prove
> > > > it's
> > > > an
> > > > rc6 bug either.

Well, RC6 is the main GT power gating. The issue could be on may other
individual power gating, but if by disabling RC6 the issue is gone
it is a very good indication that it is a GT-PM bug somewhere.

> > > 
> > > Good point. I'm not saying we should enforce a process of disabling
> > > RC6
> > > for the platform if enable_rc6=0 results in success. I'm just
> > > saying
> > > having the option is useful from a debug perspective. We will still
> > > need to do the appropriate full analysis, including the normal code
> > > review process on a pre-case basis when debug involves this
> > > parameter.
> > > But the parameter itself is still useful.
> > 
> > The trouble starts when users figure out that enable_rc6=0 works
> > around
> > a particular problem they have (likely by way of disabling runtime
> > pm,
> > not directly related to rc6). You could argue this is a good thing,
> > but
> > unfortunately we generally never hear from them again, and the root
> > cause remains unsolved, with degraded user experience wrt power
> > management.

This is indeed bad. We should probably be clear that by disabling that
they are draining their power and probably killing battery life.

> 
> So I understand the reasoning here, and agree that isn't an ideal
> situation. I'd also like a way to debug more efficiently. What did you
> think about the suggestion from Tvrtko to only apply on
> CONFIG_DRM_I915_DEBUG?

if debug is on and parameter is set, right? Might be a good thing to
avoid the abuse on the parameter.

> 
> Or we could even wrap this entirely with a CONFIG_I915_DEBUG_PM -
> although I'd like to suggest we still use the module parameter, we
> could just use the config option to hide the modparam under normal
> operation.

I think this looks more like you are enabling more logs and
not that you are disabling... unless the plan is to go with
this flag plus logs and traces around PM. Than I think it is
a good idea.

Same rules needs to apply to  RC6, RPM, DC states,
display power well management, psr, etc.

Thanks,
Rodrigo.

> 
> Thanks,
> Stuart
> 
> > 
> > BR,
> > Jani.
> > 
> > 



> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

[Ville Syrjälä]

On Fri, May 17, 2019 at 09:17:39AM -0700, Rodrigo Vivi wrote:
> On Thu, May 16, 2019 at 03:49:19PM +0000, Summers, Stuart wrote:
> > On Thu, 2019-05-16 at 18:42 +0300, Jani Nikula wrote:
> > > On Thu, 16 May 2019, "Summers, Stuart" <stuart.summers@intel.com>
> > > wrote:
> > > > On Thu, 2019-05-16 at 12:59 +0300, Jani Nikula wrote:
> > > > > On Tue, 14 May 2019, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> > > > > > One possibility that just came to my mind now is, what if we
> > > > > > make
> > > > > > this only for platforms that are still protected by
> > > > > > is_alpha_support=1
> > > > > > (soon becoming require_force_probe=1)
> > > > > 
> > > > > Please don't conflate alpha_support or force_probe with
> > > > > *anything*
> > > > > else.
> > > > > 
> > > > > > But this is just one side of the coin... when product is out
> > > > > > there
> > > > > > and we want the user to debug the issue to see if it is a RC6
> > > > > > bug
> > > > > > we have no way to verify that. :/
> > > > > 
> > > > > The problem is, if it works with rc6 disabled, it doesn't prove
> > > > > it's
> > > > > an
> > > > > rc6 bug either.
> 
> Well, RC6 is the main GT power gating. The issue could be on may other
> individual power gating, but if by disabling RC6 the issue is gone
> it is a very good indication that it is a GT-PM bug somewhere.

I disagree. In the recent past enable_rc6 was often used by
people to workaround display underruns and whatnot.

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

[Rodrigo Vivi]

On Fri, May 17, 2019 at 07:34:23PM +0300, Ville Syrjälä wrote:
> On Fri, May 17, 2019 at 09:17:39AM -0700, Rodrigo Vivi wrote:
> > On Thu, May 16, 2019 at 03:49:19PM +0000, Summers, Stuart wrote:
> > > On Thu, 2019-05-16 at 18:42 +0300, Jani Nikula wrote:
> > > > On Thu, 16 May 2019, "Summers, Stuart" <stuart.summers@intel.com>
> > > > wrote:
> > > > > On Thu, 2019-05-16 at 12:59 +0300, Jani Nikula wrote:
> > > > > > On Tue, 14 May 2019, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> > > > > > > One possibility that just came to my mind now is, what if we
> > > > > > > make
> > > > > > > this only for platforms that are still protected by
> > > > > > > is_alpha_support=1
> > > > > > > (soon becoming require_force_probe=1)
> > > > > > 
> > > > > > Please don't conflate alpha_support or force_probe with
> > > > > > *anything*
> > > > > > else.
> > > > > > 
> > > > > > > But this is just one side of the coin... when product is out
> > > > > > > there
> > > > > > > and we want the user to debug the issue to see if it is a RC6
> > > > > > > bug
> > > > > > > we have no way to verify that. :/
> > > > > > 
> > > > > > The problem is, if it works with rc6 disabled, it doesn't prove
> > > > > > it's
> > > > > > an
> > > > > > rc6 bug either.
> > 
> > Well, RC6 is the main GT power gating. The issue could be on may other
> > individual power gating, but if by disabling RC6 the issue is gone
> > it is a very good indication that it is a GT-PM bug somewhere.
> 
> I disagree. In the recent past enable_rc6 was often used by
> people to workaround display underruns and whatnot.

o.O
do you mean this was being used as a placebo? or real issue?
or something like by keeping rc6 gpu was keeping the power request
to punit high so display was receiving enough power to not strugle
with wm? or something like that or what?

> 
> -- 
> Ville Syrjälä
> Intel
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

[Ville Syrjälä]

On Fri, May 17, 2019 at 09:44:46AM -0700, Rodrigo Vivi wrote:
> On Fri, May 17, 2019 at 07:34:23PM +0300, Ville Syrjälä wrote:
> > On Fri, May 17, 2019 at 09:17:39AM -0700, Rodrigo Vivi wrote:
> > > On Thu, May 16, 2019 at 03:49:19PM +0000, Summers, Stuart wrote:
> > > > On Thu, 2019-05-16 at 18:42 +0300, Jani Nikula wrote:
> > > > > On Thu, 16 May 2019, "Summers, Stuart" <stuart.summers@intel.com>
> > > > > wrote:
> > > > > > On Thu, 2019-05-16 at 12:59 +0300, Jani Nikula wrote:
> > > > > > > On Tue, 14 May 2019, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> > > > > > > > One possibility that just came to my mind now is, what if we
> > > > > > > > make
> > > > > > > > this only for platforms that are still protected by
> > > > > > > > is_alpha_support=1
> > > > > > > > (soon becoming require_force_probe=1)
> > > > > > > 
> > > > > > > Please don't conflate alpha_support or force_probe with
> > > > > > > *anything*
> > > > > > > else.
> > > > > > > 
> > > > > > > > But this is just one side of the coin... when product is out
> > > > > > > > there
> > > > > > > > and we want the user to debug the issue to see if it is a RC6
> > > > > > > > bug
> > > > > > > > we have no way to verify that. :/
> > > > > > > 
> > > > > > > The problem is, if it works with rc6 disabled, it doesn't prove
> > > > > > > it's
> > > > > > > an
> > > > > > > rc6 bug either.
> > > 
> > > Well, RC6 is the main GT power gating. The issue could be on may other
> > > individual power gating, but if by disabling RC6 the issue is gone
> > > it is a very good indication that it is a GT-PM bug somewhere.
> > 
> > I disagree. In the recent past enable_rc6 was often used by
> > people to workaround display underruns and whatnot.
> 
> o.O
> do you mean this was being used as a placebo? or real issue?
> or something like by keeping rc6 gpu was keeping the power request
> to punit high so display was receiving enough power to not strugle
> with wm? or something like that or what?

Disabling rc6 disables most package C-states, which makes life
a lot easier for the display engine due to reduced memory
access latencies.

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

[Summers, Stuart]

[-- Attachment #1.1: Type: text/plain, Size: 4433 bytes --]

On Fri, 2019-05-17 at 09:17 -0700, Rodrigo Vivi wrote:
> On Thu, May 16, 2019 at 03:49:19PM +0000, Summers, Stuart wrote:
> > On Thu, 2019-05-16 at 18:42 +0300, Jani Nikula wrote:
> > > On Thu, 16 May 2019, "Summers, Stuart" <stuart.summers@intel.com>
> > > wrote:
> > > > On Thu, 2019-05-16 at 12:59 +0300, Jani Nikula wrote:
> > > > > On Tue, 14 May 2019, Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > > > wrote:
> > > > > > One possibility that just came to my mind now is, what if
> > > > > > we
> > > > > > make
> > > > > > this only for platforms that are still protected by
> > > > > > is_alpha_support=1
> > > > > > (soon becoming require_force_probe=1)
> > > > > 
> > > > > Please don't conflate alpha_support or force_probe with
> > > > > *anything*
> > > > > else.
> > > > > 
> > > > > > But this is just one side of the coin... when product is
> > > > > > out
> > > > > > there
> > > > > > and we want the user to debug the issue to see if it is a
> > > > > > RC6
> > > > > > bug
> > > > > > we have no way to verify that. :/
> > > > > 
> > > > > The problem is, if it works with rc6 disabled, it doesn't
> > > > > prove
> > > > > it's
> > > > > an
> > > > > rc6 bug either.
> 
> Well, RC6 is the main GT power gating. The issue could be on may
> other
> individual power gating, but if by disabling RC6 the issue is gone
> it is a very good indication that it is a GT-PM bug somewhere.
> 
> > > > 
> > > > Good point. I'm not saying we should enforce a process of
> > > > disabling
> > > > RC6
> > > > for the platform if enable_rc6=0 results in success. I'm just
> > > > saying
> > > > having the option is useful from a debug perspective. We will
> > > > still
> > > > need to do the appropriate full analysis, including the normal
> > > > code
> > > > review process on a pre-case basis when debug involves this
> > > > parameter.
> > > > But the parameter itself is still useful.
> > > 
> > > The trouble starts when users figure out that enable_rc6=0 works
> > > around
> > > a particular problem they have (likely by way of disabling
> > > runtime
> > > pm,
> > > not directly related to rc6). You could argue this is a good
> > > thing,
> > > but
> > > unfortunately we generally never hear from them again, and the
> > > root
> > > cause remains unsolved, with degraded user experience wrt power
> > > management.
> 
> This is indeed bad. We should probably be clear that by disabling
> that
> they are draining their power and probably killing battery life.

I could add a DRM_ERROR or even a GEM_WARN_ON if this is set with a
description similar to what you have if that's interesting.

> 
> > 
> > So I understand the reasoning here, and agree that isn't an ideal
> > situation. I'd also like a way to debug more efficiently. What did
> > you
> > think about the suggestion from Tvrtko to only apply on
> > CONFIG_DRM_I915_DEBUG?
> 
> if debug is on and parameter is set, right? Might be a good thing to
> avoid the abuse on the parameter.
> 
> > 
> > Or we could even wrap this entirely with a CONFIG_I915_DEBUG_PM -
> > although I'd like to suggest we still use the module parameter, we
> > could just use the config option to hide the modparam under normal
> > operation.
> 
> I think this looks more like you are enabling more logs and
> not that you are disabling... unless the plan is to go with
> this flag plus logs and traces around PM. Than I think it is
> a good idea.

I'm not precluding people from adding more logs here - and there will
at least be some additional logs indicating we are bypassing the PM
flows. But at least for this patch, the intention would be to add new
"debug capability", which in this case, means the addition of the new
module parameter, enable_rc6.

Really this is just an extra deterent for users, since they'll need to
custom build the kernel to get this - not something enabled by default
in one of the distros, for instance.

Thanks,
Stuart

> 
> Same rules needs to apply to  RC6, RPM, DC states,
> display power well management, psr, etc.
> 
> Thanks,
> Rodrigo.
> 
> > 
> > Thanks,
> > Stuart
> > 
> > > 
> > > BR,
> > > Jani.
> > > 
> > > 
> 
> 
> 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> 

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3270 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx