From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: use inline kernel-doc for uapi constants
Date: Sat, 21 Oct 2017 13:46:49 +0200 [thread overview]
Message-ID: <6677419.eTnXb6rzk9@sven-edge> (raw)
In-Reply-To: <20171021094546.8299-1-sven@narfation.org>
[-- Attachment #1: Type: text/plain, Size: 579 bytes --]
On Samstag, 21. Oktober 2017 11:45:46 CEST Sven Eckelmann wrote:
[...]
> +
> + /**
> + * @BATADV_CMD_GET_GATEWAYS: Query list of gateways
> + */
> BATADV_CMD_GET_GATEWAYS,
Just wanted to mention that this could also have been written [1] as:
/** @BATADV_CMD_GET_GATEWAYS: Query list of gateways */
I was just lazy and formatted everything as multiline comment instead of
checking whether any of the entries would fit in a single line comment.
Kind regards,
Sven
[1] https://www.kernel.org/doc/html/v4.11/doc-guide/kernel-doc.html#in-line-member-documentation-comments
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-10-21 11:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-21 9:45 [B.A.T.M.A.N.] [PATCH] batman-adv: use inline kernel-doc for uapi constants Sven Eckelmann
2017-10-21 11:46 ` Sven Eckelmann [this message]
2017-10-23 15:21 ` Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6677419.eTnXb6rzk9@sven-edge \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.