From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>,
Julien Grall <julien.grall@arm.com>,
Jan Beulich <jbeulich@suse.com>,
Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH v2 1/2] xen: add interface for obtaining .config from hypervisor
Date: Fri, 15 Mar 2019 15:55:13 +0000 [thread overview]
Message-ID: <667b2ee6-fc6f-64e6-5977-2c69a9d97a95@citrix.com> (raw)
In-Reply-To: <20190314115937.26394-2-jgross@suse.com>
On 14/03/2019 11:59, Juergen Gross wrote:
> @@ -1100,6 +1100,20 @@ typedef struct xen_sysctl_cpu_policy xen_sysctl_cpu_policy_t;
> DEFINE_XEN_GUEST_HANDLE(xen_sysctl_cpu_policy_t);
> #endif
>
> +/*
> + * XEN_SYSCTL_get_config
> + *
> + * Return gzip-ed .config file
I don't think it is wise to bake gzip into the API. These days, there
really are better options than gzip both in terms of compression ratio
and decompress speed.
I'd suggest just saying "file may be compressed" and leave it up to the
packagers build system and `xl` choices to agree on which compression
(if any) to use.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-03-15 16:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 11:59 [PATCH v2 0/2] add xl command to get hypervisor .config Juergen Gross
2019-03-14 11:59 ` [PATCH v2 1/2] xen: add interface for obtaining .config from hypervisor Juergen Gross
2019-03-14 12:27 ` Wei Liu
2019-03-15 13:57 ` Jan Beulich
[not found] ` <5C8BAF5A020000780021F53D@suse.com>
2019-03-15 14:01 ` Juergen Gross
2019-03-15 14:24 ` Jan Beulich
2019-03-15 15:55 ` Andrew Cooper [this message]
2019-03-15 16:29 ` Juergen Gross
2019-04-04 13:27 ` Wei Liu
2019-04-04 13:35 ` Juergen Gross
2019-08-05 15:07 ` [Xen-devel] " George Dunlap
2019-08-05 15:12 ` Juergen Gross
2019-03-15 18:57 ` Daniel De Graaf
2019-03-14 11:59 ` [PATCH v2 2/2] tools: add new xl command get-hypervisor-config Juergen Gross
2019-03-14 12:27 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=667b2ee6-fc6f-64e6-5977-2c69a9d97a95@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.