From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Guo <jia.guo@intel.com>
Subject: Re: [PATCH v12 3/7] bus: add sigbus handler
Date: Thu, 4 Oct 2018 11:14:56 +0800
Message-ID: <667cbd78-9189-1498-b430-3e501836cb19@intel.com>
References: <1498711073-42917-1-git-send-email-jia.guo@intel.com>
 <1538483726-96411-1-git-send-email-jia.guo@intel.com>
 <1538483726-96411-4-git-send-email-jia.guo@intel.com>
 <34b1d516-14b7-876b-7cd9-3854dbc2d0a9@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: jblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org,
 helin.zhang@intel.com
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
 stephen@networkplumber.org, bruce.richardson@intel.com,
 ferruh.yigit@intel.com, konstantin.ananyev@intel.com,
 gaetan.rivet@6wind.com, jingjing.wu@intel.com, thomas@monjalon.net,
 motih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com,
 qi.z.zhang@intel.com, shaopeng.he@intel.com, bernard.iremonger@intel.com,
 arybchenko@solarflare.com, wenzhuo.lu@intel.com,
 jerin.jacob@caviumnetworks.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 044C35F3C
 for <dev@dpdk.org>; Thu,  4 Oct 2018 05:15:01 +0200 (CEST)
In-Reply-To: <34b1d516-14b7-876b-7cd9-3854dbc2d0a9@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On 10/2/2018 10:32 PM, Burakov, Anatoly wrote:
> On 02-Oct-18 1:35 PM, Jeff Guo wrote:
>> When a device is hot-unplugged, a sigbus error will occur of the 
>> datapath
>> can still read/write to the device. A handler is required here to 
>> capture
>> the sigbus signal and handle it appropriately.
>>
>> This patch introduces a bus ops to handle sigbus errors. Each bus can
>> implement its own case-dependent logic to handle the sigbus errors.
>>
>> Signed-off-by: Jeff Guo <jia.guo@intel.com>
>> Acked-by: Shaopeng He <shaopeng.he@intel.com>
>> ---
>> v12->v11:
>> no change.
>> ---
>>   lib/librte_eal/common/include/rte_bus.h | 18 ++++++++++++++++++
>>   1 file changed, 18 insertions(+)
>>
>> diff --git a/lib/librte_eal/common/include/rte_bus.h 
>> b/lib/librte_eal/common/include/rte_bus.h
>> index 1bb53dc..201454a 100644
>> --- a/lib/librte_eal/common/include/rte_bus.h
>> +++ b/lib/librte_eal/common/include/rte_bus.h
>> @@ -182,6 +182,21 @@ typedef int (*rte_bus_parse_t)(const char *name, 
>> void *addr);
>>   typedef int (*rte_bus_hot_unplug_handler_t)(struct rte_device *dev);
>>     /**
>> + * Implement a specific sigbus handler, which is responsible for 
>> handling
>> + * the sigbus error which is either original memory error, or 
>> specific memory
>> + * error that caused of device be hot-unplugged. When sigbus error 
>> be captured,
>> + * it could call this function to handle sigbus error.
>> + * @param failure_addr
>> + *    Pointer of the fault address of the sigbus error.
>> + *
>> + * @return
>> + *    0 for success handle the sigbus.
>> + *    1 for no bus handle the sigbus.
>
> I think the comment here should be reworded. I can't parse "no bus 
> handle the sigbus" - what does that mean, and how is it different from 
> an error?
>

ok, let me detail more.