From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 2/2] net/i40e: add hot plug monitor in i40e Date: Mon, 10 Jul 2017 00:35:59 +0200 Message-ID: <6683978.dxTV7H3Ttm@xps> References: <1498648044-57541-2-git-send-email-jia.guo@intel.com> <7030258.umMgtiJvDN@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, helin.zhang@intel.com, jingjing.wu@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, gaetan.rivet@6wind.com, thomas.monjalon@6wind.com, ferruh.yigit@intel.com To: "Guo, Jia" Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id BD7295599 for ; Mon, 10 Jul 2017 00:36:00 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/07/2017 16:08, Guo, Jia: > > On 7/7/2017 6:17 PM, Thomas Monjalon wrote: > > 07/07/2017 09:56, Thomas Monjalon: > >> 29/06/2017 07:01, Jeff Guo: > >>> --- a/drivers/net/i40e/i40e_ethdev.c > >>> +++ b/drivers/net/i40e/i40e_ethdev.c > >>> @@ -1283,6 +1283,7 @@ static inline void i40e_GLQF_reg_init(struct i40e_hw *hw) > >>> > >>> /* enable uio intr after callback register */ > >>> rte_intr_enable(intr_handle); > >>> + > >>> /* > >>> * Add an ethertype filter to drop all flow control frames transmitted > >>> * from VSIs. By doing so, we stop VF from sending out PAUSE or PFC > >>> @@ -5832,11 +5833,29 @@ struct i40e_vsi * > >>> { > >>> struct rte_eth_dev *dev = (struct rte_eth_dev *)param; > >>> struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private); > >>> + struct rte_uevent event; > >>> uint32_t icr0; > >>> + struct rte_pci_device *pci_dev; > >>> + struct rte_intr_handle *intr_handle; > >>> + > >>> + pci_dev = RTE_ETH_DEV_TO_PCI(dev); > >>> + intr_handle = &pci_dev->intr_handle; > >>> > >>> /* Disable interrupt */ > >>> i40e_pf_disable_irq0(hw); > >>> > >>> + /* check device uevent */ > >>> + if (rte_uevent_get(intr_handle->uevent_fd, &event) == 0) { > >>> + if (event.subsystem == RTE_UEVENT_SUBSYSTEM_UIO) { > >>> + if (event.action == RTE_UEVENT_REMOVE) { > >>> + _rte_eth_dev_callback_process(dev, > >>> + RTE_ETH_EVENT_INTR_RMV, NULL); > >>> + return; > >>> + } > >>> + }if > >>> + goto done; > >>> + } > >> There is nothing specific to i40e in this patch. > >> It seems wrong to add such generic code in every drivers. > > It should be managed at bus layer and not be specific to ethdev only. > if all could managed at bus layer might also be what i want to see, > but that would not so economical at currently. because of the event need > to exposure to driver to use app's callback to handle it by > detach/attach device. mlx driver also go through this path to show the > rmv event usege. we just add uevent for pci uio device. Anyway, i think > the uevent must be useful for future PF/VFIO live migration. if there > are not other concern about the other patch that added uevent api in > eal([PATCH v3 1/2] eal: add uevent api for hot plug), i suggest to merge > it at first. Then we could go next to enhancement it with the 6wind hot > plug feature. Sorry it looks wrong to apply half of this patchset, given we are not sure how the remaining part should be implemented. Let's take time for a better solution and try to gather more opinions. It will be highlighted as one of the next priorities, after the bus rework in progress.