From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10BBEC54EE9 for ; Fri, 16 Sep 2022 10:32:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DrwA3sgS7nRyuVK7TwMtyDYfPHZeqyPEOc/9QIztA4Y=; b=MuQGRRDwdEZSKR SQ3Zla+VQhZ7S3yLQ6fX9rvKsjC+aqYzadcE9mtlETn56ysrxwyQ5QR11RQMpcozYVluOyqYuujIS 9Fg/EOnnpeY3wU+dalWUBDm0rtpgTB2n/dO2QFs+njiUyv5aTjnOkkQuM0fvBGMO0EAoVzLIF50uY xk+C0iwhs/1vC3yYOoDdhvOP/gxHX7mxBRbCYkkJzi8Vo5TgVPyxuz5IQK/0dtT038Hkwjw98ELVY 7uNa2N+OHdR2iMFiAKpuAP6CaBAMhjZu6JFPeTZvj2E2l9U32SUXl9nZY3JH7jneXO+jUTGCf3V6V 0D9rQLOiclPN9LuOBfQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oZ8d7-00CCiL-0S; Fri, 16 Sep 2022 10:31:29 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oZ8bx-00CC2y-56 for linux-arm-kernel@lists.infradead.org; Fri, 16 Sep 2022 10:30:30 +0000 Received: by mail-wm1-x332.google.com with SMTP id az6so15836702wmb.4 for ; Fri, 16 Sep 2022 03:30:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=3pSSbYLsUZVphsAWzkeXxvJouGOGgPDa3BFZ6REzto4=; b=u8x/gpFB48PZ2CVbPWXd89tZdFwnU41LwIPsiCY6fWlNE61ORB4aaNwFhBQA33VcqJ 1rgIMOQhIL7BpbiSm6SxOAE/Jhl4KPdFLkK7FhPlgpqCSTHYTooCLmsZV7fiUTeLtHuJ 2seIzGcFeLlUWwQSb+NW+1vXI+SUydvOSe2zuKQToyp49RczDOykjMVp3jwsGLAosbIP 7w4T+by5xnZok/pnf1td5ZEYjDmbBPDuPYoifV5mJMLDXZTbSDV+74i7zKIEHRQqTDEq 2xcEEXblCkNKih7XRRRnX2mDclvu8bjKfACWz/Y5wXoyxbbW2BK1Vq2n8RLh20rPUIir toLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=3pSSbYLsUZVphsAWzkeXxvJouGOGgPDa3BFZ6REzto4=; b=LHBy/nZBFkHAh4h2ZPv1PLe2/jrGQsRGbw1X4wXFggdjkIYP4f6IFaqDxjzygKJjQs VpEfSuPFrGR01qZNdPiBqEl16/pZhsISjNfu7W0V79RVpy7dePS/pii52wTwKZxvx+n8 iMUzEzRX2o4xiEgmXqDtRIRgNNzDje684PdjF2jbED/ZZRlfnhQuA99cJA4ZAJb9aK6D naJxW5GNxQi61zxTaMjiWhkYQKT2/6LqsFIy9bbGjGx7ZZVkIXzd88+giQ/3tnXBKkg8 lY+OCcoGQDh8hoa0Qb06CFRtdrWDQUm+lldwaY6Rvpm1VaOO2VozXhA/BXa8gs6nSKkB sV6Q== X-Gm-Message-State: ACrzQf1Yo0sFA5goi1ldFDfsI4KpQMujIS3ZYIiL0KWOO3rC9XaMjmxv 4JUGaihIMtR2f5rqjS8F7bimLw== X-Google-Smtp-Source: AMsMyM4OyQkKoo2fuhcDIb/EjBh2hnOfoU1+YHmTYRKnnONgZLG46VxZ2lyHsBWIqlwMI1WUY1go/w== X-Received: by 2002:a7b:c417:0:b0:3b4:5c94:24c1 with SMTP id k23-20020a7bc417000000b003b45c9424c1mr2843337wmi.86.1663324215296; Fri, 16 Sep 2022 03:30:15 -0700 (PDT) Received: from [10.119.22.201] ([89.101.193.73]) by smtp.gmail.com with ESMTPSA id g17-20020a5d5551000000b00228e1e90822sm4679007wrw.112.2022.09.16.03.30.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Sep 2022 03:30:14 -0700 (PDT) Message-ID: <66a057d4-8c52-6a64-c23f-ba4a4428efb5@linaro.org> Date: Fri, 16 Sep 2022 11:30:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 1/2] dt-bindings: firmware: imx: sync with SCFW kit v1.13.0 Content-Language: en-US To: Viorel Suman Cc: Abel Vesa , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Krzysztof Kozlowski , Viorel Suman , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20220915181805.424670-1-viorel.suman@oss.nxp.com> <20220915181805.424670-2-viorel.suman@oss.nxp.com> <42e78db0-74f9-3098-0cf2-908092a0b594@linaro.org> <20220916101738.xn7xx7ipf7p5dbok@fsr-ub1664-116> From: Krzysztof Kozlowski In-Reply-To: <20220916101738.xn7xx7ipf7p5dbok@fsr-ub1664-116> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220916_033017_348296_9DD8557F X-CRM114-Status: GOOD ( 15.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/09/2022 11:17, Viorel Suman wrote: > On 22-09-16 10:38:30, Krzysztof Kozlowski wrote: >> On 15/09/2022 19:18, Viorel Suman (OSS) wrote: >>> From: Viorel Suman >>> >>> Sync defines with the latest available SCFW kit version 1.13.0, >>> may be found at the address below: >>> >>> https://www.nxp.com/webapp/Download?colCode=L5.15.32_2.0.0_SCFWKIT-1.13.0&appType=license >>> >>> Signed-off-by: Viorel Suman >>> --- >>> include/dt-bindings/firmware/imx/rsrc.h | 299 ++++++++++++++++-------- >>> 1 file changed, 203 insertions(+), 96 deletions(-) >>> >>> diff --git a/include/dt-bindings/firmware/imx/rsrc.h b/include/dt-bindings/firmware/imx/rsrc.h >>> index 43885056557c..a4c68f394986 100644 >>> --- a/include/dt-bindings/firmware/imx/rsrc.h >>> +++ b/include/dt-bindings/firmware/imx/rsrc.h >>> @@ -13,34 +13,38 @@ >>> * never be changed or removed (only added to at the end of the list). >>> */ >>> >>> -#define IMX_SC_R_A53 0 >>> -#define IMX_SC_R_A53_0 1 >> >> You cannot change binding constants... Aren't you breaking all possible >> boards and users? > > Hi Krzysztof, > > There is a backward compatibility section added in the end of the patch, > it follows the same approach as in SCFW kit v1.13.0: > > +/* > + * Compatibility defines for sc_rsrc_t > + */ > +#define IMX_SC_R_A35 IMX_SC_R_AP_2 Then it looks fine, except someone would need to compare/test the numbers... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCC64ECAAD8 for ; Fri, 16 Sep 2022 10:51:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229635AbiIPKvo (ORCPT ); Fri, 16 Sep 2022 06:51:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230197AbiIPKvY (ORCPT ); Fri, 16 Sep 2022 06:51:24 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D0A6B5154 for ; Fri, 16 Sep 2022 03:30:19 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id n35-20020a05600c502300b003b4924c6868so670767wmr.1 for ; Fri, 16 Sep 2022 03:30:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=3pSSbYLsUZVphsAWzkeXxvJouGOGgPDa3BFZ6REzto4=; b=u8x/gpFB48PZ2CVbPWXd89tZdFwnU41LwIPsiCY6fWlNE61ORB4aaNwFhBQA33VcqJ 1rgIMOQhIL7BpbiSm6SxOAE/Jhl4KPdFLkK7FhPlgpqCSTHYTooCLmsZV7fiUTeLtHuJ 2seIzGcFeLlUWwQSb+NW+1vXI+SUydvOSe2zuKQToyp49RczDOykjMVp3jwsGLAosbIP 7w4T+by5xnZok/pnf1td5ZEYjDmbBPDuPYoifV5mJMLDXZTbSDV+74i7zKIEHRQqTDEq 2xcEEXblCkNKih7XRRRnX2mDclvu8bjKfACWz/Y5wXoyxbbW2BK1Vq2n8RLh20rPUIir toLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=3pSSbYLsUZVphsAWzkeXxvJouGOGgPDa3BFZ6REzto4=; b=aU7a9b9Q0Vg+9RFi1HfOsXymTrE8/dnW7f1L2vRb4wpeAmeFWSwIrIqjDS9WNNUZKY 5SowKZKKiwyQQpXstFApQXCoxVKDEiOIt+lQXtdUk9Aq9x9pydam3G2HaQX33vAw7bTI 5duo6cALML5ULPvH/lucWSDUNs6IrdCJK/nQnowWRdxbagDUVNiKUt5ayA1YrYuup56P UtQ4B2Peg1o2OcDR9T097D2U/0oL2IEvTRoxk5xGhxym5Oqe4qtPYbKtompOR7dhBC0X 7hooB5fCLba5eED2qKbZ+drdrlKZoIpndq8zbqGxM4E4P7v34zqDso0+4TDLaf3ykMvG +WbA== X-Gm-Message-State: ACrzQf1w5kvaC5FCn/loFmhFDGe5UVvjN+TcTGXktyTpCuqxWyto+ukt OoFk8AzzkgdzWmnn0e6tHx4/vg== X-Google-Smtp-Source: AMsMyM4OyQkKoo2fuhcDIb/EjBh2hnOfoU1+YHmTYRKnnONgZLG46VxZ2lyHsBWIqlwMI1WUY1go/w== X-Received: by 2002:a7b:c417:0:b0:3b4:5c94:24c1 with SMTP id k23-20020a7bc417000000b003b45c9424c1mr2843337wmi.86.1663324215296; Fri, 16 Sep 2022 03:30:15 -0700 (PDT) Received: from [10.119.22.201] ([89.101.193.73]) by smtp.gmail.com with ESMTPSA id g17-20020a5d5551000000b00228e1e90822sm4679007wrw.112.2022.09.16.03.30.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Sep 2022 03:30:14 -0700 (PDT) Message-ID: <66a057d4-8c52-6a64-c23f-ba4a4428efb5@linaro.org> Date: Fri, 16 Sep 2022 11:30:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 1/2] dt-bindings: firmware: imx: sync with SCFW kit v1.13.0 Content-Language: en-US To: Viorel Suman Cc: Abel Vesa , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Krzysztof Kozlowski , Viorel Suman , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20220915181805.424670-1-viorel.suman@oss.nxp.com> <20220915181805.424670-2-viorel.suman@oss.nxp.com> <42e78db0-74f9-3098-0cf2-908092a0b594@linaro.org> <20220916101738.xn7xx7ipf7p5dbok@fsr-ub1664-116> From: Krzysztof Kozlowski In-Reply-To: <20220916101738.xn7xx7ipf7p5dbok@fsr-ub1664-116> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/09/2022 11:17, Viorel Suman wrote: > On 22-09-16 10:38:30, Krzysztof Kozlowski wrote: >> On 15/09/2022 19:18, Viorel Suman (OSS) wrote: >>> From: Viorel Suman >>> >>> Sync defines with the latest available SCFW kit version 1.13.0, >>> may be found at the address below: >>> >>> https://www.nxp.com/webapp/Download?colCode=L5.15.32_2.0.0_SCFWKIT-1.13.0&appType=license >>> >>> Signed-off-by: Viorel Suman >>> --- >>> include/dt-bindings/firmware/imx/rsrc.h | 299 ++++++++++++++++-------- >>> 1 file changed, 203 insertions(+), 96 deletions(-) >>> >>> diff --git a/include/dt-bindings/firmware/imx/rsrc.h b/include/dt-bindings/firmware/imx/rsrc.h >>> index 43885056557c..a4c68f394986 100644 >>> --- a/include/dt-bindings/firmware/imx/rsrc.h >>> +++ b/include/dt-bindings/firmware/imx/rsrc.h >>> @@ -13,34 +13,38 @@ >>> * never be changed or removed (only added to at the end of the list). >>> */ >>> >>> -#define IMX_SC_R_A53 0 >>> -#define IMX_SC_R_A53_0 1 >> >> You cannot change binding constants... Aren't you breaking all possible >> boards and users? > > Hi Krzysztof, > > There is a backward compatibility section added in the end of the patch, > it follows the same approach as in SCFW kit v1.13.0: > > +/* > + * Compatibility defines for sc_rsrc_t > + */ > +#define IMX_SC_R_A35 IMX_SC_R_AP_2 Then it looks fine, except someone would need to compare/test the numbers... Best regards, Krzysztof