From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C037C433E5 for ; Mon, 20 Jul 2020 11:29:14 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE0E122B4D for ; Mon, 20 Jul 2020 11:29:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE0E122B4D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jxTyg-0007KF-Pp; Mon, 20 Jul 2020 11:29:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jxTyf-0007K7-0O for xen-devel@lists.xenproject.org; Mon, 20 Jul 2020 11:29:01 +0000 X-Inumbo-ID: 34bdd1a4-ca7c-11ea-848b-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 34bdd1a4-ca7c-11ea-848b-bc764e2007e4; Mon, 20 Jul 2020 11:29:00 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A90EFAB7A; Mon, 20 Jul 2020 11:29:05 +0000 (UTC) Subject: Re: [PATCH 4/8] Arm: prune #include-s needed by domain.h To: Julien Grall References: <3375cacd-d3b7-9f06-44a7-4b684b6a77d6@suse.com> <150525bb-1c48-c331-3212-eff18bc4c13d@suse.com> <931149db-2daf-6d72-0330-c938b5084eb6@suse.com> <2cc66fdb-1da2-16cd-717a-3248d136821c@xen.org> From: Jan Beulich Message-ID: <66a90945-0d3e-beee-4128-bfc3a06a7cf2@suse.com> Date: Mon, 20 Jul 2020 13:28:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <2cc66fdb-1da2-16cd-717a-3248d136821c@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 20.07.2020 11:09, Julien Grall wrote: > > > On 20/07/2020 09:17, Jan Beulich wrote: >> On 17.07.2020 16:44, Julien Grall wrote: >>> On 15/07/2020 11:39, Jan Beulich wrote: >>>> --- a/xen/include/asm-arm/domain.h >>>> +++ b/xen/include/asm-arm/domain.h >>>> @@ -2,7 +2,7 @@ >>>> #define __ASM_DOMAIN_H__ >>>> >>>> #include >>>> -#include >>>> +#include >>>> #include >>>> #include >>>> #include >>>> @@ -11,8 +11,6 @@ >>>> #include >>>> #include >>>> #include >>>> -#include >>> >>> While we don't need the rbtree.h, we technically need serial.h for using >>> vuart_info. >> >> The only reference to it is >> >> const struct vuart_info *info; >> >> which doesn't require a definition nor even a forward declaration >> of struct vuart_info. It should just be source files instantiating >> a struct or de-referencing pointers to one that actually need to >> see the full declaration. > > Ah yes. I got confused because you introduced a forward declaration of > struct vcpu. But this is because you need it to declare the function > prototype. As a result - are you happy for the change to go in with Stefano's ack then? >> The only source file doing so (vuart.c) >> already includes xen/serial.h. (In fact, it being just a single >> source file doing so, the struct definition could [and imo should] >> be moved there. The type can be entirely opaque to the rest of the >> code base, as - over time - we've been doing for other structs.) > > There are definitely more use of vuart_info within the code base. All > the UART on Arm will fill up the structure (see drivers/char/pl011.c) > for instance. > > So the definition is in the correct place. Hmm, I will admit I judged from the uses of ->arch.vuart.info alone. Jan