All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: Aleksandar Markovic <aleksandar.m.mail@gmail.com>,
	Helge Deller <deller@gmx.de>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] linux-user: Improve strace output for read() and getcwd()
Date: Tue, 26 Nov 2019 09:08:23 +0100	[thread overview]
Message-ID: <66b00f4f-10df-cb1e-b339-49236ad71bee@vivier.eu> (raw)
In-Reply-To: <CAL1e-=itFFWZW9b2B=oL3ZOKOgKq6+TO+f0WU9vWh8pjNY9k0g@mail.gmail.com>

Le 25/11/2019 à 21:54, Aleksandar Markovic a écrit :
>>> 4. NEW PROPOSAL :
>>>
>>> early: read(3,0xff80038c,512)
>>> late: = 512  [(3,"\177ELF\1\2\1\3\0\0\0\0\0\0\0\0\0\3\0\17\0\0\0\1\0\2bl\0\0\04"...,512)]
>>> early: getcwd(0x18180,4096)
>>> late: = 9  [("/usr/bin",4096)]
>>>
>>> In other words, we would print for (selected) system calls content of
>>> the parameters both before and after actual ioctl
>>> translation/execution.
>> I don't like this.
>> IMHO it just adds unnecessary noise and differs from what a native strace shows.
>>
> QEMU strace doesn't have to be the same as native strace. Actually,
> they could be used even at the same time: QEMU provides info on target
> syscall, strace on host syscall. Do not forget that not all syscalls
> are implemeted as one-to-one-correspondence between target and host
> syscalls - combination of QEMU strace and native strace is precious at
> some moments.
> 
> In any case, I think that requiring QEMU strace to look exactly like
> native strace is a self-imposed limitation, that does not have enough
> justification. Think of it, wouldn't it be nice to surpass strace,
> like in these cases above?

I'd like to have a QEMU_STRACE formatting similar to the host strace
formatting because it makes debugging easier: we can run the same
program in guest and host and compare the strace output to see where it
differs and thus where the problem appears.

Thanks,
Laurent


      reply	other threads:[~2019-11-26  8:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-21 20:14 [PATCH] linux-user: Improve strace output for read() and getcwd() Helge Deller
2019-11-21 23:15 ` no-reply
2019-11-23 11:34 ` Aleksandar Markovic
2019-11-24 11:54   ` Helge Deller
2019-11-24 12:10     ` Aleksandar Markovic
2019-11-24 13:04       ` Helge Deller
2019-11-24 13:31         ` Aleksandar Markovic
2019-11-25 13:46           ` Aleksandar Markovic
2019-11-25 20:40             ` Helge Deller
2019-11-25 20:54               ` Aleksandar Markovic
2019-11-26  8:08                 ` Laurent Vivier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66b00f4f-10df-cb1e-b339-49236ad71bee@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=aleksandar.m.mail@gmail.com \
    --cc=deller@gmx.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.