From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yang Xu Date: Thu, 9 Apr 2020 18:14:05 +0800 Subject: [LTP] [PATCH v1 01/10] lapi: Add a configure check and fallback for loop ioctl and flag In-Reply-To: <6bb6bc11-c3c0-48e5-0a67-80b246dfbe4b@suse.cz> References: <1585839990-19923-1-git-send-email-xuyang2018.jy@cn.fujitsu.com> <1585839990-19923-2-git-send-email-xuyang2018.jy@cn.fujitsu.com> <6bb6bc11-c3c0-48e5-0a67-80b246dfbe4b@suse.cz> Message-ID: <66b22f28-b53f-98f9-1021-26dbcfa41091@cn.fujitsu.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi Martin > Hi, > > On 02. 04. 20 17:06, Yang Xu wrote: >> Signed-off-by: Yang Xu >> --- >> configure.ac | 1 + >> include/lapi/loop.h | 35 +++++++++++++++++++++++++++++++++++ >> 2 files changed, 36 insertions(+) >> create mode 100644 include/lapi/loop.h >> >> diff --git a/configure.ac b/configure.ac >> index e1069b57e..e088cb564 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -50,6 +50,7 @@ AC_CHECK_HEADERS([ \ >> linux/if_ether.h \ >> linux/if_packet.h \ >> linux/keyctl.h \ >> + linux/loop.h \ >> linux/mempolicy.h \ >> linux/module.h \ >> linux/netlink.h \ >> diff --git a/include/lapi/loop.h b/include/lapi/loop.h >> new file mode 100644 >> index 000000000..bc6d9950d >> --- /dev/null >> +++ b/include/lapi/loop.h >> @@ -0,0 +1,35 @@ >> +// SPDX-License-Identifier: GPL-2.0-or-later >> +/* >> + * Copyright (c) 2020 FUJITSU LIMITED. All rights reserved. > > Here's a little legal issue for LTP: "GPL" and "All rights reserved" are > mutually exclusive. Those two lines are effectively saying that your > code is both open-source and proprietary at the same time. Please pick > one, or the other. It can't be both. I never think this is a problem before. ltp has some cases also using this style. Also, xfstests have many cases like this. Even kernel, it also has the two line. Is it a problem? Best Regards Yang Xu > >> + * Author: Yang Xu >> + */ >> +#ifndef LAPI_LOOP_H >> +#define LAPI_LOOP_H >> + >> +#include >> +#ifdef HAVE_LINUX_LOOP_H >> +# include >> +#endif >> + >> +#ifndef LO_FLAGS_PARTSCAN >> +# define LO_FLAGS_PARTSCAN 8 >> +#endif >> + >> +#ifndef LO_FLAGS_DIRECT_IO >> +# define LO_FLAGS_DIRECT_IO 16 >> +#endif >> + >> +#ifndef LOOP_SET_CAPACITY >> +# define LOOP_SET_CAPACITY 0x4C07 >> +#endif >> + >> +#ifndef LOOP_SET_DIRECT_IO >> +# define LOOP_SET_DIRECT_IO 0x4C08 >> +#endif >> + >> +#ifndef LOOP_SET_BLOCK_SIZE >> +# define LOOP_SET_BLOCK_SIZE 0x4C09 >> +#endif >> + >> +#endif >> + >> > >