From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH v2] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case Date: Thu, 13 Sep 2018 11:06:26 +0000 Message-ID: <66b6083a08794460b351043133f34bd3@AMSPEX02CL03.citrite.net> References: <5B98D7CF02000078001E7AEA@prv1-mh.provo.novell.com> <5B9A381302000078001E81DC@prv1-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1g0PSH-0002i7-Rl for xen-devel@lists.xenproject.org; Thu, 13 Sep 2018 11:06:37 +0000 In-Reply-To: <5B9A381302000078001E81DC@prv1-mh.provo.novell.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: 'Jan Beulich' , xen-devel Cc: Andrew Cooper List-Id: xen-devel@lists.xenproject.org Cj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiBGcm9tOiBKYW4gQmV1bGljaCBbbWFpbHRv OkpCZXVsaWNoQHN1c2UuY29tXQo+IFNlbnQ6IDEzIFNlcHRlbWJlciAyMDE4IDExOjEzCj4gVG86 IHhlbi1kZXZlbCA8eGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnPgo+IENjOiBBbmRyZXcg Q29vcGVyIDxBbmRyZXcuQ29vcGVyM0BjaXRyaXguY29tPjsgUGF1bCBEdXJyYW50Cj4gPFBhdWwu RHVycmFudEBjaXRyaXguY29tPgo+IFN1YmplY3Q6IFtQQVRDSCB2Ml0geDg2L0hWTTogY29ycmVj dCBodm1lbXVsX21hcF9saW5lYXJfYWRkcigpIGZvciBtdWx0aS0KPiBwYWdlIGNhc2UKPiAKPiBU aGUgZnVuY3Rpb24gZG9lcyB0d28gdHJhbnNsYXRpb25zIGluIG9uZSBnbyBmb3IgYSBzaW5nbGUg Z3Vlc3QgYWNjZXNzLgo+IEFueSBmYWlsdXJlIG9mIHRoZSBmaXJzdCB0cmFuc2xhdGlvbiBzdGVw IChndWVzdCBsaW5lYXIgLT4gZ3Vlc3QKPiBwaHlzaWNhbCksIHJlc3VsdGluZyBpbiAjUEYsIG91 Z2h0IHRvIHRha2UgcHJlY2VkZW5jZSBvdmVyIGFueSBmYWlsdXJlCj4gb2YgdGhlIHNlY29uZCBz dGVwIChndWVzdCBwaHlzaWNhbCAtPiBob3N0IHBoeXNpY2FsKS4gQmFpbCBvdXQgb2YgdGhlCj4g bG9vcCBlYXJseSBzb2xlbHkgd2hlbiB0cmFuc2xhdGlvbiBwcm9kdWNlcyBIVk1UUkFOU19iYWRf bGluZWFyX3RvX2dmbiwKPiBhbmQgcmVjb3JkIHRoZSBtb3N0IHJlbGV2YW50IG9mIHBlcmhhcHMg bXVsdGlwbGUgZGlmZmVyZW50IGVycm9ycwo+IG90aGVyd2lzZS4gKFRoZSBjaG9pY2Ugb2YgWkVS T19CTE9DS19QVFIgYXMgc2VudGluZWwgaXMgYXJiaXRyYXJ5LikKPiAKPiBTaWduZWQtb2ZmLWJ5 OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+Cj4gLS0tCj4gdjI6IEFkZCBjb21tZW50 IChtYXBwaW5nIHRhYmxlKSBhbmQgYWRqdXN0IHVwZGF0ZV9tYXBfZXJyKCkKPiAgICAgYWNjb3Jk aW5nbHkuCj4gCj4gLS0tIGEveGVuL2FyY2gveDg2L2h2bS9lbXVsYXRlLmMKPiArKysgYi94ZW4v YXJjaC94ODYvaHZtL2VtdWxhdGUuYwo+IEBAIC01MzIsNiArNTMyLDM2IEBAIHN0YXRpYyBpbnQg aHZtZW11bF9kb19tbWlvX2FkZHIocGFkZHJfdAo+ICB9Cj4gCj4gIC8qCj4gKyAqIEludGVuZGVk IG1hcHBpbmcsIGltcGxlbWVudGVkIHdpdGhvdXQgdGFibGUgbG9va3VwOgo+ICsgKgo+ICsgKiAt LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICsgKiB8IFwgbmV3IHwg ICAgICAgfCAgICAgICB8ICAgICAgIHwgICAgICAgfAo+ICsgKiB8ICAgXCAgIHwgT0tBWSAgfCBO VUxMICB8IFJFVFJZIHwgVU5ITkQgfAo+ICsgKiB8IGVyciBcIHwgICAgICAgfCAgICAgICB8ICAg ICAgIHwgICAgICAgfAo+ICsgKiAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLQo+ICsgKiB8IE9LQVkgIHwgT0tBWSAgfCBOVUxMICB8IFJFVFJZIHwgVU5ITkQgfAo+ICsg KiAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICsgKiB8IE5VTEwg IHwgTlVMTCAgfCBOVUxMICB8IFJFVFJZIHwgVU5ITkQgfAo+ICsgKiAtLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICsgKiB8IFJFVFJZIHwgUkVUUlkgfCBSRVRSWSB8 IFJFVFJZIHwgVU5ITkQgfAo+ICsgKiAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLQo+ICsgKiB8IFVOSE5EIHwgVU5ITkQgfCBVTkhORCB8IFVOSE5EIHwgVU5ITkQgfAo+ ICsgKiAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICsgKi8KPiAr c3RhdGljIHZvaWQgKnVwZGF0ZV9tYXBfZXJyKHZvaWQgKmVyciwgdm9pZCAqbmV3KQo+ICt7Cj4g KyAgICBpZiAoIGVyciA9PSBaRVJPX0JMT0NLX1BUUiB8fCBlcnIgPT0gRVJSX1BUUih+WDg2RU1V TF9PS0FZKSB8fAo+ICsgICAgICAgICBuZXcgPT0gRVJSX1BUUih+WDg2RU1VTF9VTkhBTkRMRUFC TEUpICkKPiArICAgICAgICByZXR1cm4gbmV3Owo+ICsKPiArICAgIGlmICggbmV3ID09IEVSUl9Q VFIoflg4NkVNVUxfT0tBWSkgfHwKPiArICAgICAgICAgZXJyID09IEVSUl9QVFIoflg4NkVNVUxf VU5IQU5ETEVBQkxFKSApCj4gKyAgICAgICAgcmV0dXJuIGVycjsKPiArCj4gKyAgICByZXR1cm4g ZXJyID86IG5ldzsKClRvb2sgYSB3aGlsZSB0byBjaGVjayBidXQgdGhhdCBsb2dpYyBkb2VzIG1h dGNoIHRoZSB0YWJsZSA6LSkKCj4gK30KPiArCj4gKy8qCj4gICAqIE1hcCB0aGUgZnJhbWUocykg Y292ZXJpbmcgYW4gaW5kaXZpZHVhbCBsaW5lYXIgYWNjZXNzLCBmb3Igd3JpdGVhYmxlCj4gICAq IGFjY2Vzcy4gIE1heSByZXR1cm4gTlVMTCBmb3IgTU1JTywgb3IgRVJSX1BUUih+WDg2RU1VTF8q KSBmb3Igb3RoZXIKPiBlcnJvcnMKPiAgICogaW5jbHVkaW5nIEVSUl9QVFIoflg4NkVNVUxfT0tB WSkgZm9yIHdyaXRlLWRpc2NhcmQgbWFwcGluZ3MuCj4gQEAgLTU0NCw3ICs1NzQsNyBAQCBzdGF0 aWMgdm9pZCAqaHZtZW11bF9tYXBfbGluZWFyX2FkZHIoCj4gICAgICBzdHJ1Y3QgaHZtX2VtdWxh dGVfY3R4dCAqaHZtZW11bF9jdHh0KQo+ICB7Cj4gICAgICBzdHJ1Y3QgdmNwdSAqY3VyciA9IGN1 cnJlbnQ7Cj4gLSAgICB2b2lkICplcnIsICptYXBwaW5nOwo+ICsgICAgdm9pZCAqZXJyID0gWkVS T19CTE9DS19QVFIsICptYXBwaW5nOwoKR2l2ZW4gdGhlIHJldmlzZWQgbG9naWMsIGNhbid0IHlv dSBqdXN0IHN0YXJ0ICplcnIgd2l0aCB0aGUgdmFsdWUgRVJSX1BUUih+WDg2RU1VTF9PS0FZKSBu b3c/IFlvdSBjYW4gdGhlbiBsb3NlIHRoZSBleHRyYSB0ZXN0IGluIHRoZSBmaXJzdCBpZiBvZiB1 cGRhdGVfbWFwX2VycigpLgoKICBQYXVsCgo+ICAgICAgdW5zaWduZWQgaW50IG5yX2ZyYW1lcyA9 ICgobGluZWFyICsgYnl0ZXMgLSAhIWJ5dGVzKSA+PiBQQUdFX1NISUZUKSAtCj4gICAgICAgICAg KGxpbmVhciA+PiBQQUdFX1NISUZUKSArIDE7Cj4gICAgICB1bnNpZ25lZCBpbnQgaTsKPiBAQCAt NjAwLDI3ICs2MzAsMjggQEAgc3RhdGljIHZvaWQgKmh2bWVtdWxfbWFwX2xpbmVhcl9hZGRyKAo+ ICAgICAgICAgICAgICBnb3RvIG91dDsKPiAKPiAgICAgICAgICBjYXNlIEhWTVRSQU5TX2JhZF9n Zm5fdG9fbWZuOgo+IC0gICAgICAgICAgICBlcnIgPSBOVUxMOwo+IC0gICAgICAgICAgICBnb3Rv IG91dDsKPiArICAgICAgICAgICAgZXJyID0gdXBkYXRlX21hcF9lcnIoZXJyLCBOVUxMKTsKPiAr ICAgICAgICAgICAgY29udGludWU7Cj4gCj4gICAgICAgICAgY2FzZSBIVk1UUkFOU19nZm5fcGFn ZWRfb3V0Ogo+ICAgICAgICAgIGNhc2UgSFZNVFJBTlNfZ2ZuX3NoYXJlZDoKPiAtICAgICAgICAg ICAgZXJyID0gRVJSX1BUUih+WDg2RU1VTF9SRVRSWSk7Cj4gLSAgICAgICAgICAgIGdvdG8gb3V0 Owo+ICsgICAgICAgICAgICBlcnIgPSB1cGRhdGVfbWFwX2VycihlcnIsIEVSUl9QVFIoflg4NkVN VUxfUkVUUlkpKTsKPiArICAgICAgICAgICAgY29udGludWU7Cj4gCj4gICAgICAgICAgZGVmYXVs dDoKPiAtICAgICAgICAgICAgZ290byB1bmhhbmRsZWFibGU7Cj4gKyAgICAgICAgICAgIGVyciA9 IHVwZGF0ZV9tYXBfZXJyKGVyciwgRVJSX1BUUih+WDg2RU1VTF9VTkhBTkRMRUFCTEUpKTsKPiAr ICAgICAgICAgICAgY29udGludWU7Cj4gICAgICAgICAgfQo+IAo+ICAgICAgICAgICptZm4rKyA9 IHBhZ2VfdG9fbWZuKHBhZ2UpOwo+IAo+ICAgICAgICAgIGlmICggcDJtX2lzX2Rpc2NhcmRfd3Jp dGUocDJtdCkgKQo+IC0gICAgICAgIHsKPiAtICAgICAgICAgICAgZXJyID0gRVJSX1BUUih+WDg2 RU1VTF9PS0FZKTsKPiAtICAgICAgICAgICAgZ290byBvdXQ7Cj4gLSAgICAgICAgfQo+ICsgICAg ICAgICAgICBlcnIgPSB1cGRhdGVfbWFwX2VycihlcnIsIEVSUl9QVFIoflg4NkVNVUxfT0tBWSkp Owo+ICAgICAgfQo+IAo+ICsgICAgaWYgKCBlcnIgIT0gWkVST19CTE9DS19QVFIgKQo+ICsgICAg ICAgIGdvdG8gb3V0Owo+ICsKPiAgICAgIC8qIEVudGlyZSBhY2Nlc3Mgd2l0aGluIGEgc2luZ2xl IGZyYW1lPyAqLwo+ICAgICAgaWYgKCBucl9mcmFtZXMgPT0gMSApCj4gICAgICAgICAgbWFwcGlu ZyA9IG1hcF9kb21haW5fcGFnZShodm1lbXVsX2N0eHQtPm1mblswXSk7Cj4gQEAgLTYzOSw2ICs2 NzAsNyBAQCBzdGF0aWMgdm9pZCAqaHZtZW11bF9tYXBfbGluZWFyX2FkZHIoCj4gICAgICByZXR1 cm4gbWFwcGluZyArIChsaW5lYXIgJiB+UEFHRV9NQVNLKTsKPiAKPiAgIHVuaGFuZGxlYWJsZToK PiArICAgIEFTU0VSVChlcnIgPT0gWkVST19CTE9DS19QVFIpOwo+ICAgICAgZXJyID0gRVJSX1BU Uih+WDg2RU1VTF9VTkhBTkRMRUFCTEUpOwo+IAo+ICAgb3V0Ogo+IAo+IAo+IAoKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5n IGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJv amVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw=