All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Ziwei Dai <ziwei.dai@unisoc.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the rcu tree
Date: Wed, 5 Apr 2023 15:59:24 -0700	[thread overview]
Message-ID: <66b7fceb-0a9d-42c1-987f-1ac6c857d987@paulmck-laptop> (raw)
In-Reply-To: <20230406083619.65dee33a@canb.auug.org.au>

On Thu, Apr 06, 2023 at 08:36:19AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   acdc79917d65 ("rcu/kvfree: Avoid freeing new kfree_rcu() memory after old grace period")
> 
> Fixes tag
> 
>   Fixes: 0392bebebf26 ("rcu/kvfree: Avoid freeing new kfree_rcu() memory after old grace period")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> 
> Maybe you meant:
> 
> Fixes: 0392bebebf26 ("rcu: Add multiple in-flight batches of kfree_rcu() work")

Hello, Stephen,

There is currently some debate as to exactly which commit(s) introduced
the bug, which will hopefully come to a conclusion before tomorrow's
-next.  If they do not, I will use your correction as a placeholder.

Just for completeness, the current other two candidates (which appear
quite plausible to me) are these:

Fixes: 34c881745549 ("rcu: Support kfree_bulk() interface in kfree_rcu()")
Fixes: 5f3c8d620447 ("rcu/tree: Maintain separate array for vmalloc ptrs")

Ziwei Dai, what are your thoughts on this?  This is from a mainline
perspective, my guess being that your investigation involved some other
Linux-kernel tree.

							Thanx, Paul

  reply	other threads:[~2023-04-05 22:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-05 22:36 linux-next: Fixes tag needs some work in the rcu tree Stephen Rothwell
2023-04-05 22:59 ` Paul E. McKenney [this message]
2023-04-06  1:42   ` 答复: " 代子为 (Ziwei Dai)
  -- strict thread matches above, loose matches on Subject: below --
2024-04-08 23:14 Stephen Rothwell
2024-04-03 21:39 Stephen Rothwell
2024-04-04 12:14 ` Uladzislau Rezki
2024-04-04 14:35   ` Paul E. McKenney
2024-04-05 17:17     ` Uladzislau Rezki
2024-04-01 21:03 Stephen Rothwell
2020-10-05 11:53 Stephen Rothwell
2020-10-05 14:07 ` Paul E. McKenney
2020-02-12 22:26 Stephen Rothwell
2020-02-13 10:35 ` Paul E. McKenney
2019-12-11 20:44 Stephen Rothwell
2019-12-11 22:52 ` Paul E. McKenney
     [not found] <20191029075041.7bf3f723@canb.auug.org.au>
2019-10-28 21:01 ` Stephen Rothwell
2019-10-29  0:36   ` Paul E. McKenney
2019-10-28 20:48 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66b7fceb-0a9d-42c1-987f-1ac6c857d987@paulmck-laptop \
    --to=paulmck@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=ziwei.dai@unisoc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.