All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: netdev@vger.kernel.org, Darren Kenny <darren.kenny@oracle.com>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH net V2] vhost: correctly remove wait queue during poll failure
Date: Thu, 29 Mar 2018 16:01:44 +0800	[thread overview]
Message-ID: <66bebbe2-25f3-5098-c6ac-f61fe160c940__44730.3362926052$1522310410$gmane$org@redhat.com> (raw)
In-Reply-To: <20180329071801-mutt-send-email-mst@kernel.org>



On 2018年03月29日 12:20, Michael S. Tsirkin wrote:
> On Tue, Mar 27, 2018 at 08:50:52PM +0800, Jason Wang wrote:
>> We tried to remove vq poll from wait queue, but do not check whether
>> or not it was in a list before. This will lead double free. Fixing
>> this by switching to use vhost_poll_stop() which zeros poll->wqh after
>> removing poll from waitqueue to make sure it won't be freed twice.
>>
>> Cc: Darren Kenny<darren.kenny@oracle.com>
>> Reported-by:syzbot+c0272972b01b872e604a@syzkaller.appspotmail.com
>> Fixes: 2b8b328b61c79 ("vhost_net: handle polling errors when setting backend")
>> Signed-off-by: Jason Wang<jasowang@redhat.com>
> OK with this the only bug we have is where get user pages returns 0
> (Reported-by:syzbot+6304bf97ef436580fede@syzkaller.appspotmail.com)
>
>
>

Thanks for the reminder.

I post a patch to avoid this.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  parent reply	other threads:[~2018-03-29  8:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-27 12:50 [PATCH net V2] vhost: correctly remove wait queue during poll failure Jason Wang
2018-03-27 13:07 ` Darren Kenny
2018-03-27 13:59 ` Michael S. Tsirkin
2018-03-27 13:59 ` Michael S. Tsirkin
2018-03-27 17:04 ` David Miller
2018-03-27 17:04   ` David Miller
2018-03-29  4:20 ` Michael S. Tsirkin
2018-03-29  4:20 ` Michael S. Tsirkin
2018-03-29  8:01   ` Jason Wang
2018-03-29  8:01   ` Jason Wang [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-03-27 12:50 Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='66bebbe2-25f3-5098-c6ac-f61fe160c940__44730.3362926052$1522310410$gmane$org@redhat.com' \
    --to=jasowang@redhat.com \
    --cc=darren.kenny@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.