From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A99AC33CB1 for ; Thu, 16 Jan 2020 08:12:28 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id E5E572077B for ; Thu, 16 Jan 2020 08:12:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="17CeHCJS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5E572077B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=netronome.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C9D7F1C1BF; Thu, 16 Jan 2020 09:12:26 +0100 (CET) Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by dpdk.org (Postfix) with ESMTP id 17EF11C1BB for ; Thu, 16 Jan 2020 09:12:26 +0100 (CET) Received: by mail-lj1-f195.google.com with SMTP id r19so21593488ljg.3 for ; Thu, 16 Jan 2020 00:12:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=t80LquLRbTBoSOZLQNPwFGjwEfQLa+rL1VkH5BkP8oM=; b=17CeHCJSprt05za/isZqiyc8UuncpDDUp708LK4aot5c3QowbCJp2QUuWyoAWMX/p/ LsZM70wBSOwlKJ09Q9I96bEScUZJVV4fOJ1tK1edfzUX85LDU65C22QLRzCCJSalNzhX X+ySdlkUvTlkkzRHr2TodgV8MkoZDo0Z7Fm7dnp7XAnYS41uK1Tdr1Mb/AU7+M92Kj4j 9MiYF3Mc7ixgRQnrGDYQWyArvn1EpPKwevs6y1A3594Km0xf/yxVd+PxC92x9YzkeUFE 8/IBKguWBNjSyJSyQc8iVNv+u9RqoT83hIk2lwQmz4Go6Mpt3IM1XnLrY78GpC0/wBPc 9wLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=t80LquLRbTBoSOZLQNPwFGjwEfQLa+rL1VkH5BkP8oM=; b=cZI6zwlDhg2KX44w/Z5CVbQz+3gpCO+7elbwhwUc0NnQFhNanIxERgZ/HOeMl4Bp5A Xu6Fo1XsSsEcUmWGD8z4Zy+KvR+ncyf3wIIdeO5Psyy25iGQYKomXTZKNfwVk+wsUUhN oyiKEO+A3GIT2PA0UZKuMEaijZinQxOFQqNCu6I9qhcJgtyQz+nwzBrtqEMzPSowzMF5 znjYMmBAScznTo9t8+txBKcm0qi7Y1J+HU05oSoMdWPWkJKbJYEQ2IpxcCzhf2bkvayM ELnyclJQgGF9gzd7VGdmsGVa41w06ytkbiBTDAaWRjl2QmkzgO6Y2ZznE60du0R+vKRX lmBA== X-Gm-Message-State: APjAAAUfp/qhLOgt8id7kfaitpmL7Ots5dMUMqaT2DvlLe69R4FdiM9i SXUzIeX6wmbDfjGMlWgJRee1 X-Google-Smtp-Source: APXvYqx0JORw9x5ejN8wV4AEXjd9h7d7WLLuima77Tq5hLr3Wg3tYCKauTmQEOt9IXK+R8kV3I4gDA== X-Received: by 2002:a2e:2c04:: with SMTP id s4mr1569426ljs.35.1579162345544; Thu, 16 Jan 2020 00:12:25 -0800 (PST) Received: from [192.168.1.54] (dsl-197-245-47-232.voxdsl.co.za. [197.245.47.232]) by smtp.gmail.com with ESMTPSA id z11sm10409776ljc.97.2020.01.16.00.12.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jan 2020 00:12:24 -0800 (PST) To: Yunjian Wang , dev@dpdk.org Cc: xudingke@huawei.com References: <1578923375-23820-1-git-send-email-wangyunjian@huawei.com> From: Heinrich Kuhn Message-ID: <66c18748-83ef-1b29-bc34-37745154a31b@netronome.com> Date: Thu, 16 Jan 2020 10:12:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <1578923375-23820-1-git-send-email-wangyunjian@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/nfp: use macro PCI_PRI_FMT for PCI log format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Use PCI_PRI_FMT instead of "%04d:%02d:%02d:%d" print format. > > Signed-off-by: Yunjian Wang > --- > drivers/net/nfp/nfp_net.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c > index 3aafa7f80..64d9d218d 100644 > --- a/drivers/net/nfp/nfp_net.c > +++ b/drivers/net/nfp/nfp_net.c > @@ -1377,9 +1377,9 @@ nfp_net_dev_link_status_print(struct rte_eth_dev *dev) > PMD_DRV_LOG(INFO, " Port %d: Link Down", > dev->data->port_id); > > - PMD_DRV_LOG(INFO, "PCI Address: %04d:%02d:%02d:%d", > - pci_dev->addr.domain, pci_dev->addr.bus, > - pci_dev->addr.devid, pci_dev->addr.function); > + PMD_DRV_LOG(INFO, "PCI Address: " PCI_PRI_FMT, > + pci_dev->addr.domain, pci_dev->addr.bus, > + pci_dev->addr.devid, pci_dev->addr.function); > } > > /* Interrupt configuration and handling */ > Acked-by: Heinrich Kuhn