From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
Ian Jackson <iwj@xenproject.org>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Julien Grall <julien@xen.org>,
Dario Faggioli <dfaggioli@suse.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 3/6] xen/credit2: Remove tail padding from TRC_CSCHED2_* records
Date: Fri, 17 Sep 2021 15:10:59 +0200 [thread overview]
Message-ID: <66d0cd95-a9db-05ca-3a4c-b728a2f5cdbd@suse.com> (raw)
In-Reply-To: <20210917084559.22673-4-andrew.cooper3@citrix.com>
On 17.09.2021 10:45, Andrew Cooper wrote:
> @@ -1336,13 +1338,16 @@ update_runq_load(const struct scheduler *ops,
> {
> struct {
> uint64_t rq_avgload, b_avgload;
> - unsigned rq_load:16, rq_id:8, shift:8;
> - } d;
> - d.rq_id = rqd->id;
> - d.rq_load = rqd->load;
> - d.rq_avgload = rqd->avgload;
> - d.b_avgload = rqd->b_avgload;
> - d.shift = P;
> + uint16_t rq_load; uint8_t rq_id, shift;
Split into two lines? Preferably with this adjustment
Reviewed-by: Jan Beulich <jbeulich@suse.com>
I'd like to note that the remaining uses of "unsigned int" or plain
"int" in some of the instances you don't touch assume
sizeof(int) == 32, while generally we assume only sizeof(int) >= 32.
This is one of the cases where fixed width types are imo mandatory
to use.
Jan
next prev parent reply other threads:[~2021-09-17 13:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 8:45 [PATCH 0/6] xen/trace: Fix leakage of uninitialised stack into the tracebuffer Andrew Cooper
2021-09-17 8:45 ` [PATCH 1/6] xen/trace: Don't over-read trace objects Andrew Cooper
2021-09-17 12:58 ` Jan Beulich
2021-09-17 13:26 ` Andrew Cooper
2021-09-20 8:00 ` Jan Beulich
2021-09-20 10:24 ` Andrew Cooper
2021-09-17 8:45 ` [PATCH 2/6] xen/memory: Remove tail padding from TRC_MEM_* records Andrew Cooper
2021-09-17 13:04 ` Jan Beulich
2021-09-17 8:45 ` [PATCH 3/6] xen/credit2: Remove tail padding from TRC_CSCHED2_* records Andrew Cooper
2021-09-17 13:10 ` Jan Beulich [this message]
2021-09-17 13:28 ` Andrew Cooper
2021-09-17 8:45 ` [PATCH 4/6] x86/trace: Reduce stack usage from HVMTRACE_ND() Andrew Cooper
2021-09-20 9:05 ` Jan Beulich
2021-09-20 11:02 ` Andrew Cooper
2021-09-20 13:00 ` Jan Beulich
2021-09-17 8:45 ` [PATCH 5/6] xen/credit2: Clean up trace handling Andrew Cooper
2021-09-20 9:11 ` Jan Beulich
2021-09-17 8:45 ` [PATCH 6/6] xen/trace: Minor code cleanup Andrew Cooper
2021-09-20 9:15 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66d0cd95-a9db-05ca-3a4c-b728a2f5cdbd@suse.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=dfaggioli@suse.com \
--cc=iwj@xenproject.org \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.