From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 489F9C2BA80 for ; Tue, 7 Apr 2020 06:46:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B60C20692 for ; Tue, 7 Apr 2020 06:46:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="RwfxFhp4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727575AbgDGGqw (ORCPT ); Tue, 7 Apr 2020 02:46:52 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:43257 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727528AbgDGGqv (ORCPT ); Tue, 7 Apr 2020 02:46:51 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1586242011; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=YNf79xvKi5JqIDaeZlfwyRyDgRV9sC+NNd4/lwc+Ngc=; b=RwfxFhp4i67FaZvjziWM6HSEgR23w7QWJ84h/V9K4mTsb3R8aw9fsAYrQgzqFhF8IhGgGOuO odokWH6w0Xj0Vk10uyrs3XWOlo/mbglpaOxogQ7PYx7NLlLT+AWhMENvOvqqBa91K+VM48KG xuz4x2MCDB7Nf5+mz5YhdcWYe1s= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e8c21cc.7f439206cbc8-smtp-out-n04; Tue, 07 Apr 2020 06:46:36 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 190F4C43636; Tue, 7 Apr 2020 06:46:36 +0000 (UTC) Received: from [192.168.0.6] (unknown [183.83.138.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: akashast) by smtp.codeaurora.org (Postfix) with ESMTPSA id 2C9DBC433D2; Tue, 7 Apr 2020 06:46:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2C9DBC433D2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=akashast@codeaurora.org Subject: Re: [PATCH V3 2/8] soc: qcom: geni: Support for ICC voting To: Evan Green , Bjorn Andersson Cc: Greg Kroah-Hartman , Andy Gross , wsa@the-dreams.de, Mark Brown , Mark Rutland , Rob Herring , Georgi Djakov , linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Stephen Boyd , Manu Gautam , linux-arm-msm , linux-serial@vger.kernel.org, Matthias Kaehlcke , Doug Anderson References: <1585652976-17481-1-git-send-email-akashast@codeaurora.org> <1585652976-17481-3-git-send-email-akashast@codeaurora.org> <20200331233209.GF254911@minitux> From: Akash Asthana Message-ID: <66da4cc6-3873-1d39-ecb7-e9866320c469@codeaurora.org> Date: Tue, 7 Apr 2020 12:16:26 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Bjorn, Evan, >> Given that these two functions only switch the bandwidth request between >> some value and 0, I really think we should carry a "bool enabled" on the >> path and replace these two functions with >> icc_bulk_enable()/icc_bulk_disable(). So, if above is implementation "bool enabled" on path can be used directly in aggregation of ICC votes on particular node without using icc_set_bw call, if yes then I am not aware how? or we'll be using icc_set_bw API indirectly inside icc_bulk APIs? >> The added benefit of this would be that you call icc_set_bw() instead of >> changing the geni_icc_path->{avg_bw,peak_bw} and don't need to keep >> track of them here. Ok IIUC, we need to call icc_set_bw() from GENI driver only if we change (avg_bw | peak_bw)? Regards, Akash > Yes yes! I had the same thought here [1]. > > Georgi, what do you think? > -Evan > > [1] https://lore.kernel.org/linux-arm-msm/CAE=gft58QsgTCUHMHKJhcM9ZxAeMiY16CrbNv2HaTCRqwtmt7A@mail.gmail.com/ -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project