From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6364159153 for ; Wed, 27 Mar 2024 11:20:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711538431; cv=none; b=qdsH49IrXHDQ5SoyQ77Sgd3Xwkti02mz+zdku/XXGxT2WGxSkcIGtT13DlhIT0lxLBNNbv/qhp39VTLHSUpNVOfkMCIv9bJRm9whklsXoIbchGv/punaZCqyYdlTfLQuNSYqjfl5qF8b5Vj4m00mWCPXQgJtsfZ0pkJev3swZXM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711538431; c=relaxed/simple; bh=sLGilc1NTQU/20JtIzlYYh9ER3iVh8O5ZE4v4dpJ9gE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LZiSOZfjdGIyWdtvDQGuXZhtbw/q40KOQm0bkHyheQFE7daiLKErdlvoA2g8nZM1tbWJ5bO70q9SXF9VviB9LJr0OMKHGprb/WFG7ks5DOolOFJ3ODNkTs99Rm/npMJuPe2SYuceBqdwXNwqcITTIw0xIkAwpwwNHfMWVSCF7jE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yPn0cnQa; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yPn0cnQa" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a474c4faf5eso426497166b.2 for ; Wed, 27 Mar 2024 04:20:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711538428; x=1712143228; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+rLYEsrATiPL/v2vO8QHboqtuHAhSql0Vcajen2fdC0=; b=yPn0cnQay92fwD0uKnNOLyV7j/xVNYtUzIqoKMnnIcDT6hGSGGMmBOZD53t+8Kt3bC Nzzz8l4E6dSM2RNQchTHB4XFk25X6WbM2gNbc+IfjfE6u8NJ2oQfoTiAi2kb6Eh6/lKV MGkDvo1AM83bsBAb4Y6OkxDCKVoKNsh/xIMV6qMUYrHbwDrfsUNoocR3Ak0iNlVhksKN 9YGtsWu0E82S41gdu9SHmIwg8854RLSau+s2RF5KhF7/mJOrDbyCsJSjaXbavL/2fV8d oWYzT6rFbe1avXAkJ8GSI0Ru8cjC5esyAh9hNJ96AbW0YADpPMU4oe9RhzsFGxB3Rtt4 /GHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711538428; x=1712143228; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+rLYEsrATiPL/v2vO8QHboqtuHAhSql0Vcajen2fdC0=; b=usQCoyr8DRx5lkWpZYfmKeCqc39qxt5qWd33ogChG41fx1cl4WsJ068+d1qS8CacEx FIjE18D5I0s780pZnyTK+oSQjcaAh1OnGw1h7UBQJzeyLor3sCnsKPUkrseU1FUHkWcH XuuavcHMI4hYfyFr6FOHx74Q8zMrZcs+lUKv3bUgzpUz9NK3TA2OTKEfu5AGDEPcTRHo mQ1POOlfi54SvXJcR7712kIBYZYwhhpv0p2kPjJ8R18JhQFzINACfmYYREka3ZowdWiC zwsUOywWoY6DVsILrTVxaOYIP8VbzhMdXuhTpcJ+g/iVCeLpAGE8IGLgUG90zP4j5sZT DSZw== X-Forwarded-Encrypted: i=1; AJvYcCUas9cFahPAwfZDFKv60HaZ1TWICGvfXPxoxyNuQHi8HH2zYjMdsKkAntn1zxccXy/QFB1S0pUilMt6mdHThGkInHtqxCywdQyuuQ== X-Gm-Message-State: AOJu0YyRETXB+3e0GIrdau5k/i9KAJa1upoYxB8Bs8tq0eL2mcBOY3zR dhJT2zSlfRBxSrK4uyniB1Vvxb1ZOpdwIsbjCyfz7NrJ102fv1RvxnvIgUcwHk8= X-Google-Smtp-Source: AGHT+IGeBgEp7hvEv/ZVJCOrCyHMMCcPPW3O1khQf6wm+VqzRsO348+zMqvIj69jGo7U7jADPphm8g== X-Received: by 2002:a17:906:3747:b0:a45:ad29:725c with SMTP id e7-20020a170906374700b00a45ad29725cmr670356ejc.62.1711538427605; Wed, 27 Mar 2024 04:20:27 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id l19-20020a17090612d300b00a46cffe6d06sm5307387ejb.42.2024.03.27.04.20.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 04:20:27 -0700 (PDT) Date: Wed, 27 Mar 2024 14:20:22 +0300 From: Dan Carpenter To: "Peng Fan (OSS)" Cc: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan , Oleksii Moisieiev Subject: Re: [PATCH v6 4/4] pinctrl: Implementation of the generic scmi-pinctrl driver Message-ID: <66e34e4a-82e1-4c52-843e-019daeaf4768@moroto.mountain> References: <20240323-pinctrl-scmi-v6-0-a895243257c0@nxp.com> <20240323-pinctrl-scmi-v6-4-a895243257c0@nxp.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240323-pinctrl-scmi-v6-4-a895243257c0@nxp.com> On Sat, Mar 23, 2024 at 08:15:17PM +0800, Peng Fan (OSS) wrote: > diff --git a/drivers/firmware/arm_scmi/pinctrl.c b/drivers/firmware/arm_scmi/pinctrl.c > index 87d9b89cab13..0ecefe855432 100644 > --- a/drivers/firmware/arm_scmi/pinctrl.c > +++ b/drivers/firmware/arm_scmi/pinctrl.c > @@ -465,6 +465,7 @@ scmi_pinctrl_settings_conf(const struct scmi_protocol_handle *ph, > > tx = t->tx.buf; > tx->identifier = cpu_to_le32(selector); > + tx->function_id = cpu_to_le32(0xFFFFFFFF); > attributes = FIELD_PREP(GENMASK(1, 0), type) | > FIELD_PREP(GENMASK(9, 2), chunk); > tx->attributes = cpu_to_le32(attributes); This should have been done in patch 3. regards, dan carpenter > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index d45657aa986a..4e6f65cf0e76 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -450,6 +450,17 @@ config PINCTRL_ROCKCHIP From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CA21C47DD9 for ; Wed, 27 Mar 2024 11:20:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iQesdHPHvgHbg94rejkJQkWsLP4wHEwe8lJuMnS2Sc4=; b=4PZ1YtFJv1a9xn f9MeUrz6x3L4Yf2oGcVv1AGtZRFAS2FcbSQDmNAZTnq6RMQUi8yb6vxvAANeYtmIMDLxDYVGkxjZJ 7e8W5gG3+5+NPB0l2QJwXQuoqi3wN38GUPYQ8q7M35Ys6Pwaf7KdDVmbVmzBIc0vrBCDbIWJVS4MH YL4q0a/JUlD4r3oVd+lgN/rFBPub2l4aoF+ZcodBtuuj6Jc08CfStLFdb2OK5Tq3egNaUNhjUYxRp 5Wea7WZ802PEYy+W9y5IQT+kpmopKRkEi9BZgK1XSlf5lIMIp8A1cnA2Os42A02cRMHKtYvUQbpC5 rDkEDS51HyOyPa0J8lUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpRKc-00000008aZb-0Dy8; Wed, 27 Mar 2024 11:20:34 +0000 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpRKZ-00000008aYI-0Ync for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2024 11:20:32 +0000 Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-56845954ffeso9359124a12.2 for ; Wed, 27 Mar 2024 04:20:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711538428; x=1712143228; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+rLYEsrATiPL/v2vO8QHboqtuHAhSql0Vcajen2fdC0=; b=q1ma/Hy6V/y/msZR21jz0jS9ABGsGeU5YsqoIabVRzGnGi9It5o3IWMqgwKp7lXtWD fDgKkbepb/VMkrVymmkCqEeTWp5PFH1Eu3nGBu/HTjlCrXFUoQg69IMzPjzL8l/QpM64 7UirEFmTmdUQiCv43w9zYfS3JBsXX8/mxbxx7I7K9C9Ccs7KoEPZRy8O8gn0gpXu0mHL eDWPA4l4jnnnjeMkDNyO2244iZmGK9crzSwYNGuNPq3j1lz/33kZFkZrs4uX1/mcML0T iWzbZwkUfxO/kQjvVmr+y4bF7hrGOCqEFfaHkfaLTedrMhEBpozqRLVS+qnocV2QUMN6 My6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711538428; x=1712143228; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+rLYEsrATiPL/v2vO8QHboqtuHAhSql0Vcajen2fdC0=; b=VyvYwlMsU3+VJhqTPY98GarcQDBOljs1gynGBzXpSiRZScghMwnYJ8EhAXcU4LRhkp S/uu5CdmdkcC/rBcaiz/Pits3rqpa8g1XU2rSly+sYGpwb+/I9wZuwrMEWmzheqGJHNO gqKF8xhjNnulgzFsCrapkVLbDw7k0jiz4aGJ4e8yNF5tITYX3/DY99w9dPOFypjhOhSD RDRqKy8kdxCvwNMfvtUuZsHhrZcn9gDNpP4OOWyWU0j5G1TZbQcksvgopmdMcfKKM8Ui NfPVppsSZT6JY44Z5WE5Ari0VyzNQA73uqhlsgdFKcnnwvNyUjj2KcYoWtohOPJ9IQs2 5LIg== X-Forwarded-Encrypted: i=1; AJvYcCXXWIYv5MsSwa4DoY8ZUKo9WOwq3jC7yf0h3xrkGaoErwjkYQrdVKFzDMKXK+YbOtqKj9Y2WXkebYItEhAvN4GCbbh3cEmdu+XQdyWNb+t4omKhIP0= X-Gm-Message-State: AOJu0YyXMGRBRtOSG59Yt1Gq6LBNxtdAmfAUbuR8UH2BVa1bPe2a7xRu PGpsXiFxRxxQQqYoZQIBI2EzLgh0kfxAxvdbB7X8qv1Rf02Wk31vd05qpYGH5YU= X-Google-Smtp-Source: AGHT+IGeBgEp7hvEv/ZVJCOrCyHMMCcPPW3O1khQf6wm+VqzRsO348+zMqvIj69jGo7U7jADPphm8g== X-Received: by 2002:a17:906:3747:b0:a45:ad29:725c with SMTP id e7-20020a170906374700b00a45ad29725cmr670356ejc.62.1711538427605; Wed, 27 Mar 2024 04:20:27 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id l19-20020a17090612d300b00a46cffe6d06sm5307387ejb.42.2024.03.27.04.20.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 04:20:27 -0700 (PDT) Date: Wed, 27 Mar 2024 14:20:22 +0300 From: Dan Carpenter To: "Peng Fan (OSS)" Cc: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan , Oleksii Moisieiev Subject: Re: [PATCH v6 4/4] pinctrl: Implementation of the generic scmi-pinctrl driver Message-ID: <66e34e4a-82e1-4c52-843e-019daeaf4768@moroto.mountain> References: <20240323-pinctrl-scmi-v6-0-a895243257c0@nxp.com> <20240323-pinctrl-scmi-v6-4-a895243257c0@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240323-pinctrl-scmi-v6-4-a895243257c0@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240327_042031_220812_D172DEC1 X-CRM114-Status: GOOD ( 11.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Mar 23, 2024 at 08:15:17PM +0800, Peng Fan (OSS) wrote: > diff --git a/drivers/firmware/arm_scmi/pinctrl.c b/drivers/firmware/arm_scmi/pinctrl.c > index 87d9b89cab13..0ecefe855432 100644 > --- a/drivers/firmware/arm_scmi/pinctrl.c > +++ b/drivers/firmware/arm_scmi/pinctrl.c > @@ -465,6 +465,7 @@ scmi_pinctrl_settings_conf(const struct scmi_protocol_handle *ph, > > tx = t->tx.buf; > tx->identifier = cpu_to_le32(selector); > + tx->function_id = cpu_to_le32(0xFFFFFFFF); > attributes = FIELD_PREP(GENMASK(1, 0), type) | > FIELD_PREP(GENMASK(9, 2), chunk); > tx->attributes = cpu_to_le32(attributes); This should have been done in patch 3. regards, dan carpenter > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index d45657aa986a..4e6f65cf0e76 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -450,6 +450,17 @@ config PINCTRL_ROCKCHIP _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel