All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, Michael Fritscher <michael@fritscher.net>,
	Greg Kurz <groug@kaod.org>
Subject: Re: [Qemu-devel] [PATCH for-2.7 1/2] 9p: don't include <sys/uio.h>
Date: Thu, 30 Jun 2016 13:40:43 +0200	[thread overview]
Message-ID: <66efbc38-69e5-55b4-017f-78f96a3331a3@kaod.org> (raw)
In-Reply-To: <20160413131520.31708.12050.stgit@bahia.huguette.org>

On 04/13/2016 03:15 PM, Greg Kurz wrote:
> The <sys/uio.h> system header doesn't exist on all host platforms. Code should
> include "qemu/osdep.h" instead to avoid build breaks on plafforms that don't
> define CONFIG_IOVEC (like win32, if it is to support 9p one day).
> 
> Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>

Acked-by: Cédric Le Goater <clg@kaod.org>

> ---
>  fsdev/9p-iov-marshal.c |    1 -
>  fsdev/9p-marshal.c     |    1 -
>  fsdev/file-op-9p.h     |    2 +-
>  3 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/fsdev/9p-iov-marshal.c b/fsdev/9p-iov-marshal.c
> index fb40bdf0d5f6..a564637b73c1 100644
> --- a/fsdev/9p-iov-marshal.c
> +++ b/fsdev/9p-iov-marshal.c
> @@ -15,7 +15,6 @@
>  #include <glib.h>
>  #include <glib/gprintf.h>
>  #include <utime.h>
> -#include <sys/uio.h>
> 
>  #include "9p-iov-marshal.h"
>  #include "qemu/bswap.h"
> diff --git a/fsdev/9p-marshal.c b/fsdev/9p-marshal.c
> index 183d3667c681..df9d4f8e23c9 100644
> --- a/fsdev/9p-marshal.c
> +++ b/fsdev/9p-marshal.c
> @@ -16,7 +16,6 @@
>  #include <glib/gprintf.h>
>  #include <dirent.h>
>  #include <utime.h>
> -#include <sys/uio.h>
> 
>  #include "9p-marshal.h"
> 
> diff --git a/fsdev/file-op-9p.h b/fsdev/file-op-9p.h
> index b8c26024a955..8736d1fa6d52 100644
> --- a/fsdev/file-op-9p.h
> +++ b/fsdev/file-op-9p.h
> @@ -12,9 +12,9 @@
>   */
>  #ifndef _FILEOP_H
>  #define _FILEOP_H
> +#include "qemu/osdep.h"
>  #include <dirent.h>
>  #include <utime.h>
> -#include <sys/uio.h>
>  #include <sys/vfs.h>
> 
>  #define SM_LOCAL_MODE_BITS    0600
> 
> 

  reply	other threads:[~2016-06-30 11:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13 13:15 [Qemu-devel] [PATCH for-2.7 0/2] 9p: cleanup in #include directives Greg Kurz
2016-04-13 13:15 ` [Qemu-devel] [PATCH for-2.7 1/2] 9p: don't include <sys/uio.h> Greg Kurz
2016-06-30 11:40   ` Cédric Le Goater [this message]
2016-06-30 12:42     ` Michael Fritscher
2016-06-30 12:54       ` Greg Kurz
2016-06-30 12:57   ` Markus Armbruster
2016-06-30 13:07     ` Greg Kurz
2016-04-13 13:15 ` [Qemu-devel] [PATCH for-2.7 2/2] 9p: some more cleanup in #include directives Greg Kurz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66efbc38-69e5-55b4-017f-78f96a3331a3@kaod.org \
    --to=clg@kaod.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=gkurz@linux.vnet.ibm.com \
    --cc=groug@kaod.org \
    --cc=michael@fritscher.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.