From: Camel Guo <camelg@axis.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Camel Guo <Camel.Guo@axis.com>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"jdelvare@suse.com" <jdelvare@suse.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>
Cc: kernel <kernel@axis.com>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: Add TMP401, TMP411 and TMP43x
Date: Tue, 12 Apr 2022 16:08:21 +0200 [thread overview]
Message-ID: <66f417b0-c323-1b9f-d5b0-30f1c9bcd90b@axis.com> (raw)
In-Reply-To: <c13a0f34-4938-3d56-43e0-5a9053e0bc25@linaro.org>
On 4/12/22 13:53, Krzysztof Kozlowski wrote:
> On 11/04/2022 12:03, Camel Guo wrote:
>> From: Camel Guo <camelg@axis.com>
>>
>> Document the TMP401, TMP411 and TMP43x device devicetree bindings
>>
>> Signed-off-by: Camel Guo <camelg@axis.com>
>> ---
>> .../devicetree/bindings/hwmon/ti,tmp401.yaml | 111 ++++++++++++++++++
>> MAINTAINERS | 1 +
>> 2 files changed, 112 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/hwmon/ti,tmp401.yaml
>>
>> + - ti,tmp401
>> + - ti,tmp411
>> + - ti,tmp431
>> + - ti,tmp432
>> + - ti,tmp435
>
> Blank line, please.
Fixed
>
>> + reg:
>> + maxItems: 1
>> +
>> + '#address-cells':
>> + const: 1
>> +
>> + '#size-cells':
>> + const: 0
>> +
>> + ti,extended-range-enable:
>> + description: |
>
> No need for "|". Here and in most of other cases below.
Fixed
>
>> + When set, this sensor measures over extended temperature range.
>> + type: boolean
>> +
>> + ti,n-factor:
>> + description: |
>> + The value (two's complement) to be programmed in the n-factor correction
>> + register.
>
> Do not describe the programming model (registers) but hardware property
> instead.
Make another try. Hope it is clear now.
>
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + items:
>> + minimum: 0
>> + maximum: 255
>> +
>> + ti,beta-compensation:
>> + description: |
>> + The value to be programmed in the beta range register.
>
> The same, register values should not be stored in DT.
>
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + items:
>> + minimum: 0
>> + maximum: 15
>> +
>
>
> Best regards,
> Krzysztof
Fixed in v2. Please review that instead.
next prev parent reply other threads:[~2022-04-12 14:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 10:03 [PATCH 0/2] hwmon/tmp401: add support of three advanced features Camel Guo
2022-04-11 10:03 ` [PATCH 1/2] dt-bindings: hwmon: Add TMP401, TMP411 and TMP43x Camel Guo
2022-04-12 11:53 ` Krzysztof Kozlowski
2022-04-12 14:08 ` Camel Guo [this message]
2022-04-11 10:03 ` [PATCH 2/2] hwmon: (tmp401) Add support of three advanced features Camel Guo
-- strict thread matches above, loose matches on Subject: below --
2022-04-11 9:56 [PATCH 0/2] hwmon/tmp401: add " Camel Guo
2022-04-11 9:56 ` [PATCH 1/2] dt-bindings: hwmon: Add TMP401, TMP411 and TMP43x Camel Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66f417b0-c323-1b9f-d5b0-30f1c9bcd90b@axis.com \
--to=camelg@axis.com \
--cc=Camel.Guo@axis.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=kernel@axis.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.