From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E648C433FE for ; Fri, 21 Oct 2022 06:51:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229996AbiJUGvZ (ORCPT ); Fri, 21 Oct 2022 02:51:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229841AbiJUGvX (ORCPT ); Fri, 21 Oct 2022 02:51:23 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFFF51D93E2 for ; Thu, 20 Oct 2022 23:51:20 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8924221890; Fri, 21 Oct 2022 06:51:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1666335079; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+e55qnoYClQvZEcxGwSqNGwE4xgxw7vbay5ghEmriXM=; b=fDCcRYr5GxhDckYqff43MGiaj9D7bKPIACx+Wkzo3m6GOW4n0/4IlVrLGCFUyO4mcFkV14 L+AACZKafOS6otFGvp2qv6baDlQByKs61DdrcdRkCBDUJVmBFseakEx+IceECs0aQmhh7c mxQjVajNGyRwbf38xgz44gzU/DJ1nVU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1666335079; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+e55qnoYClQvZEcxGwSqNGwE4xgxw7vbay5ghEmriXM=; b=5t/L7Utg4S1rRlNWB+QPOc4Pho+ILT0PhIOU4dv9cvRzUlAgwjsB9NcUVrgmbcbzo6vieS 3XpSgR0asir8luBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 568431331A; Fri, 21 Oct 2022 06:51:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id dkZoFGdBUmMxHwAAMHmgww (envelope-from ); Fri, 21 Oct 2022 06:51:19 +0000 Message-ID: <66fcb7c7-47bd-b1f8-0bae-f961f4c0015c@suse.de> Date: Fri, 21 Oct 2022 08:51:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 5/8] blk-mq: add tagset quiesce interface Content-Language: en-US To: Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg , Chao Leng Cc: Ming Lei , linux-nvme@lists.infradead.org, linux-block@vger.kernel.org References: <20221020105608.1581940-1-hch@lst.de> <20221020105608.1581940-6-hch@lst.de> From: Hannes Reinecke In-Reply-To: <20221020105608.1581940-6-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 10/20/22 12:56, Christoph Hellwig wrote: > From: Chao Leng > > Drivers that have shared tagsets may need to quiesce potentially a lot > of request queues that all share a single tagset (e.g. nvme). Add an > interface to quiesce all the queues on a given tagset. This interface is > useful because it can speedup the quiesce by doing it in parallel. > > Because some queues should not need to be quiesced(e.g. nvme connect_q) > when quiesce the tagset. So introduce QUEUE_FLAG_SKIP_TAGSET_QUIESCE to > tagset quiesce interface to skip the queue. > > Signed-off-by: Chao Leng > [hch: simplify for the per-tag_set srcu_struct] > Signed-off-by: Christoph Hellwig > --- > block/blk-mq.c | 25 +++++++++++++++++++++++++ > include/linux/blk-mq.h | 2 ++ > include/linux/blkdev.h | 3 +++ > 3 files changed, 30 insertions(+) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman