All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Pitre <nico@fluxnic.net>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Linux PM <linux-pm@vger.kernel.org>,
	linux-clk <linux-clk@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Mark Brown <broonie@kernel.org>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2] PM / clk: make PM clock layer compatible with clocks that must sleep
Date: Fri, 22 Jan 2021 10:52:18 -0500 (EST)	[thread overview]
Message-ID: <66o22n46-n7p6-3p8r-3ssp-rs8oo28n87nq@syhkavp.arg> (raw)
In-Reply-To: <CAJZ5v0hj4VC_kjB5e_b_ho=ET_quG5zUh0Dbbdwofp-6azopsw@mail.gmail.com>

On Fri, 22 Jan 2021, Rafael J. Wysocki wrote:

> > > +/**
> > > + * pm_clk_list_unlock - counterpart to pm_clk_list_lock().
> > > + * @psd: the same pm_subsys_data instance previously passed to
> > > + *      pm_clk_list_lock().
> > > + */
> > > +static void pm_clk_list_unlock(struct pm_subsys_data *psd)
> 
> Locking annotations for sparse were missing here and above, so I've
> added them by hand.

Thanks.

> Please double check the result in my linux-next branch (just pushed).

There are still the following warnings:

drivers/base/power/clock_ops.c:52:13: warning: context imbalance in 'pm_clk_list_lock' - wrong count at exit
drivers/base/power/clock_ops.c:64:13: warning: context imbalance in 'pm_clk_list_unlock' - wrong count at exit

I guess this can be silenced (still need to investigate how those 
annotations work).

But I'm more worried about these:

drivers/base/power/clock_ops.c:86:12: warning: context imbalance in 'pm_clk_op_lock' - different lock contexts for basic block
drivers/base/power/clock_ops.c:131:39: warning: context imbalance in 'pm_clk_op_unlock' - unexpected unlock

Those are special locking helpers indeed and I don't know if that can be 
dealt with.


Nicolas

      parent reply	other threads:[~2021-01-22 15:54 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-05  3:17 [PATCH] PM / clk: make PM clock layer compatible with clocks that must sleep Nicolas Pitre
2021-01-17 23:49 ` Nicolas Pitre
2021-01-19 20:15   ` Rafael J. Wysocki
2021-01-19 18:45 ` Kevin Hilman
2021-01-19 20:38   ` Geert Uytterhoeven
2021-01-19 21:22     ` Nicolas Pitre
2021-01-21  9:11 ` Naresh Kamboju
2021-01-21 10:58   ` Geert Uytterhoeven
2021-01-21 12:09     ` Naresh Kamboju
2021-01-21 14:44       ` Rafael J. Wysocki
2021-01-21 16:18         ` Nicolas Pitre
2021-01-21 17:23         ` [PATCH v2] " Nicolas Pitre
2021-01-21 19:01           ` Rafael J. Wysocki
2021-01-22 15:09             ` Rafael J. Wysocki
2021-01-22 15:48               ` Naresh Kamboju
2021-01-22 15:56                 ` Rafael J. Wysocki
2021-01-22 15:59                   ` Nicolas Pitre
2021-01-22 16:00                     ` Nicolas Pitre
2021-01-22 16:02                     ` Rafael J. Wysocki
2021-01-23 23:07                       ` [PATCH v3] " Nicolas Pitre
2021-01-25 18:15                         ` Rafael J. Wysocki
2021-01-25 18:24                           ` Nicolas Pitre
2021-01-25 19:29                             ` [PATCH v4] " Nicolas Pitre
2021-01-27 18:31                               ` Rafael J. Wysocki
     [not found]                               ` <161301451636.1254594.7473642352348913785@swboyd.mtv.corp.google.com>
2021-02-11  7:55                                 ` Geert Uytterhoeven
2021-01-22 15:52               ` Nicolas Pitre [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66o22n46-n7p6-3p8r-3ssp-rs8oo28n87nq@syhkavp.arg \
    --to=nico@fluxnic.net \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mturquette@baylibre.com \
    --cc=naresh.kamboju@linaro.org \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.