From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:54570 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730244AbeG0LAt (ORCPT ); Fri, 27 Jul 2018 07:00:49 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Date: Fri, 27 Jul 2018 17:39:44 +0800 From: Wen Gong To: =?UTF-8?Q?Micha=C5=82_Kazior?= Cc: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , ath10k@lists.infradead.org, Johannes Berg , linux-wireless Subject: Re: [PATCH 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips In-Reply-To: References: <1532589677-16428-1-git-send-email-wgong@codeaurora.org> <1532589677-16428-3-git-send-email-wgong@codeaurora.org> <87zhye1aqg.fsf@toke.dk> Message-ID: <6715f59dc8e834cddd701c6f9ee9f344@codeaurora.org> (sfid-20180727_113948_690480_29642F66) Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2018-07-26 21:02, Michał Kazior wrote: > On 26 July 2018 at 13:45, Toke Høiland-Jørgensen wrote: >> Wen Gong writes: >> >>> Upstream kernel has an interface to help adjust sk_pacing_shift to >>> help >>> improve TCP UL throughput. >>> The sk_pacing_shift is 8 in mac80211, this is based on test with 11N >>> WiFi chips with ath9k. For QCA6174/QCA9377 PCI 11AC chips, the 11AC >>> VHT80 TCP UL throughput testing result shows 6 is the optimal. >>> Overwrite the sk_pacing_shift to 6 in ath10k driver. >> >> When I tested this, a pacing shift of 8 was quite close to optimal as >> well for ath10k. Why are you getting different results? >> >>> Tested with QCA6174 PCI with firmware >>> WLAN.RM.4.4.1-00109-QCARMSWPZ-1, but this will also affect QCA9377 >>> PCI. >>> It's not a regression with new firmware releases. >>> >>> There have 2 test result of different settings: >>> >>> ARM CPU based device with QCA6174A PCI with different >>> sk_pacing_shift: > > Different firmware releases have different tx buffering > characteristics. In some 10.2 firmware running on QCA9888 you can have > up to 5ms of delayed aggregation. Ideally sk_pacing_shift should be > adjusted per firmware release. Maybe this should become part of the > ath10k firmware wrapping "fw features" stuff? > recently we do not want to do like this since no test data for each firmware. > > Michał From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fizE4-0005vH-U2 for ath10k@lists.infradead.org; Fri, 27 Jul 2018 09:39:58 +0000 MIME-Version: 1.0 Date: Fri, 27 Jul 2018 17:39:44 +0800 From: Wen Gong Subject: Re: [PATCH 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips In-Reply-To: References: <1532589677-16428-1-git-send-email-wgong@codeaurora.org> <1532589677-16428-3-git-send-email-wgong@codeaurora.org> <87zhye1aqg.fsf@toke.dk> Message-ID: <6715f59dc8e834cddd701c6f9ee9f344@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: =?UTF-8?Q?Micha=C5=82_Kazior?= Cc: Johannes Berg , =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , linux-wireless , ath10k@lists.infradead.org T24gMjAxOC0wNy0yNiAyMTowMiwgTWljaGHFgiBLYXppb3Igd3JvdGU6Cj4gT24gMjYgSnVseSAy MDE4IGF0IDEzOjQ1LCBUb2tlIEjDuGlsYW5kLUrDuHJnZW5zZW4gPHRva2VAdG9rZS5kaz4gd3Jv dGU6Cj4+IFdlbiBHb25nIDx3Z29uZ0Bjb2RlYXVyb3JhLm9yZz4gd3JpdGVzOgo+PiAKPj4+IFVw c3RyZWFtIGtlcm5lbCBoYXMgYW4gaW50ZXJmYWNlIHRvIGhlbHAgYWRqdXN0IHNrX3BhY2luZ19z aGlmdCB0byAKPj4+IGhlbHAKPj4+IGltcHJvdmUgVENQIFVMIHRocm91Z2hwdXQuCj4+PiBUaGUg c2tfcGFjaW5nX3NoaWZ0IGlzIDggaW4gbWFjODAyMTEsIHRoaXMgaXMgYmFzZWQgb24gdGVzdCB3 aXRoIDExTgo+Pj4gV2lGaSBjaGlwcyB3aXRoIGF0aDlrLiBGb3IgUUNBNjE3NC9RQ0E5Mzc3IFBD SSAxMUFDIGNoaXBzLCB0aGUgMTFBQwo+Pj4gVkhUODAgVENQIFVMIHRocm91Z2hwdXQgdGVzdGlu ZyByZXN1bHQgc2hvd3MgNiBpcyB0aGUgb3B0aW1hbC4KPj4+IE92ZXJ3cml0ZSB0aGUgc2tfcGFj aW5nX3NoaWZ0IHRvIDYgaW4gYXRoMTBrIGRyaXZlci4KPj4gCj4+IFdoZW4gSSB0ZXN0ZWQgdGhp cywgYSBwYWNpbmcgc2hpZnQgb2YgOCB3YXMgcXVpdGUgY2xvc2UgdG8gb3B0aW1hbCBhcwo+PiB3 ZWxsIGZvciBhdGgxMGsuIFdoeSBhcmUgeW91IGdldHRpbmcgZGlmZmVyZW50IHJlc3VsdHM/Cj4+ IAo+Pj4gVGVzdGVkIHdpdGggUUNBNjE3NCBQQ0kgd2l0aCBmaXJtd2FyZQo+Pj4gV0xBTi5STS40 LjQuMS0wMDEwOS1RQ0FSTVNXUFotMSwgYnV0IHRoaXMgd2lsbCBhbHNvIGFmZmVjdCBRQ0E5Mzc3 IAo+Pj4gUENJLgo+Pj4gSXQncyBub3QgYSByZWdyZXNzaW9uIHdpdGggbmV3IGZpcm13YXJlIHJl bGVhc2VzLgo+Pj4gCj4+PiBUaGVyZSBoYXZlIDIgdGVzdCByZXN1bHQgb2YgZGlmZmVyZW50IHNl dHRpbmdzOgo+Pj4gCj4+PiBBUk0gQ1BVIGJhc2VkIGRldmljZSB3aXRoIFFDQTYxNzRBIFBDSSB3 aXRoIGRpZmZlcmVudAo+Pj4gc2tfcGFjaW5nX3NoaWZ0Ogo+IAo+IERpZmZlcmVudCBmaXJtd2Fy ZSByZWxlYXNlcyBoYXZlIGRpZmZlcmVudCB0eCBidWZmZXJpbmcKPiBjaGFyYWN0ZXJpc3RpY3Mu IEluIHNvbWUgMTAuMiBmaXJtd2FyZSBydW5uaW5nIG9uIFFDQTk4ODggeW91IGNhbiBoYXZlCj4g dXAgdG8gNW1zIG9mIGRlbGF5ZWQgYWdncmVnYXRpb24uIElkZWFsbHkgc2tfcGFjaW5nX3NoaWZ0 IHNob3VsZCBiZQo+IGFkanVzdGVkIHBlciBmaXJtd2FyZSByZWxlYXNlLiBNYXliZSB0aGlzIHNo b3VsZCBiZWNvbWUgcGFydCBvZiB0aGUKPiBhdGgxMGsgZmlybXdhcmUgd3JhcHBpbmcgImZ3IGZl YXR1cmVzIiBzdHVmZj8KPiAKcmVjZW50bHkgd2UgZG8gbm90IHdhbnQgdG8gZG8gbGlrZSB0aGlz IHNpbmNlIG5vIHRlc3QgZGF0YSBmb3IgZWFjaCAKZmlybXdhcmUuCj4gCj4gTWljaGHFggoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYXRoMTBrIG1haWxp bmcgbGlzdAphdGgxMGtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2F0aDEwawo=