From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423377AbcFMNFh (ORCPT ); Mon, 13 Jun 2016 09:05:37 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:55186 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422821AbcFMNFf (ORCPT ); Mon, 13 Jun 2016 09:05:35 -0400 From: Arnd Bergmann To: Linus Torvalds Cc: Sage Weil , Linux Kernel Mailing List , ceph-devel , Ilya Dryomov Subject: Re: [GIT PULL] Ceph updates for 4.7-rc1 Date: Mon, 13 Jun 2016 15:06:51 +0200 Message-ID: <6717851.ptlac7jbfE@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <3724610.gtEplKGO6B@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:ilcx61jxOsbWCUVcZiU8rDbQffH4J6lWhGvS4ywDLkizDVisDqq 1Yg1CnclC38L2YROrghOldqlJZU7eyv0bwMPDoCHqTOWsmNZSLvMqRlFG/M/ZKKpVEP6pSE ZY0c3cOEUsXtpJtfso4YIQDrve3WgFoGJHvC/IhOUJqQh3DxDbULm7a/I5QXRsULkOfuyGI SgBMt8vXSsXmdK28JExNA== X-UI-Out-Filterresults: notjunk:1;V01:K0:h5SOf8WiYjQ=:gaGZplQyC0VJTjeu+ExESl oIKt3KOnLzYELPgooASXwngv3PI0KWZYqdxXulY+eaKKvOaz2L28ji06xui4W5CZwc4agnUm8 ndWtAQapQ0MsLqypoqpBlrBefLtnydt06jMWSsOGcmNURhHZyvZ8k7UczpDsFwTNx5oQsYYC/ RXkuzd33iHkr+jxyxkdEFHDSiffejqH/G+jaI8lgyuspldXTR/anoJAsSeHTp4UCY36Fn/75m j4RTmWH4gizrdgH1f2Z8GuVgkuUQF+hNVkk3+XgPQylK3zF5CnQhGkd33Hpr5CpHYI29d315v 1q1aPSKDmi+nR7vSbHBMSjfFxTw2p2eXoSlxrrF5Ijh0ynLvy+JWafLNrOrIt3oQ2lGojVHmt n9SIuTMLIZe+E2q+Ssx1TpTJnaQ2CTfMuue5ECh9AJvyEH4vNvO0Q+R3Bpx3sR8RcXLU1bH5s xE/EI2eWnJawj5pmmE3qUHsjGJzZGorlmPwJyOLhOf//i6PEc0xm6b+kiKmeVHyB+dd2549I0 uTDcy4REsOCLA0HjN6tGoAkZEhHjYA5f+K4yDi4lFSTTiup1WScdrjITtXo2CGmHU1nezCJFz D73TSFvp26/bA0OaqUE7htBR64qWlbPzS0LjQE28qWguEfvJXtUwv47lvXlWo01+78at5KWy9 DpBzK0/JK47yvKNNa+kh/qh2MKTHizis1FdmmQ1ULCFXtJR2iBHxnXF9hRpsVYwb8DecJkNmE FJ26G889ivbXJLWr Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, June 10, 2016 2:32:21 PM CEST Linus Torvalds wrote: > On Fri, Jun 10, 2016 at 1:42 PM, Arnd Bergmann wrote: > > > > What I see is that this one exported symbol has a __crc of a different > > type from all the others: > > > > $ nm net/ceph/mon_client.o | grep __crc > > 48c2e16e A __crc_ceph_monc_get_version > > 2360d633 A __crc_ceph_monc_get_version_async > > 0c50a10a A __crc_ceph_monc_got_map > > w __crc_ceph_monc_do_statfs > > A lower-case 'w' in a symbol list just means that it's a local weak > symbol (with a upper-case 'A' meaning it's an absolute global). > > Afaik, that simply means that it never got resolved, and genksyms > never generated that absolute value for it. > > As to _why_ that happens, that's more than I can guess. We've had > problems with genksyms before, and it tends to be hard to debug. > > Is it 100% reliable for you? Because the most common problem has been > issues with subtle build races, where just causing a re-build will fix > it. > > Your config doesn't work for me, when I do > > cp ~/genksyms-config.txt .config > make ARCH=i386 oldconfig > > I get something else than what you had. I tried with both current -git > and the commit you pinpointed, so I don't know how you generated that > config file.. I've tracked it down to the use of the 'typeof(((type *)0)->keyfld)' expression in DEFINE_RB_LOOKUP() now, and sent a patch with subject "ceph: fix symbol versioning for ceph_monc_do_statfs" that works around it by rewriting that line in a way that genksyms understands. Arnd