From mboxrd@z Thu Jan 1 00:00:00 1970 From: Icenowy Zheng Subject: Re: [PATCH 1/2] dt: bindings: add allwinner, otg-routed property for phy-sun4i-usb Date: Wed, 21 Sep 2016 15:19:56 +0800 Message-ID: <6718551474442396@web16h.yandex.ru> References: <20160921070406.27445-1-icenowy@aosc.xyz> <4a1ab62a-4091-fd75-d753-fb30585dffa5@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <4a1ab62a-4091-fd75-d753-fb30585dffa5@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Hans de Goede , Rob Herring , Kishon Vijay Abraham I , Maxime Ripard , Chen-Yu Tsai , Andre Przywara Cc: Mark Rutland , "devicetree@vger.kernel.org" , Reinder de Haan , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org CgoyMS4wOS4yMDE2LCAxNToxMCwgIkhhbnMgZGUgR29lZGUiIDxoZGVnb2VkZUByZWRoYXQuY29t PjoKPiBIaSwKPgo+IE9uIDA5LzIxLzIwMTYgMTA6MDQgQU0sIEljZW5vd3kgWmhlbmcgd3JvdGU6 Cj4+IMKgT24gc29tZSBuZXdlciBBbGx3aW5uZXIgU29DcyAoSDMgb3IgQTY0KSwgdGhlIFBIWTAg Y2FuIGJlIGVpdGhlciByb3V0ZWQgdG8KPj4gwqB0aGUgTVVTQiBjb250cm9sbGVyICh3aGljaCBp cyBhbiBPVEcgY29udHJvbGxlcikgb3IgdGhlIE9IQ0kvRUhDSSBwYWlyCj4+IMKgKHdoaWNoIGlz IGEgSG9zdC1vbmx5IGNvbnRyb2xsZXIsIGJ1dCBtb3JlIHN0YWJsZSBhbmQgZWFzeSB0byBpbXBs ZW1lbnQpLgo+Pgo+PiDCoFRoaXMgcHJvcGVydHkgbWFya3Mgd2hldGhlciBvbiBhIGNlcnRhaW4g Ym9hcmQgd2hpY2ggY29udHJvbGxlciBzaG91bGQgYmUKPj4gwqBhdHRhY2hlZCB0byB0aGUgUEhZ Lgo+Pgo+PiDCoFNpZ25lZC1vZmYtYnk6IEljZW5vd3kgWmhlbmcgPGljZW5vd3lAYW9zYy54eXo+ Cj4KPiBFcm0sIEkgdGhpbmsgdGhhdCB0aGUgaWRlYSBoZXJlIGlzIHRvIGR5bmFtaWNhbGx5IHN3 aXRjaCB0aGUgcm91dGluZwo+IGJhc2VkIG9uIHRoZSBpZC1waW4gb2YgdGhlIG90ZyBjb25uZWN0 b3IuIElPVyB1c2UgdGhlIG11c2IgY29udHJvbGxlcgo+IGZvciBkZXZpY2UgbW9kZSwgYW5kIHRo ZSBlaGNpL29oY2kgcHJvcGVyIGZvciBwcm9wZXIgaG9zdCBzdXBwb3J0Cj4gd2hlbiBpbiBob3N0 IG1vZGUuCgpBdCBsZWFzdCBvbiBzb21lIGJvYXJkcyB0aGlzIGltcGxlbWVudGF0aW9uIHdvcmtz Li4uCgooSSBtZWFuIFBpbmU2NCwgd2hpY2ggaGFzIHR3byBVU0ItQSBjb25uZWN0b3JzKQoKPgo+ IFJlZ2FyZHMsCj4KPiBIYW5zCj4KPj4gwqAtLS0KPj4gwqDCoERvY3VtZW50YXRpb24vZGV2aWNl dHJlZS9iaW5kaW5ncy9waHkvc3VuNGktdXNiLXBoeS50eHQgfCA3ICsrKysrKysKPj4gwqDCoDEg ZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKykKPj4KPj4gwqBkaWZmIC0tZ2l0IGEvRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BoeS9zdW40aS11c2ItcGh5LnR4dCBiL0RvY3Vt ZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9waHkvc3VuNGktdXNiLXBoeS50eHQKPj4gwqBp bmRleCAyODcxNTBkLi41YzExZDU3IDEwMDY0NAo+PiDCoC0tLSBhL0RvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy9waHkvc3VuNGktdXNiLXBoeS50eHQKPj4gwqArKysgYi9Eb2N1bWVu dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGh5L3N1bjRpLXVzYi1waHkudHh0Cj4+IMKgQEAg LTM2LDYgKzM2LDEzIEBAIE9wdGlvbmFsIHByb3BlcnRpZXM6Cj4+IMKgwqAtIHVzYjFfdmJ1cy1z dXBwbHkgOiByZWd1bGF0b3IgcGhhbmRsZSBmb3IgY29udHJvbGxlciB1c2IxIHZidXMKPj4gwqDC oC0gdXNiMl92YnVzLXN1cHBseSA6IHJlZ3VsYXRvciBwaGFuZGxlIGZvciBjb250cm9sbGVyIHVz YjIgdmJ1cwo+Pgo+PiDCoCtPcHRpb25hbCBwcm9wZXJ0aWVzIGZvciBIMyBvciBBNjQgU29DczoK Pj4gwqArLSBhbGx3aW5uZXIsb3RnLXJvdXRlZCA6IFVTQjAgKE9URykgUEhZIGlzIHJvdXRlZCB0 byBPSENJL0VIQ0kgcGFpciByYXRoZXIgdGhhbgo+PiDCoCsgTVVTQi4gKGJvb2xlYW4sIGlmIHRo aXMgcHJvcGVydHkgaXMgc2V0LCB0aGUgT0hDSS9FSENJCj4+IMKgKyBjb250cm9sbGVycyBhdCBQ SFkwIHNob3VsZCBiZSBlbmFibGVkIGFuZCB0aGUgTVVTQgo+PiDCoCsgY29udHJvbGxlciBtdXN0 ICpOT1QqIGJlIGVuYWJsZWQsIGFuZCB0aHVzIHRoZSBQSFkgY2FuCj4+IMKgKyBvbmx5IHdvcmsg aW4gaG9zdCBtb2RlKQo+PiDCoCsKPj4gwqDCoEV4YW1wbGU6Cj4+IMKgwqDCoMKgwqDCoMKgwqDC oMKgdXNicGh5OiBwaHlAMHgwMWMxMzQwMCB7Cj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCNwaHktY2VsbHMgPSA8MT47CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1h cm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: icenowy@aosc.xyz (Icenowy Zheng) Date: Wed, 21 Sep 2016 15:19:56 +0800 Subject: [PATCH 1/2] dt: bindings: add allwinner, otg-routed property for phy-sun4i-usb In-Reply-To: <4a1ab62a-4091-fd75-d753-fb30585dffa5@redhat.com> References: <20160921070406.27445-1-icenowy@aosc.xyz> <4a1ab62a-4091-fd75-d753-fb30585dffa5@redhat.com> Message-ID: <6718551474442396@web16h.yandex.ru> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 21.09.2016, 15:10, "Hans de Goede" : > Hi, > > On 09/21/2016 10:04 AM, Icenowy Zheng wrote: >> ?On some newer Allwinner SoCs (H3 or A64), the PHY0 can be either routed to >> ?the MUSB controller (which is an OTG controller) or the OHCI/EHCI pair >> ?(which is a Host-only controller, but more stable and easy to implement). >> >> ?This property marks whether on a certain board which controller should be >> ?attached to the PHY. >> >> ?Signed-off-by: Icenowy Zheng > > Erm, I think that the idea here is to dynamically switch the routing > based on the id-pin of the otg connector. IOW use the musb controller > for device mode, and the ehci/ohci proper for proper host support > when in host mode. At least on some boards this implementation works... (I mean Pine64, which has two USB-A connectors) > > Regards, > > Hans > >> ?--- >> ??Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt | 7 +++++++ >> ??1 file changed, 7 insertions(+) >> >> ?diff --git a/Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt b/Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt >> ?index 287150d..5c11d57 100644 >> ?--- a/Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt >> ?+++ b/Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt >> ?@@ -36,6 +36,13 @@ Optional properties: >> ??- usb1_vbus-supply : regulator phandle for controller usb1 vbus >> ??- usb2_vbus-supply : regulator phandle for controller usb2 vbus >> >> ?+Optional properties for H3 or A64 SoCs: >> ?+- allwinner,otg-routed : USB0 (OTG) PHY is routed to OHCI/EHCI pair rather than >> ?+ MUSB. (boolean, if this property is set, the OHCI/EHCI >> ?+ controllers at PHY0 should be enabled and the MUSB >> ?+ controller must *NOT* be enabled, and thus the PHY can >> ?+ only work in host mode) >> ?+ >> ??Example: >> ??????????usbphy: phy at 0x01c13400 { >> ??????????????????#phy-cells = <1>;