From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C75AC433DB for ; Tue, 26 Jan 2021 05:53:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 632D9229C4 for ; Tue, 26 Jan 2021 05:53:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388091AbhAZFxc (ORCPT ); Tue, 26 Jan 2021 00:53:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728192AbhAYMmZ (ORCPT ); Mon, 25 Jan 2021 07:42:25 -0500 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 921D2C0611C3; Mon, 25 Jan 2021 04:40:22 -0800 (PST) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1l41AK-00BPsj-3w; Mon, 25 Jan 2021 13:40:20 +0100 Message-ID: <671b0c37867803d7229ef0c4a33baf2c7778df08.camel@sipsolutions.net> Subject: Re: pull-request: mac80211 2021-01-18.2 From: Johannes Berg To: Hans de Goede , "Peer, Ilan" , "netdev@vger.kernel.org" Cc: "linux-wireless@vger.kernel.org" , "Coelho, Luciano" Date: Mon, 25 Jan 2021 13:40:19 +0100 In-Reply-To: <6c949dbe-5593-2274-7099-c2768b770aad@redhat.com> References: <20210118204750.7243-1-johannes@sipsolutions.net> <77c606d4-a78a-1fa3-5937-b270c3d0bbd3@redhat.com> <348210d8-6940-ca8d-e3b1-f049330a2087@redhat.com> <666b3449fe33d34123255cc69da3aa46fc276dcb.camel@sipsolutions.net> <6c949dbe-5593-2274-7099-c2768b770aad@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi, > > I don't have that much sympathy for a staging driver that's clearly > > doing things differently than it was intended (the documentation states > > that the function should be called only before wiphy_register(), not > > during ndo_open). :-) > > I completely understand and I already was worried that this might be > a staging-driver issue, which is why I mentioned this was with a > staging driver in the more detailed bug-report email. I guess I missed that, but no worries. > > But OTOH, that fix to the driver is simple and looks correct to me since > > it only ever has a static regdomain, and the notifier does the work of > > applying it to the channels as well. > > So I've given your fix a quick try and it leads to a NULL pointer deref. Ouch. Oh. I see, that driver is *really* stupid, trying to get to the wiphy from the adapter, but going through the wdev instead ... ouch. Wow are these pointers a mess in that driver ... Something like this, perhaps? https://p.sipsolutions.net/4400d9a3b7b800bb.txt johannes