From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 5/5] net/szedata2: add more supported
	firmwares
Date: Mon, 29 May 2017 13:42:18 +0100
Message-ID: <671d38c4-1c27-c7f0-5aa7-678f6731b6ca@intel.com>
References: <1495821956-5050-1-git-send-email-vido@cesnet.cz>
 <1495821956-5050-5-git-send-email-vido@cesnet.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
To: Matej Vido <vido@cesnet.cz>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 788717CE4
 for <dev@dpdk.org>; Mon, 29 May 2017 14:42:21 +0200 (CEST)
In-Reply-To: <1495821956-5050-5-git-send-email-vido@cesnet.cz>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/26/2017 7:05 PM, Matej Vido wrote:
> Add IBUF and OBUF offsets definitions for new firmwares.

just to double check, is it required to add new pci device ids to
support these new cards?

Is dpdk supported nics (http://dpdk.org/doc/nics) needs to be updated?

Can you please update release notes to announce new cards support?

> 
> Signed-off-by: Matej Vido <vido@cesnet.cz>

<...>

> +#elif RTE_LIBRTE_PMD_SZEDATA2_AS == 5
> +
> +const uint32_t szedata2_ibuf_base_table[] = {
> +	0x8000,
> +	0x8200,
> +	0x8400,
> +	0x8600,
> +	0x8800
> +};
> +const uint32_t szedata2_obuf_base_table[] = {
> +	0x9000,
> +	0x9200,
> +	0x9400,
> +	0x9600,
> +	0x9800
> +};

AS = 5 is not documented in both documentation and source code comment,
can you please add this one too?

> +
>  #else
>  #error "RTE_LIBRTE_PMD_SZEDATA2_AS has wrong value, see comments in config file"
>  #endif
>